Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++

2012-08-03 Thread Carlo de Falco
On 2 Aug 2012, at 23:22, Simon Josefsson wrote: > Carlo de Falco writes: > >> Hi, >> >> In order to use base64.h in GNU/Octave we had to wrap the #include >> <"base64.h"> in extern "C" scope. We believe it would have been better >> if this had been done upstream. Would it be possible to apply

Re: stat-time.h vs. -Waggregate-return

2012-08-03 Thread Jim Meyering
Simon Josefsson wrote: > Eric Blake writes: >> On 08/02/2012 04:49 PM, Paul Eggert wrote: >>> On 08/02/2012 03:40 PM, Eric Blake wrote: /* Store *ST's access time into *TS. */ static inline void get_stat_atime (struct stat const *st, struct timespec *ts) >>> >>> I'd rather not go t

Re: stat-time.h vs. -Waggregate-return

2012-08-03 Thread Simon Josefsson
Eric Blake writes: > On 08/02/2012 04:49 PM, Paul Eggert wrote: >> On 08/02/2012 03:40 PM, Eric Blake wrote: >>> /* Store *ST's access time into *TS. */ >>> static inline void >>> get_stat_atime (struct stat const *st, struct timespec *ts) >> >> I'd rather not go that route, as the functional s

Re: maint.mk: improve the release procedure

2012-08-03 Thread Jim Meyering
Akim Demaille wrote: > There is still the uploading step which is not bound to a make target. I > would remove the emit_upload_command completely, and instead mention the > upload target in README-release, including the announcement step, WDYT? Hi Akim, I like the added automation. Thanks. AC

Re: stat-time.h vs. -Waggregate-return

2012-08-03 Thread Bruno Haible
Paul Eggert wrote: > disable -Waggregate-return. It a completely > anachronistic warning, since its motivation was to > support backwards compatibility with C compilers that > did not allow returning structures. Those compilers > are long dead and are no longer of practical concern. I agree 100%

Re: maint.mk: improve the release procedure

2012-08-03 Thread Akim Demaille
Le 3 août 2012 à 10:36, Stefano Lattarini a écrit : > Hi Akim. > > On 08/03/2012 10:14 AM, Akim Demaille wrote: >> >> --- a/top/maint.mk >> +++ b/top/maint.mk >> @@ -1134,7 +1134,7 @@ sc_makefile_path_separator_check: >> # i.e., when pkg-M.N.tar.xz already exists (either in "." or in ../release

Re: maint.mk: improve the release procedure

2012-08-03 Thread Stefano Lattarini
Hi Akim. On 08/03/2012 10:14 AM, Akim Demaille wrote: > > --- a/top/maint.mk > +++ b/top/maint.mk > @@ -1134,7 +1134,7 @@ sc_makefile_path_separator_check: > # i.e., when pkg-M.N.tar.xz already exists (either in "." or in ../release) > # and is read-only. > writable-files: > - if test -d $(

maint.mk: improve the release procedure

2012-08-03 Thread Akim Demaille
There is still the uploading step which is not bound to a make target. I would remove the emit_upload_command completely, and instead mention the upload target in README-release, including the announcement step, WDYT? commit 0987dee3270299009103409818f2c5ea22a87aa6 Author: Akim Demaille Date:

Re: [PATCH] gnumakefile: better interaction with Automake-NG

2012-08-03 Thread Stefano Lattarini
On 08/02/2012 07:49 PM, Eric Blake wrote: > On 08/02/2012 11:00 AM, Eric Blake wrote: >> On 08/02/2012 10:53 AM, Stefano Lattarini wrote: >>> * modules/gnumakefile [Makefile.am]: The makefiles generated by >>> Automake-NG always contain a definition of VPATH, even in non-VPATH >>> builds (its value