Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
Jim Meyering wrote: > Jim Meyering wrote: > >> Jim Meyering wrote: >> >>> Paul Eggert wrote: On 08/05/2012 06:27 AM, Jim Meyering wrote: > * configure.ac: Disable -Wmissing-declarations to avoid warnings > from gnulib's newly extern-inline functions. This shouldn't be n

Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
Jim Meyering wrote: > Jim Meyering wrote: > >> Paul Eggert wrote: >>> On 08/05/2012 06:27 AM, Jim Meyering wrote: >>> * configure.ac: Disable -Wmissing-declarations to avoid warnings from gnulib's newly extern-inline functions. >>> >>> This shouldn't be needed if your compiler is suffici

Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
Jim Meyering wrote: > Paul Eggert wrote: >> On 08/05/2012 06:27 AM, Jim Meyering wrote: >> >>> * configure.ac: Disable -Wmissing-declarations to avoid warnings >>> from gnulib's newly extern-inline functions. >> >> This shouldn't be needed if your compiler is sufficiently >> new, because timespec.

Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
Paul Eggert wrote: > On 08/05/2012 06:27 AM, Jim Meyering wrote: > >> * configure.ac: Disable -Wmissing-declarations to avoid warnings >> from gnulib's newly extern-inline functions. > > This shouldn't be needed if your compiler is sufficiently > new, because timespec.h's _GL_INLINE_HEADER_BEGIN >

Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Paul Eggert
On 08/05/2012 06:27 AM, Jim Meyering wrote: > * configure.ac: Disable -Wmissing-declarations to avoid warnings > from gnulib's newly extern-inline functions. This shouldn't be needed if your compiler is sufficiently new, because timespec.h's _GL_INLINE_HEADER_BEGIN is supposed to suppress those w

new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
With the latest from gnulib, I get things like this expanded from timespec.h, and they trigger many -Wmissing-declarations warnings in coreutils: #define _GL_TIMESPEC_INLINE _GL_INLINE # 57 "timespec.h" inline int timespec_cmp (struct timespec a, struct timespec b) { retu

Re: [PATCH] maint.mk: forbid exit(-1)

2012-08-05 Thread Jim Meyering
Eric Blake wrote: > Libvirt accidentally had an 'exit (-1)' which got by the syntax > checker; generally, exiting with 255 is not a wise idea. > > * top/maint.mk (sc_prohibit_magic_number_exit): Detect negatives. ... > diff --git a/top/maint.mk b/top/maint.mk > index d5af750..b39e9ae 100644 > --- a