Re: another manywarnings failure

2012-09-06 Thread Jim Meyering
Eric Blake wrote: I compiled on FreeBSD 8.2 (gcc 4.2.1), and when I updated to the latest gnulib, I started to see the following in config.log when running ./configure CFLAGS=-g: configure:53920: checking whether C compiler handles -Wuninitialized configure:53939: gcc -std=gnu99 -c -g

Re: [PATCH] net_if: new module

2012-09-06 Thread Jasper Lievisse Adriaanse
On Wed, Sep 05, 2012 at 03:59:10PM -0600, Eric Blake wrote: OpenBSD's net/if.h is not self-contained; this should compile: | #define _POSIX_C_SOURCE 200809L | #include net/if.h | struct if_nameindex i; but fails with: In file included from foo.c:2: /usr/include/net/if.h:112: error:

Re: another manywarnings failure

2012-09-06 Thread Eric Blake
On 09/06/2012 12:07 AM, Jim Meyering wrote: Eric Blake wrote: I compiled on FreeBSD 8.2 (gcc 4.2.1), and when I updated to the latest gnulib, I started to see the following in config.log when running ./configure CFLAGS=-g: When you configure with one set of warning options and later

Re: [PATCH] net_if: new module

2012-09-06 Thread Eric Blake
On 09/06/2012 01:06 AM, Jasper Lievisse Adriaanse wrote: On Wed, Sep 05, 2012 at 03:59:10PM -0600, Eric Blake wrote: OpenBSD's net/if.h is not self-contained; this should compile: | #define _POSIX_C_SOURCE 200809L | #include net/if.h | struct if_nameindex i; but fails *

Re: another manywarnings failure

2012-09-06 Thread Jim Meyering
Eric Blake wrote: On 09/06/2012 12:07 AM, Jim Meyering wrote: Eric Blake wrote: I compiled on FreeBSD 8.2 (gcc 4.2.1), and when I updated to the latest gnulib, I started to see the following in config.log when running ./configure CFLAGS=-g: When you configure with one set of warning

Re: another manywarnings failure

2012-09-06 Thread Eric Blake
On 09/06/2012 06:48 AM, Jim Meyering wrote: Actually, with GNU make, this is something that we could probably adjust at make-time. Only if you use Automake-NG, and can assume GNU make. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: poll() emulation in git

2012-09-06 Thread Paolo Bonzini
Il 06/09/2012 16:02, Joachim Schmitz ha scritto: But is there something that could be done to make git work even without poll()? It is used in 5 places: $ grep -n poll\( *.c */*.c credential-cache--daemon.c:175: if (poll(pfd, 1, 1000 * wakeup) 0) { daemon.c:1018: if (poll(pfd,

Re: another manywarnings failure

2012-09-06 Thread Jim Meyering
Jim Meyering wrote: ... Yes, it looks like if we're using both of those, we'll have to add code to reject -Wuninitialized (maybe with a warning?) when configuring without -O. ... [here's simple PoC, i.e., it doesn't know about -O0, but you get the idea ] W = -Wuninitialized -Werror CFLAGS

Re: poll() emulation in git

2012-09-06 Thread Paolo Bonzini
Il 06/09/2012 16:44, Joachim Schmitz ha scritto: Yes, it's an usleep(autocorrect * 10) basically (poll takes milliseconds, not micro). OK, it is _supposed_ to do this usleep(), but is does not, as poll() returns early with EFAULT in this case: /* EFAULT is not necessary to implement,

Re: GNU sed version 4.2.1: on OS X, C locale gets aliased to UTF-8

2012-09-06 Thread Paul Eggert
Alas, I don't use OS X, or Mac OS X, or whatever it's called these days, so I can't easily test any fix, and I'd like some discussion if possible. In January Bruno wrote that my proposed patch http://lists.gnu.org/archive/html/bug-gnulib/2012-01/msg00319.html would break gettext-based i18n of GNU

Re: GNU sed version 4.2.1: on OS X, C locale gets aliased to UTF-8

2012-09-06 Thread Max Horn
Hi again! On 06.09.2012, at 11:08, Paul Eggert wrote: Alas, I don't use OS X, or Mac OS X, or whatever it's called these days, so I can't easily test any fix, and I'd like some discussion if possible. Sure. In January Bruno wrote that my proposed patch

Re: GNU sed version 4.2.1: on OS X, C locale gets aliased to UTF-8

2012-09-06 Thread Paul Eggert
On 09/06/2012 11:03 AM, Max Horn wrote: I proposed the exact same patch you proposed back in January. Ah, sorry, I was confused. Again. Ouch. Please let me try to summarize the situation to make sure that I understand it. We're talking about two different patches, either of which you say

Re: broken OpenBSD net/if.h [was: [libvirt] [PATCH] Include some extra headers needed for OpenBSD.]

2012-09-06 Thread Jasper Lievisse Adriaanse
On Tue, Sep 04, 2012 at 11:37:30AM -0600, Eric Blake wrote: On 09/04/2012 11:23 AM, Jasper Lievisse Adriaanse wrote: On Tue, Sep 04, 2012 at 11:08:30AM -0600, Eric Blake wrote: [adding gnulib] Ouch. The POSIX definition of net/if.h doesn't include any interface that needs to use struct

[PATCH] manywarnings: cater to more gcc infelicities

2012-09-06 Thread Eric Blake
Some versions of gcc (at least 4.2.1) noisily warn if -Wuninitialized is given without -O; in isolation, configure learns that the warning option is supported, but when later compiling with -Werror, this makes builds fail. If the option will have no effect for the configured choice of $CFLAGS,