Re: fstatat.c broken in OpenBSD 4.6

2012-09-30 Thread Jim Meyering
Mats Erik Andersson wrote: lördag den 29 september 2012 klockan 19:16 skrev Jim Meyering detta: Mats Erik Andersson wrote: fstatat.c:26:10: #include expects FILENAME or FILENAME That appears to be due to a typo. Can you confirm the following fix solves the problem? Works well. The

Re: lib-ld.m4 duplicates libtool.m4's --with-gnu-ld

2012-09-30 Thread Bruno Haible
Hi Simon, I noticed this problem that was reported to gnutls some time ago. It seems lib-ld.m4 contains a copy of some code from libtool.m4 The reason is that 1) module 'havelib' does not want to assume the use of libtool (remember, 'havelib' is about _using_ shared libraries, not

Re: unistd.h has to be included twice to avoid compile errors on MinGW

2012-09-30 Thread Bruno Haible
Hi, Philip Nienhuis wrote on 2012-08-26: See this thread: http://lists.gnu.org/archive/html/bug-gnulib/2011-01/msg00473.html When compiling code invoking gnulib under MinGW, the statement #include unistd.h has to present in duplo to avoid certain errors of the kind: ... is not a

Re: diffutils test failure on nixos/hydra's solaris build

2012-09-30 Thread Bruno Haible
Jim Meyering wrote on 2012-08-28: FAIL: test-localeconv (exit: 262) = test-localeconv.c:41: assertion failed which corresponds to this line: $ cat -n tests/test-localeconv.c|grep -B6 41 35{ 36 struct lconv *l =

Re: gnulib doesn't add lib/spawn.h to .gitignore?

2012-09-30 Thread Bruno Haible
[Dropping bug-coreutils from CC] Hi Stefano, OK, this is a minor annoyance rather than a real bug, but I guess reporting it won't hurt. In GNU coreutils, the gnulib-provided 'bootstrap' script fails to add the generated file 'lib/spawn.h' to the .gitignore in 'lib/': $ ./bootstrap

Re: [PATCH 3/9] tls-tests: omit unnecessary 'inline'

2012-09-30 Thread Bruno Haible
Hi Paul, Simplicity and portability trump efficiency in test cases. Agreed. Thanks for the change. Bruno

Re: [PATCH 4/9] sockets, sys_stat: remove AC_C_INLINE in MSVC-only cases

2012-09-30 Thread Bruno Haible
Hi Paul, * m4/sockets.m4 (gl_SOCKETS): * m4/sys_stat_h.m4 (gl_HEADER_SYS_STAT_H): Remove AC_C_INLINE. Here, 'inline' is used only in MSVC environments where it's already guaranteed to work Nope. MSVC does *not* support 'inline' for functions. Quoting

Re: [PATCH 4/9] sockets, sys_stat: remove AC_C_INLINE in MSVC-only cases

2012-09-30 Thread Paul Eggert
On 09/30/2012 03:22 PM, Bruno Haible wrote: Nope. MSVC does *not* support 'inline' for functions. Thanks for catching that. Sorry, I thought they supported it, it's been in the standard for what, 12 years now? Anyway, I reverted that change.

Re: [PATCH 4/9] sockets, sys_stat: remove AC_C_INLINE in MSVC-only cases

2012-09-30 Thread Michael Goffioul
On Sun, Sep 30, 2012 at 7:24 PM, Paul Eggert egg...@cs.ucla.edu wrote: On 09/30/2012 03:22 PM, Bruno Haible wrote: Nope. MSVC does *not* support 'inline' for functions. Thanks for catching that. Sorry, I thought they supported it, it's been in the standard for what, 12 years now?