Re: FreeBSD bugs

2012-10-01 Thread Bruno Haible
Hi Ed, > it looks like we're pretty close to having all of > the tests apply and pass on FreeBSD so I suspect I don't have many > more to find. Do you know what is the status of the following bugs in the newest FreeBSD release? Let me cite the sections of gnulib documentation. You find the test c

Re: diffutils test failure on nixos/hydra's solaris build

2012-10-01 Thread Bruno Haible
Hi Ed, > For FreeBSD specifically I'd rather conclude either that this is a bug > in our localeconv and fix it, or that more than one value for > l->grouping is permissible and change the test. Looking at http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap07.html http://pubs.open

Re: [PATCH] set SO_REUSE* before bind(), not after

2012-10-01 Thread Ed Maste
On 1 October 2012 19:52, Bruno Haible wrote: > Hi, > > Ed Maste wrote: >> While investigating skipped tests on FreeBSD I found that test-poll >> and test-select were skipped due to bind() returning EADDRINUSE. It >> turns out that these tests call setsockopt(..., SO_REUSE... after >> calling bind

Re: [PATCH] set SO_REUSE* before bind(), not after

2012-10-01 Thread Bruno Haible
Hi, Ed Maste wrote: > While investigating skipped tests on FreeBSD I found that test-poll > and test-select were skipped due to bind() returning EADDRINUSE. It > turns out that these tests call setsockopt(..., SO_REUSE... after > calling bind(), not before. You're obviously right. SO_REUSEADDR c

Re: Problem with new release target in maint.mk

2012-10-01 Thread Reuben Thomas
On 1 October 2012 22:49, Eric Blake wrote: > therefore, there are TWO 'line 1' locations within the release-prep > rule, because there are two shells spawned. Didn't spot the lack of continuation, which, as it turned out, was precisely the opposite of the bug I'd introduced. I must be backslash-b

Re: Problem with new release target in maint.mk

2012-10-01 Thread Eric Blake
On 10/01/2012 02:03 PM, Reuben Thomas wrote: > On 1 October 2012 20:37, Jim Meyering wrote: >> Reuben Thomas wrote: >>> I get the following error while trying to make a GNU Zile release: >>> >>> /bin/bash: -c: line 1: syntax error near unexpected token `then' >>> /bin/bash: -c: line 1: `@if test -

[PATCH] set SO_REUSE* before bind(), not after

2012-10-01 Thread Ed Maste
While investigating skipped tests on FreeBSD I found that test-poll and test-select were skipped due to bind() returning EADDRINUSE. It turns out that these tests call setsockopt(..., SO_REUSE... after calling bind(), not before. diff --git a/tests/test-poll.c b/tests/test-poll.c index 7ba0280..6

Re: Problem with new release target in maint.mk

2012-10-01 Thread Jim Meyering
Reuben Thomas wrote: > On 1 October 2012 20:37, Jim Meyering wrote: >> Reuben Thomas wrote: >>> I get the following error while trying to make a GNU Zile release: >>> >>> /bin/bash: -c: line 1: syntax error near unexpected token `then' >>> /bin/bash: -c: line 1: `@if test -d ../release; then \' >

Re: Problem with new release target in maint.mk

2012-10-01 Thread Reuben Thomas
Wait, I got it. I managed to splice two lines that shouldn't be spliced when making a small edit to maint.mk. Sorry for the noise. -- http://rrt.sc3d.org

Re: Problem with new release target in maint.mk

2012-10-01 Thread Reuben Thomas
On 1 October 2012 20:37, Jim Meyering wrote: > Reuben Thomas wrote: >> I get the following error while trying to make a GNU Zile release: >> >> /bin/bash: -c: line 1: syntax error near unexpected token `then' >> /bin/bash: -c: line 1: `@if test -d ../release; then \' >> make[2]: *** [release-prep

Re: Problem with new release target in maint.mk

2012-10-01 Thread Jim Meyering
Reuben Thomas wrote: > I get the following error while trying to make a GNU Zile release: > > /bin/bash: -c: line 1: syntax error near unexpected token `then' > /bin/bash: -c: line 1: `@if test -d ../release; then \' > make[2]: *** [release-prep] Error 1 > > I'm using bash 4.2.24(1)-release as shi

Problem with new release target in maint.mk

2012-10-01 Thread Reuben Thomas
I get the following error while trying to make a GNU Zile release: /bin/bash: -c: line 1: syntax error near unexpected token `then' /bin/bash: -c: line 1: `@if test -d ../release; then\' make[2]: *** [release-prep] Error 1 I'm using bash 4.2.24(1)-release as shipped with Ubuntu 12.04. /bin/sh

Re: diffutils test failure on nixos/hydra's solaris build

2012-10-01 Thread Ed Maste
On 1 October 2012 13:48, Jim Meyering wrote: > Ed Maste wrote: > >> On 30 September 2012 17:39, Bruno Haible wrote: >>> Jim Meyering wrote on 2012-08-28: FAIL: test-localeconv (exit: 262) = test-localeconv.c:41: assertion failed

Re: Add hash_pjw_s(), 3rd attempt

2012-10-01 Thread Jim Meyering
Nikos Mavrogiannopoulos wrote: > On 09/27/2012 10:19 PM, Nikos Mavrogiannopoulos wrote: >> Updated. > > Hello, > Any update on that? Do you plan to include it? Hi Nikos, I went to deal with the mechanics of adding it and noticed a few details. What do you think about hash_pjw_no_mod or hash_pjw

Re: Add hash_pjw_s(), 3rd attempt

2012-10-01 Thread Jim Meyering
Nikos Mavrogiannopoulos wrote: > On 09/27/2012 10:19 PM, Nikos Mavrogiannopoulos wrote: > >> Updated. > Any update on that? Do you plan to include it? Yes, I'll apply it shortly. Thanks.

Re: Add hash_pjw_s(), 3rd attempt

2012-10-01 Thread Nikos Mavrogiannopoulos
On 09/27/2012 10:19 PM, Nikos Mavrogiannopoulos wrote: > Updated. Hello, Any update on that? Do you plan to include it? regards, Nikos

Re: diffutils test failure on nixos/hydra's solaris build

2012-10-01 Thread Jim Meyering
Ed Maste wrote: > On 30 September 2012 17:39, Bruno Haible wrote: >> Jim Meyering wrote on 2012-08-28: >>> FAIL: test-localeconv (exit: 262) >>> = >>> >>> test-localeconv.c:41: assertion failed >>> >>> which corresponds to this line: >>> >>> $ cat -

Re: unistd.h has to be included twice to avoid compile errors on MinGW

2012-10-01 Thread Philip Nienhuis
Bruno Haible wrote: Hi, Philip Nienhuis wrote on 2012-08-26: See this thread: http://lists.gnu.org/archive/html/bug-gnulib/2011-01/msg00473.html When compiling code invoking gnulib under MinGW, the statement #include has to present in duplo to avoid certain errors of the kind: "... is no

Re: diffutils test failure on nixos/hydra's solaris build

2012-10-01 Thread Ed Maste
On 30 September 2012 17:39, Bruno Haible wrote: > Jim Meyering wrote on 2012-08-28: >> FAIL: test-localeconv (exit: 262) >> = >> >> test-localeconv.c:41: assertion failed >> >> which corresponds to this line: >> >> $ cat -n tests/test-localeconv.c|gr

Re: [PATCH 4/9] sockets, sys_stat: remove AC_C_INLINE in MSVC-only cases

2012-10-01 Thread Bruno Haible
Hi Paul, > Anyway, I reverted that change. Thanks. Bruno