Re: C locale *printf functions ?

2012-12-18 Thread Ben Pfaff
On Tue, Dec 18, 2012 at 06:41:47PM +0100, Jim Meyering wrote: > Ben Pfaff wrote: > > Here is a revised version. It passes the included tests, so I'll > > wait 72 hours for comments and then commit it if no one objects. > > That sounds great. > I haven't reviewed all of that, but really like the id

[PATCH] argp: better 'inline'

2012-12-18 Thread Paul Eggert
Use extern-inline module to declare extern inline functions. This avoids some bogus warning diagnostics. Problem discovered when modifying GNU tar to use the manywarnings module. * lib/argp.h, lib/argp-xinl.c (ARGP_EI) [!_LIBC]: * lib/argp-fmtstream.h, lib/argp-fs-xinl.c (ARGP_FS_EI) [!_LIBC]: De

Re: inline -Werror=missing-declarations warnings

2012-12-18 Thread Pádraig Brady
On 12/18/2012 03:16 AM, Paul Eggert wrote: On 12/17/12 17:35, Pádraig Brady wrote: Should the check in extern-inline.m4 be expanded to all __GNUC_? 39cedf6f said the issue was only with gcc 4.8, but GCC 4.5.3 (on cygwin at least), seems to have the issue too. If I understand things correctly,

Re: C locale *printf functions ?

2012-12-18 Thread Jim Meyering
Ben Pfaff wrote: > Here is a revised version. It passes the included tests, so I'll > wait 72 hours for comments and then commit it if no one objects. ... > ChangeLog | 43 > lib/c-asprintf.c | 35 +++ > lib/c-snprintf.c

Re: inline -Werror=missing-declarations warnings

2012-12-18 Thread Z. Majeed
the check as it stands works only for gcc 4.6 and later because of #pragma GCC diagnostic push|pop --- On Mon, 12/17/12, Pádraig Brady wrote: On 12/17/2012 11:50 AM, Z. Majeed wrote: > Building latest [coreutils] git source (=> gnulib d245e6d)... > ... I had to configure --disable-gcc-warnings