RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2013-02-20 Thread V S, Nagendra (Nonstop Filesystems Team)
> On 07/19/2012 11:55 PM, V S, Nagendra (Nonstop Filesystems Team) wrote: > > Find the entire patch we use attached. > > Thanks, a brief review of the patch suggests that there is enough material in > it that we should get copyright papers signed before we can incorporate all > those changes in th

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2013-02-20 Thread Paul Eggert
On 07/19/2012 11:55 PM, V S, Nagendra (Nonstop Filesystems Team) wrote: > Find the entire patch we use attached. Thanks, a brief review of the patch suggests that there is enough material in it that we should get copyright papers signed before we can incorporate all those changes in the GNU versio

Re: full_read depends on incoming errno

2013-02-20 Thread Andy Wingo
On Wed 20 Feb 2013 20:02, Eli Zaretskii writes: > Btw, it might be a good idea to provide some application-level > diagnostics in this specific case, since "No error", which corresponds > to errno = 0, is not very useful. I pushed this: if (full_read (fd, cookie, sizeof cookie) != sizeof co

Re: full_read depends on incoming errno

2013-02-20 Thread Eli Zaretskii
> From: Andy Wingo > Cc: egg...@cs.ucla.edu, bug-gnulib@gnu.org > Date: Wed, 20 Feb 2013 20:58:13 +0100 > > if (full_read (fd, cookie, sizeof cookie) != sizeof cookie > || full_read (fd, SCM_BYTEVECTOR_CONTENTS (bv), > SCM_BYTEVECTOR_LENGTH (bv)) != SCM_BYTEVECT

Re: [Bug-tar] [PATCH 0/1] Notes for wordsplit

2013-02-20 Thread Eric Blake
On 02/20/2013 11:30 AM, Sergey Poznyakoff wrote: > Hi Paul, > >> Developers are assumed to have up-to-date systems where -Werror is >> appropriate. > > Frankly, I cannot imagine a situation where treaing a warning as an > error can be appropriate. That's why I consider it unfortunate. If code c

Re: [Bug-tar] [PATCH 0/1] Notes for wordsplit (was: Allow tar to usecommand for compressing consisiting of multiple words.)

2013-02-20 Thread Sergey Poznyakoff
Hi Paul, > Developers are assumed to have up-to-date systems where -Werror is > appropriate. Frankly, I cannot imagine a situation where treaing a warning as an error can be appropriate. That's why I consider it unfortunate. > I'm surprised you didn't run into this. That's quite simple. Confi

Re: full_read depends on incoming errno

2013-02-20 Thread Eli Zaretskii
> From: Andy Wingo > Cc: Eli Zaretskii , bug-gnulib@gnu.org > Date: Tue, 19 Feb 2013 22:50:18 +0100 > > >> I think it's a Guile > >> problem, since from gnulib POV, nothing went wrong in that call. > > > > Yes, that sounds right. > > You are both right, yes. Thanks for the help and sorry for t

Re: [Bug-tar] [PATCH 0/1] Notes for wordsplit (was: Allow tar to usecommand for compressing consisiting of multiple words.)

2013-02-20 Thread Paul Eggert
On 02/20/2013 05:15 AM, Sergey Poznyakoff wrote: > Pavel Raiskup ha escrit: > >> It was just sugestion as tar uses -Werror by default since this commit: > > Ouch! A very unfortunate move, I must say. It works well in other projects, such as coreutils: 'make' uses -Werror only for developers, wh

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2013-02-20 Thread Paul Eggert
On 07/19/2012 11:55 PM, V S, Nagendra (Nonstop Filesystems Team) wrote: > The coreutils config.hin no more defines any of RAW_DECL_* functions, which > where present in 8.15. Thanks, good catch. I have pushed the following patch to gnulib to fix this; it should appear in the next coreutils relea