Re: libc-config.h + cdefs.h

2017-09-06 Thread Bruno Haible
Hi Gisle, > There are some other trivial stuff in: >./lib/count-leading-zeros.h >./lib/count-one-bits.h >./lib/iconv.in.h >./lib/inttypes.in.h >./lib/localtime-buffer.c > > which I'll come back to. Huh? There were no issues with MSVC 14 in these places in my latest round of t

Re: gnulib-tool.py

2017-09-06 Thread Tim Rühsen
On Dienstag, 5. September 2017 23:35:54 CEST Dmitry Selyutin wrote: > Hi Tim, > > that's exactly what I've done today. I've just pushed some changes into > repository; could you please try the latest version? > I didn't have time to integrate --no-changelog support yet (it seems it was > either un

Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result

2017-09-06 Thread Adhemerval Zanella
On 06/09/2017 13:18, Paul Eggert wrote: > Adhemerval Zanella wrote: >> My understanding was double underscore identifiers are reserved for >> implementation >> (C99 7.1.3 Reserved identifiers). > > Yes, and that's the point. When this code is used as part of Gnulib, it is > used within an appl

Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result

2017-09-06 Thread Paul Eggert
Adhemerval Zanella wrote: My understanding was double underscore identifiers are reserved for implementation (C99 7.1.3 Reserved identifiers). Yes, and that's the point. When this code is used as part of Gnulib, it is used within an application, so any identifiers it uses that start with __ m

Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result

2017-09-06 Thread Adhemerval Zanella
On 06/09/2017 01:18, Paul Eggert wrote: > Adhemerval Zanella wrote: >> +enum glob_pattern_type_t >> +{ >> + __GLOB_NONE = 0x0, >> + __GLOB_SPECIAL = 0x1, >> + __GLOB_BACKSLASH = 0x2, >> + __GLOB_BRACKET = 0x4 >> +}; > > The identifier glob_pattern_type_t is not used elsewhere, so le

Re: libc-config.h + cdefs.h

2017-09-06 Thread Gisle Vanem
Paul Eggert wrote: Hmm, is it because of the '#define __inline' to nothing later on? OK, I can see where that might be an issue. Exactly, in glob.c which includes the Windows-SDK function: __inline struct _TEB *NtCurrentTeb (void) { return (struct _TEB *) (ULONG_PTR) __readfsdword (0x