Re: gnulib-lib/xalloc-oversized.h:45:0: warning: "xalloc_oversized" redefined

2020-03-22 Thread Jeffrey Walton
On Sun, Mar 22, 2020 at 8:32 PM Bruno Haible wrote: > > Paul Eggert wrote: > > Gnulib's lib/xalloc.h has not had that line since 2011. Sounds like you > > have an > > old copy and need to upgrade. > > Yes, GNU libiconv and GNU gettext still have an old copy of xalloc.h. It's > harmless, only prod

Re: gnulib-lib/xalloc-oversized.h:45:0: warning: "xalloc_oversized" redefined

2020-03-22 Thread Bruno Haible
Paul Eggert wrote: > Gnulib's lib/xalloc.h has not had that line since 2011. Sounds like you have > an > old copy and need to upgrade. Yes, GNU libiconv and GNU gettext still have an old copy of xalloc.h. It's harmless, only produces a warning. Bruno

Re: gnulib-lib/xalloc-oversized.h:45:0: warning: "xalloc_oversized" redefined

2020-03-22 Thread Jeffrey Walton
On Sun, Mar 22, 2020 at 7:14 PM Paul Eggert wrote: > > On 3/22/20 3:47 PM, Jeffrey Walton wrote: > > In file included from message.c:31:0: > > ../gnulib-lib/xalloc.h:149:0: note: this is the location of the > > previous definition > > # define xalloc_oversized(n, s) \ > > Gnulib's lib/xalloc.h h

Re: [PATCH] ISO 8601 basic format and decimal hours, minutes

2020-03-22 Thread Alex Eulenberg
Posting my response now that I have I finally got the copyright assignment, including employer disclaimer, finalized. Original patch posted Feb 19, 2019, for reference: https://lists.gnu.org/archive/html/bug-gnulib/2019-02/msg00041.html Now responding to Assaf's comments from April of last yea

Re: gnulib-lib/xalloc-oversized.h:45:0: warning: "xalloc_oversized" redefined

2020-03-22 Thread Paul Eggert
On 3/22/20 3:47 PM, Jeffrey Walton wrote: In file included from message.c:31:0: ../gnulib-lib/xalloc.h:149:0: note: this is the location of the previous definition # define xalloc_oversized(n, s) \ Gnulib's lib/xalloc.h has not had that line since 2011. Sounds like you have an old copy and n

gnulib-lib/xalloc-oversized.h:45:0: warning: "xalloc_oversized" redefined

2020-03-22 Thread Jeffrey Walton
Hi Everyone, Would someone please clear this warning before the next release. It is prevalent in some packages, like iconv. In file included from ../gnulib-lib/malloca.h:26:0, from ../gnulib-lib/xmalloca.h:21, from message.c:32: ../gnulib-lib/xalloc-oversized.h:4

Re: Use of chmod in gnulib

2020-03-22 Thread Jeffrey Walton
On Sun, Mar 22, 2020 at 3:18 PM Paul Eggert wrote: > > On 3/22/20 10:17 AM, Jeffrey Walton wrote: > > > According to the Autoconf manual, commands like 'chmod +x' should be > > avoided in favor of 'chmod a+x'. I believe the same applies to 'chmod > > -w' and friends. Also see > > https://www.gnu.o

Re: Use of chmod in gnulib

2020-03-22 Thread Paul Eggert
On 3/22/20 10:17 AM, Jeffrey Walton wrote: According to the Autoconf manual, commands like 'chmod +x' should be avoided in favor of 'chmod a+x'. I believe the same applies to 'chmod -w' and friends. Also see https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Limitations-of-Usua

Use of chmod in gnulib

2020-03-22 Thread Jeffrey Walton
Hi Everyone, According to the Autoconf manual, commands like 'chmod +x' should be avoided in favor of 'chmod a+x'. I believe the same applies to 'chmod -w' and friends. Also see https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Limitations-of-Usual-Tools.html. It looks like the

Re: [PATCH] Do not store build time in MODULES.html

2020-03-22 Thread Bruno Haible
Hi Bernhard, > func_echo '' > -func_echo 'Generated from MODULES.html.sh on '`LC_ALL=C date > +"%e %B %Y"`. > +func_echo 'Generated from MODULES.html.sh'. > The date is important, so that readers of know whether it is up-to-date or not. Howe

add dependencies to 'stat'

2020-03-22 Thread Bruno Haible
On 2020-03-08 I wrote: > We have documented on 2020-01-03 that fstat() needs workarounds even on plain > glibc/Linux systems. So, basically every use of fstat() in gnulib needs a > dependency on the 'fstat' module. Likewise for the 'stat' module. I found these (listing the source files and corresp

Re: file-has-acl: fix module description

2020-03-22 Thread Bruno Haible
> 1) The condition [test $gl_need_lib_has_acl] could give a shell syntax > error. > It should be [test -n "$gl_need_lib_has_acl"]. Likewise in m4/acl.m4. 2020-03-22 Bruno Haible acl-permissions: Improve autoconf macro. * m4/acl.m4 (gl_FUNC_ACL): Test the value of gl_n

file-has-acl: fix module description

2020-03-22 Thread Bruno Haible
The module description has three problems: 1) The condition [test $gl_need_lib_has_acl] could give a shell syntax error. It should be [test -n "$gl_need_lib_has_acl"]. 2) lib/file-has-acl.c needs module acl-permissions unconditionally, to get the acl_errno_valid function (used both when GE