[PATCH] canonicalize-lgpl: fix memory leak

* lib/canonicalize-lgpl.c (__realpath): Fix unlikely memory leak, which could have occurred if BUF was so large that malloc was called. Do this by allocating EXTRA_BUF and BUF at the same time; this eliminates the need to free BUF separately. --- ChangeLog | 8 lib/canonic

Re: [PATCH] bootstrap: add hooks for user-defined command-line options

> Thanks, I installed that in your name. Thank you.

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

On 11/22/20 10:59 AM, Bernhard Voelker wrote: selinux.c:257 has a superfluous semicolon after a jump label, and a strange indentation: The semicolon is required by the C standard, which does not allow a label before a declaration. Emacs indented it that way.

Fix missing module dependencies to 'xalloc'

A gnulib testdir for module 'xvasprintf' fails to build: $ ./gnulib-tool --test --single-configure xvasprintf ... ../../gllib/xvasprintf.c: In function 'xstrcat': ../../gllib/xvasprintf.c:61:12: warning: implicit declaration of function 'XNMALLOC' [-Wimplicit-function-declaration] result = XNM

Re: Signals on Mingw

On Sun, 22 Nov 2020 at 22:47, Bruno Haible wrote: > > Two questions to consider: > > - What other effects would it have to define '_POSIX' ? In which other > places > is this macro being referenced? > It is used to define modes for read/write in fcntl.h (O_RDONLY and friends), getlogin and

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

On 11/22/20 6:27 AM, Bernhard Voelker wrote: This is caught by a syntax-check rule as well. Fixed with the attached patch - as well as 2 other sc failures. Thanks for fixing that. The tabs got introduced because I edited mv.c with an unusual Emacs configuration, which I'll try to remember to n

Re: [PATCH] bootstrap: add hooks for user-defined command-line options

Thanks, I installed that in your name.

Re: [PATCH] bootstrap: add hooks for user-defined command-line options

Can someone who actively uses 'bootstrap' please review this? Thanks. Jose E. Marchesi wrote in : > This patch adds a couple of hooks to the `bootstrap' script that > allows the users to handle their own command line options in

Re: Signals on Mingw

Hi Reuben, > I find that it is necessary to #define _POSIX to get a full set of POSIX > signal names defined in mingw's signal.h. I'm slightly surprised to find > this is not implemented in gnulib: is there a reason? > > If not, it would be straightforward to add > > #ifdef __MINGW32__ > #define

%z for printf on mingw

gnulib can #define __USE_MINGW_ANSI_STDIO so that %z is implemented, but warnings are still generated for xasprintf (not for printf). As far as I can tell, this is because the _GL_ATTRIBUTE_FORMAT_PRINTF_SYSTEM machinery to choose the correct attribute (__gnu_printf__ or __printf__) for printf-lik

Signals on Mingw

I find that it is necessary to #define _POSIX to get a full set of POSIX signal names defined in mingw's signal.h. I'm slightly surprised to find this is not implemented in gnulib: is there a reason? If not, it would be straightforward to add #ifdef __MINGW32__ #define _POSIX #endif before the #

argp: Don't break getprogname on non-glibc systems

In a testdir of all of gnulib, 'test-getprogname' crashes on Alpine Linux 3.12. The cause is that the 'argp' module defines program_invocation_short_name as a global variable, outside libc, and therefore libc cannot initialize it. This patch fixes it. 2020-11-22 Bruno Haible argp: Do

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

On 11/22/20 7:08 PM, Pádraig Brady wrote: > Non leaky version attached. Thanks. Looks good to me - on system without active SELinux: tested once with and once --without-selinux. Minor nit (from Paul's commit): selinux.c:257 has a superfluous semicolon after a jump label, and a strange indentatio

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

On 22/11/2020 17:56, Pádraig Brady wrote: On 22/11/2020 14:27, Bernhard Voelker wrote: On 11/22/20 1:28 PM, Kamil Dudka wrote: The coreutils patch introduced tab-indented lines into src/mv.c, which otherwise does not use tabs for indentation. This is caught by a syntax-check rule as well. Fix

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

On 22/11/2020 14:27, Bernhard Voelker wrote: On 11/22/20 1:28 PM, Kamil Dudka wrote: The coreutils patch introduced tab-indented lines into src/mv.c, which otherwise does not use tabs for indentation. This is caught by a syntax-check rule as well. Fixed with the attached patch - as well as 2 o

doc: Document

The Gnulib documentation has a section regarding the function 'dl_iterate_phdr', but not regarding the header file which declares this function. This makes no sense. 2020-11-22 Bruno Haible doc: Document . * doc/glibc-headers/link.texi: New file. * doc/gnulib.texi: Inc

doc: Add references to the LSB

Since glibc and musl libc are now two libcs with supposedly the same API, it's useful to be able to reference the common specification behind this API. Beyond POSIX, it is the LSB. Also some of the API (e.g. dl_iterate_phdr) is found on BSD systems as well, but not specified by POSIX. Therefore i

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

On 11/22/20 1:28 PM, Kamil Dudka wrote: > The coreutils patch introduced tab-indented lines into src/mv.c, which > otherwise does not use tabs for indentation. This is caught by a syntax-check rule as well. Fixed with the attached patch - as well as 2 other sc failures. > I can see 3 tests failin

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

On Sunday, November 22, 2020 3:45:22 AM CET Paul Eggert wrote: > Yes, it's looking like great minds think alike. > > The coreutils patch I had prepared is fancier than yours, though, as it > caches the result of selabel_open and this should yield better performance. > > I don't use SELinux either

Re: Build issues with gettext 0.20.2 and 0.21 on Solaris 10 i386 with 64 bit

Hi Bruno, Am 17.11.2020 um 22:55 schrieb Bruno Haible : >> I am currently trying to compile the most recent gettext on Solaris 10 and >> found an issue. >> The error shows on Solaris 10 i386 64 bit only, sparc and i386 32 bit are >> not affected: >> >> gmake[4]: Entering directory >> '/home/da