Re: makefile rules

On 12/24/21 09:24, Bruno Haible wrote: It seems to work fine on all platforms I tested: Linux distros, macOS, FreeBSD, NetBSD, OpenBSD, AIX, Solaris, Minix (all with the default 'make'). Thanks for testing, and for the review. I installed the patches with your suggested improvements.

libtextstyle-optional fails ./gnulib-tool --test

The command "./gnulib-tool --test libtextstyle-optional" fails with the last few output lines as follows. I tried going back into the past but didn't find an old Gnulib version where the command worked (though the failure symptoms differed), so I don't think this is purely due to recent Gnulib

passfd: Fix compilation error on IRIX

On IRIX 6.5, the passfd module does not compile any more, since the headers now define CMSG_FIRSTHDR. passfd.c: In function `sendfd': passfd.c:57: warning: implicit declaration of function `CMSG_SPACE' passfd.c:74: error: `SCM_RIGHTS' undeclared (first use in this function) passfd.c:74: error:

tests: Fix link errors on AIX

On AIX 7.1 with xlc, building a testdir of all of gnulib produces link errors: xlC -q64 -qthreaded -qtls -g -L/home/haible/prefix64/lib -o test-fnmatch-h-c++ test-fnmatch-h-c++.o libtests.a ../gllib/libgnu.a libtests.a ../gllib/libgnu.a libtests.a -lm -lm -lm -lm -lm -lm -lm -lm

hamt tests: Fix compilation error with AIX xlc

Compiling a testdir on AIX 7.1 with xlc, I get this compilation error: source='test-hamt.c' object='test-hamt.o' libtool=no DEPDIR=.deps depmode=xlc /bin/sh ../build-aux/depcomp xlc -q64 -qthreaded -qtls -DHAVE_CONFIG_H -DEXEEXT=\"\" -I. -I.. -DGNULIB_STRICT_CHECKING=1 -DIN_GNULIB_TESTS=1

strerrorname_np: Fix compilation error on IRIX

On IRIX 6.5, I see a compilation error: strerrorname_np.c: In function `strerrorname_np': strerrorname_np.c:572: error: duplicate case value strerrorname_np.c:468: error: previously used here This patch fixes it. 2021-12-24 Bruno Haible strerrorname_np: Fix compilation error on

Re: makefile rules

Paul Eggert wrote: > I haven't installed this patchset into Gnulib, as I want to test it on a > few more platforms and also would like to hear comments. It seems to work fine on all platforms I tested: Linux distros, macOS, FreeBSD, NetBSD, OpenBSD, AIX, Solaris, Minix (all with the default

hamt: Fix compilation error on NetBSD 7

On NetBSD 7, I get a compilation error in hamt.h, at the token '_Atomic'. On this platform, GCC is 4.8.x, __STDC_VERSION__ is 201112L, and __STD_NO_ATOMICS__ is not defined. In these conditions, hamt.h defines GL_HAMT_THREAD_SAFE to 1. It should define it to 0 instead. 2021-12-24 Bruno Haible

search: Fix compilation errors with SunPRO C++ on Solaris 10

On Solaris 10, with cc and CC as compilers, I get these compilation errors: "../gllib/search.h", line 565: Error: Cannot return extern "C" void*(*)(const void*,const void*,unsigned*,unsigned,extern "C" int(*)(const void*,const void*)) from a function that should return void*(*)(const

qsort_r: Fix compilation error with SunPRO C++ on Solaris 10

On Solaris 10, with cc and CC as compilers, I get this compilation error: "../gllib/stdlib.h", line 1406: Error: Cannot return extern "C" void(*)(void*,unsigned,unsigned,extern "C" int(*)(const void*,const void*,void*),void*) from a function that should return

threads-h tests: Avoid clang warnings

On FreeBSD, I am seeing compiler warnings: test-threads.c:42:11: warning: no case matching constant switch condition '0' test-threads.c:53:11: warning: no case matching constant switch condition '0' This patch should fix them. 2021-12-24 Bruno Haible threads-h tests: Avoid clang

doc: Small updates

Mac OS X >= 10.3.4 has ptsname_r. And FreeBSD >= 13 has a POSIX-compliant getlogin_r declaration. 2021-12-24 Bruno Haible doc: Small updates. * doc/glibc-functions/ptsname_r.texi: Update info regarding Mac OS X. * doc/posix-functions/getlogin_r.texi: Update info

Re: makefile rules

Paul Eggert wrote: > I haven't installed this patchset into Gnulib, as I want to test it on a > few more platforms and also would like to hear comments. Comments: 1) In 0001: modules/sed-header should have a section Applicability: all Like e.g. modules/gperf or modules/snippet/arg-nonnull.

Re: makefile rules

Paul Eggert wrote: > I also installed the second attached patch, which adds a couple of > @NMD@s that were missed earlier. Thanks. Yes, I missed the ones in modules/libgmp. Bruno

Re: makefile rules

Paul Eggert wrote: >SED_HEADER_BEGIN = -n \ > -e 1h \ > -e '1s,.*,/* DO NOT EDIT! GENERATED AUTOMATICALLY! *,w $@-t' \ > -e 1g >SED_HEADER_END = \ > -e 'w $@-t' > > (and we can put comments near this explaining 'sed' to the uninitiated :-). Yes, these comments are what