Re: Avoid DoS vulnerability through unsafe default assignment

2022-07-30 Thread Bruno Haible
> -: "${PERL='perl'}" > +: "${PERL="perl"}" I had not expected that this would make a difference, but it does. This sequence of commands : ${A=perl} : ${B="perl"} : ${C='perl'} : "${D=perl}" : "${E="perl"}" : "${F='perl'}" echo "A=$A" echo "B=$B" echo "C=$C" echo "D=$D" echo "E=$E" echo "F=$F" p

Re: split bootstrap in two phases

2022-07-30 Thread Bruno Haible
Paul Eggert wrote: > For what it's worth Emacs has its own autogen.sh. But it doesn't use > 'bootstrap' so I expect it won't collide. Does the new documentation ([1], case 2, sub-case (C), as well as case 3) cover Emacs adequately? We can't go into all details here, because there is significant v

Re: Instructions on new bootstrap?

2022-07-30 Thread Bruno Haible
I have also updated the public documentation on www.gnu.org. The sections that changed regarding 'bootstrap' are: https://www.gnu.org/software/gnulib/manual/html_node/VCS-Issues.html https://www.gnu.org/software/gnulib/manual/html_node/Developer-tools.html Bruno

Re: Avoid DoS vulnerability through unsafe default assignment

2022-07-30 Thread Bruno Haible
> 2022-07-23 Bruno Haible > > Avoid DoS vulnerability through unsafe default assignment. > See https://www.shellcheck.net/wiki/SC2223 . This change caused an error in gendocs.sh: Generating monolithic html... (env LANG= LC_MESSAGES= LC_ALL= LANGUAGE= makeinfo --no-split --html

Re: split bootstrap in two phases

2022-07-30 Thread Paul Eggert
On 7/30/22 16:43, Bruno Haible wrote: There is no actual collision, because your tool is 'autogen' [1], and this is 'autogen.sh'. For what it's worth Emacs has its own autogen.sh. But it doesn't use 'bootstrap' so I expect it won't collide.

Re: split bootstrap in two phases

2022-07-30 Thread Bruce Korb
On 7/30/22 16:43, Bruno Haible wrote: I offered to help Miguel de Icaza with his Gnome project, he didn't want the help, but did adopt my project's name. Oh, so the similarity between the names is not completely fortuitous. But meanwhile the name has spread; it is now even used in the Linux

Re: split bootstrap in two phases

2022-07-30 Thread Bruno Haible
Hi Bruce, > >> The second phase is a script 'autogen.sh'. > > I'd like to object to that name. :) There is no actual collision, because your tool is 'autogen' [1], and this is 'autogen.sh'. Also, since a significant percentage of the users don't have '.' in $PATH, the instructions say to run './

Re: split bootstrap in two phases

2022-07-30 Thread Bruce Korb
On 7/30/22 13:45, Simon Josefsson via Gnulib discussion list wrote: Wonderful, thank you! I have yet to digest everything, so I'll fall back on stylistic comments: The first phase is a script 'autopull.sh'. The second phase is a script 'autogen.sh'. I'd like to object to that name. :) I o

Re: Instructions on new bootstrap?

2022-07-30 Thread Bruno Haible
Paul Smith wrote: > how all this is supposed to work in the modern era? I'm updating the documentation: 2022-07-30 Bruno Haible doc: Update regarding bootstrap split. Reported by Paul Smith . * doc/gnulib-tool.texi (gettextize and autopoint): Mention autogen.sh

Re: split bootstrap in two phases - .sh suffix

2022-07-30 Thread Bruno Haible
Simon Josefsson wrote: > > The first phase is a script 'autopull.sh'. > > The second phase is a script 'autogen.sh'. > ... > > The names of these scripts end with '.sh' in order to make them easily > > editable in editors that recognize the file type from the suffix. > > What do you think about dr

Re: split bootstrap in two phases - why two scripts

2022-07-30 Thread Bruno Haible
Simon Josefsson wrote: > Thinking about all this, do we really need two new scripts? There > is inflation in all these tools and documentation files. Could the > separation be done via './bootstrap --pull' and './bootstrap --generate' > with the default './bootstrap' be to do both? It's two diff

Re: Instructions on new bootstrap?

2022-07-30 Thread Paul Smith
On Sat, 2022-07-30 at 22:55 +0200, Bruno Haible wrote: > Paul Smith wrote: > > > In your case, the sync already happened. So, either you must have > > > had > > >    bootstrap_sync=true > > > in your bootstrap.conf, or you passed the option --bootstrap-sync > > > manually. > > > > Neither of those

Re: Instructions on new bootstrap?

2022-07-30 Thread Bruno Haible
Paul Smith wrote: > > In your case, the sync already happened. So, either you must have had > > bootstrap_sync=true > > in your bootstrap.conf, or you passed the option --bootstrap-sync > > manually. > > Neither of those were the case; this was what I was trying (in too many > words) to say. A

Re: split bootstrap in two phases

2022-07-30 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > Recent discussion in gnu-prog-discuss has shown that making the separation > into two phases (1) and (2) explicit will have several benefits: Wonderful, thank you! I have yet to digest everything, so I'll fall back on stylistic comments: > The first phase is a script 'au

Re: bootstrap: Obey another environment variable GNULIB_REFDIR

2022-07-30 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > The handling of the GNULIB_SRCDIR environment variable in 'bootstrap' > is hard to understand, despite the long documentation in `bootstrap --help`. Thank you! I have encountered this a couple of times, and always had to read the source code to learn how it worked, and th

Re: Instructions on new bootstrap?

2022-07-30 Thread Paul Smith
On Sat, 2022-07-30 at 22:01 +0200, Bruno Haible wrote: > > which seems to imply that unless I add that flag or set > > bootstrap_sync in my bootstrap.conf file (which I did not), the > > sync won't happen. > > In your case, the sync already happened. So, either you must have had >   bootstrap_sync

Re: Instructions on new bootstrap?

2022-07-30 Thread Bruno Haible
Paul Smith wrote: > Are there instructions on how the new model of bootstrap is supposed to > be used somewhere? I can't quite figure it out. > > I pulled in the latest gnulib/build-aux/bootstrap and ran it, then when > it was complete git shows: > > Changes not staged for commit: > modi

Instructions on new bootstrap?

2022-07-30 Thread Paul Smith
Are there instructions on how the new model of bootstrap is supposed to be used somewhere? I can't quite figure it out. I pulled in the latest gnulib/build-aux/bootstrap and ran it, then when it was complete git shows: Changes not staged for commit: modified: bootstrap Untracked files