Paul Eggert wrote:
> > Do you see a problem with fixing these things? May I go ahead and modernize
> > this?
>
> No, please feel free, and thanks.
This patch should fix all mentioned problems.
2023-11-15 Bruno Haible
obstack: Modernize, fixing several problems.
* lib/obstack
On 2023-11-15 10:46, Bruno Haible wrote:
Do you see a problem with fixing these things? May I go ahead and modernize
this?
No, please feel free, and thanks.
Gavin Smith wrote:
> It is surprising it worked as well as it did with mixing the two different
> struct definitions.
Yes. Probably because the alignment only matters on sparc64 and ia64 machines,
and because no new features were added to this module in 20 years.
> Thanks for the detailed investi
Hi Paul,
A number of things are wrong in the obstack module.
* It makes use of and an idiom described therein.
This idiom is how Ulrich Drepper imagined glibc code to be used in
GNU packages in 1997. This idiom was meant to be used for
obstack
regex
glob
getopt
This idiom p
Hi Matoro,
> These all run Gentoo unstable, with relevant glibc (currently 2.38).
Thanks. I've added the info at
https://git.savannah.gnu.org/gitweb/?p=gnulib/maint-tools.git;a=blob;f=platforms/test-environments.txt
> Feel free to pip in on IRC or shoot me an email to get an account.
Thanks, I'
On Tue, Nov 14, 2023 at 10:16:33PM +0100, Bruno Haible wrote:
> Sam James wrote:
> > > It appears that the obstack gnulib module is the culprit.
>
> I replied:
> > Therefore, if it is a bug in gnulib, it is also a bug in glibc.
>
> Sam was right. I was wrong. It is a bug in the 'obstack' gnulib m
On Wed, Nov 15, 2023 at 12:22:24AM -0800, Paul Eggert wrote:
> On 2023-11-13 01:28, Patrice Dumas wrote:
> > According to your mail
> > https://lists.gnu.org/archive/html/bug-libunistring/2023-11/msg0.html
> >
> > char32_t is less portable
>
> That should be OK, if Gnulib provides a char32_t
On 2023-11-13 01:28, Patrice Dumas wrote:
According to your mail
https://lists.gnu.org/archive/html/bug-libunistring/2023-11/msg0.html
char32_t is less portable
That should be OK, if Gnulib provides a char32_t substitute that works
well enough. The mail you refer to merely says that liter
* lib/striconveha.c (uniconv_register_autodetect): Rewrite to
avoid the need to cast from char * to a pointer to a more strictly
aligned type. Use decls after statements to avoid some repetition.
---
ChangeLog | 7 +++
lib/striconveha.c | 25 ++---
2 files changed
