Re: [PATCH] fstatat: pacify GCC on unusual platform

2017-11-05 Thread Jim Meyering
On Sun, Nov 5, 2017 at 2:29 PM, Paul Eggert wrote: > * lib/fstatat.c (orig_fstatat) [!HAVE_WORKING_FSTATAT_ZERO_FLAG]: > Omit, as it’s unused in this case. Thanks. For the record, which platform required that?

Re: latest gcc vs lib/timespec.h:85

2017-10-29 Thread Jim Meyering
On Sun, Oct 29, 2017 at 4:27 PM, Paul Eggert wrote: > Jim Meyering wrote: >> >> Here's a proposed patch: > > I prefer 'assume' to 'assure' here, since it's a low-level time-comparison > primitive and lots of other code in the module already

Re: latest gcc vs lib/timespec.h:85

2017-10-29 Thread Jim Meyering
On Fri, Oct 27, 2017 at 9:33 PM, Jim Meyering wrote: > On Mon, Oct 2, 2017 at 6:31 PM, Paul Eggert wrote: >> On 10/02/2017 06:24 PM, Jim Meyering wrote: >>> >>> Given all of the comments on that function, I'd be tempted to suppress >>> this warnin

Re: latest gcc vs lib/timespec.h:85

2017-10-27 Thread Jim Meyering
On Mon, Oct 2, 2017 at 6:31 PM, Paul Eggert wrote: > On 10/02/2017 06:24 PM, Jim Meyering wrote: >> >> Given all of the comments on that function, I'd be tempted to suppress >> this warning in that function. > > That would work. Another possibility would be to incl

Re: FYI, shorter lists.gnu.org URLs, finally

2017-10-26 Thread Jim Meyering
On Thu, Oct 26, 2017 at 6:31 PM, Paul Eggert wrote: > On 10/26/2017 05:30 PM, Jim Meyering wrote: >> >> Now, instead of >> http://lists.gnu.org/archive/html/bug-coreutils/2017-10/threads.html >> you can write the shorter >> http://lists.gnu.org/r/bug-coreutils/201

FYI, shorter lists.gnu.org URLs, finally

2017-10-26 Thread Jim Meyering
Now, instead of http://lists.gnu.org/archive/html/bug-coreutils/2017-10/threads.html you can write the shorter http://lists.gnu.org/r/bug-coreutils/2017-10/threads.html This applies to all mailing lists hosted on lists.gnu.org. Sometimes it matters, especially when a URL is longer than the maximu

Re: Automatically pushing the new version tag in release process

2017-10-06 Thread Jim Meyering
On Fri, Oct 6, 2017 at 1:35 AM, Reuben Thomas wrote: > Currently, HACKING contains: > > * Push the NEWS-updating changes and the new tag: > > v=$(cat .prev-version) > git push origin master tag v$v > > Is there some reason this can't or shouldn't be done at one of the release > stages? Eit

Re: [libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-06 Thread Jim Meyering
ding some sort of language= > tag to feed to $(_sc_search_regexp (if not specified, run on all files, > but if specified as C, the syntax-check is specific to C-like files, so > it limits to .h, .c. .y). > > I'm adding the gnulib list to get feedback on the idea; maybe Jim > Meyer

latest gcc vs lib/timespec.h:85

2017-10-02 Thread Jim Meyering
Hi Paul, Mainly just a heads up, since this certainly isn't blocking me. When trying to build coreutils using gcc built from very recent (with some change committed since Sep 26), I see this new warning/error: In file included from src/system.h:140:0, from src/ls.c:84: src/ls.c:

Re: new module 'strlcpy'

2017-09-27 Thread Jim Meyering
On Wed, Sep 27, 2017 at 5:44 PM, Bruno Haible wrote: > I wrote: >>In some places the users >>will notice that strlcpy does not buy them much, compared to the >>"avoid arbitrary limits"[1] approach, and will switch over to what >>you call "GNU style". In other places, they will inse

Re: FTP->HTTPS; maybe HTTP->HTTPS for Gnulib?

2017-09-12 Thread Jim Meyering
I like the idea. On Sep 12, 2017 16:44, "Paul Eggert" wrote: > Since the GNU project is decommissioning FTP soon, I installed the > attached. > > What do people think about changing the Gnulib documention and code to use > HTTPS instead of HTTP? That should help repel man-in-the-middle attacks.

Re: [PATCH] git-version-gen: Fix for tags containing '-'

2017-08-06 Thread Jim Meyering
On Sun, Aug 6, 2017 at 9:22 AM, Paul Eggert wrote: > Thanks for reporting the problem. Unfortunately that patch didn't work for > me, since Git sometimes outputs more than 4 hex digits after the "g", if > needed to avoid ambiguity. Please try the attached further patch, which I > installed. Thank

Re: [PATCH] git-version-gen: Fix for tags containing '-'

2017-08-06 Thread Jim Meyering
On Sat, Aug 5, 2017 at 11:26 PM, Markus Armbruster wrote: > Really old versions of git-describe (before v1.5.0, Feb 2007) don't > have the number of commits in their long format output, i.e. where > modern 'git describe --abbrev=4 --match="v*"' prints > "v0.1-1494-g124b9", they print "v0.1-1494-g1

Re: License of c99 and std-gnu11 modules

2017-08-03 Thread Jim Meyering
On Thu, Aug 3, 2017 at 12:29 PM, Paul Eggert wrote: > On 08/03/2017 11:35 AM, Bruno Haible wrote: >> >> 'std-gnu11' (and 'c99' with it) could IMO really be 'LGPLv2+' or >> 'unlimited' - like inline, extern-inline, warnings, extensions. >> >> 'd-ino', 'host-os', 'longlong' could IMO be switched to

[PATCH] fprintftime: fix build-break caused by recent renaming

2017-07-26 Thread Jim Meyering
f67b69 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2017-07-26 Jim Meyering + + fprintftime: fix build-break caused by recent renaming + * lib/fprintftime.c: Include "nstrftime.c", not the now-renamed + "strftime.c". + * modules/fprintftime: D

Re: more systematic m4 quoting

2017-07-11 Thread Jim Meyering
On Tue, Jul 11, 2017 at 1:57 PM, Bruno Haible wrote: > When going through all AC_RUN_IFELSE invocations, I noticed some places > without systematic m4 quoting (like we used to do in the first years of > autoconf) or misleading indentation. > > When people complain about the GNU Build System, one o

[PATCH] maint: update to work with GCC7's -Werror=implicit-fallthrough=

2017-06-10 Thread Jim Meyering
I've just pushed this: >From b47afb1438293decd3982d8097157411ba6b5ed4 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 10 Jun 2017 10:11:47 -0700 Subject: [PATCH] maint: update to work with GCC7's -Werror=implicit-fallthrough= * lib/savewd.c (FALLTHROUGH): Define.

Re: [PATCH] quotearg: fix compilation failure due to FALLTHROUGH misuse

2017-05-28 Thread Jim Meyering
On Sun, May 28, 2017 at 3:44 AM, Bernhard Voelker wrote: >> goto force_outer_quoting_style; >> - FALLTHROUGH; >> + /* fall through */ >> c_escape: >>if (backslash_escapes) >> { > > Sorry, you lost me: > "c_escape:" /is/ a case statem

[PATCH] quotearg: fix compilation failure due to FALLTHROUGH misuse

2017-05-25 Thread Jim Meyering
FYI, I've just pushed this: >From 6c720446ab4f450b86fe61113096d09f64029de4 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 25 May 2017 21:25:37 -0700 Subject: [PATCH] quotearg: fix compilation failure due to FALLTHROUGH misuse * lib/quotearg.c (quotearg_buffer_restyled): Re

Re: FALLTHROUGH warning in quotearg.c with gcc-7.1

2017-05-25 Thread Jim Meyering
On Thu, May 25, 2017 at 5:10 PM, Assaf Gordon wrote: > Hello, > > Pulling the latest gnulib and compling with gcc-7.1, > I'm seeing the following warning: > > gcc-7.1 -DLOCALEDIR=\"/usr/local/share/locale\" -DHAVE_CONFIG_H -I. -Ilib > -I./lib -Isrc -I./src -g -O2 -MT lib/quotearg.o -MD -MP

Re: [Grep-devel] avoiding new warnings

2017-05-22 Thread Jim Meyering
On Sun, May 21, 2017 at 1:10 PM, Paul Eggert wrote: > Jim Meyering wrote: >> >> two of the three instances it flagged in grep >> were odd enough that I feel they benefit from the added attention > > > Anybody reading those two instances of the code would alread

Re: [PATCH] fallthrough: update for GCC 7/8

2017-05-22 Thread Jim Meyering
On Mon, May 22, 2017 at 4:50 AM, Pádraig Brady wrote: > On 22/05/17 07:07, Bernhard Voelker wrote: >> On 05/20/2017 02:12 AM, Jim Meyering wrote: >>> * lib/quotearg.c (FALLTHROUGH): New macro. >>> Use it whenever one switch case falls through into the next, >

Re: [Grep-devel] avoiding new warnings

2017-05-21 Thread Jim Meyering
On Sun, May 21, 2017 at 12:18 PM, Paul Eggert wrote: > Jim Meyering wrote: >> >>- -Wduplicated-branches complained about three false positives, > > In Emacs, I found -Wduplicated-branches to be useless and I disabled it. > Since it's finding only false alarms in

Re: [PATCH] fallthrough: update for GCC 7/8

2017-05-20 Thread Jim Meyering
On Sat, May 20, 2017 at 3:15 AM, Bruno Haible wrote: > Jim Meyering wrote: >> * tests/test-tsearch.c (mangle_tree): Likewise. Also include >> tests/macros.h for the definition. >> * tests/test-argp.c (group1_parser): Likewise. > > The module descriptions need

[PATCH] dfa: two small simplifications

2017-05-19 Thread Jim Meyering
7c8ed..2ab6170 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2017-05-19 Jim Meyering + + dfa: two small simplifications + * lib/dfa.c (build_state): Avoid repeating longer expressions. + 2017-05-18 Jim Meyering fallthrough: update for GCC 7/8 diff --git a/lib/dfa.c

[PATCH] fallthrough: update for GCC 7/8

2017-05-19 Thread Jim Meyering
tests/test-tsearch.c | 4 +++- 9 files changed, 72 insertions(+), 19 deletions(-) diff --git a/ChangeLog b/ChangeLog index 46714cd..807c8ed 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,20 @@ +2017-05-18 Jim Meyering + + fallthrough: update for GCC 7/8 + * lib/quotearg.c

Re: results of gnulib tests with -fsanitize-address-use-after-scope

2017-05-19 Thread Jim Meyering
On Fri, May 19, 2017 at 12:18 AM, Bruno Haible wrote: > Results of a gnulib testdir configured with > CFLAGS="-O -ggdb -fsanitize-address-use-after-scope": > > No test failures. Thanks for testing with the sanitizers! I've seen -fsanitize-address-use-after-scope catch a few nasty bugs, but usuall

FYI: maint.mk: update regex to reflect 2013 addition of "assume" to verify.h

2017-05-13 Thread Jim Meyering
rify_without_use] Error 1 I've pushed the attached: From 8e2bc0b51c8e58e4c20a99ea21c84bcd6ad9d495 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 13 May 2017 18:18:22 -0700 Subject: [PATCH] maint.mk: update regex to reflect 2013 addition of "assume" to verify.h * top/maint.mk

Re: split module gettimeofday

2017-05-02 Thread Jim Meyering
On Tue, May 2, 2017 at 1:39 AM, Bruno Haible wrote: > Currently: > - gettimeofday.c contains code that is not related to gettimeofday at all - > a tzset() override, for example. > - The user who wants a fixed 'tzset' function will also get a 'gettimeofday' > replacement, for no good re

Re: rename strftime module

2017-04-30 Thread Jim Meyering
On Sun, Apr 30, 2017 at 11:53 PM, Bruno Haible wrote: > I'd suggest to rename 'strftime' to 'strftime-gnu' or 'nstrftime', and mark > the 'strftime' module obsolete for two years, then after two years remove it. > So that all users of this module have enough time to notice the change. Good plan.

Re: bug#26193: [0-9] versus [[:digit:]]

2017-03-22 Thread Jim Meyering
gt;> By the way, using LC_ALL=C should help avoid performance problems like >> these in the future, if all you're doing is something where single-byte >> pattern matching suffices. I've just pulled that gnulib change into grep's repository with the attached, along with a NEWS

Re: bug#26193: [0-9] versus [[:digit:]]

2017-03-21 Thread Jim Meyering
On Tue, Mar 21, 2017 at 7:09 PM, Paul Eggert wrote: > John P. Linderman wrote: >> >> Using what is to me the more obvious [0-9] pattern takes almost 50 times >> as >> long as using the [[:digit:]] pattern. Seems very strange. > > > Thanks for reporting that. In general, patterns like [a-z] can be

Re: Not distributing README-release automatically.

2017-03-14 Thread Jim Meyering
On Tue, Mar 14, 2017 at 11:28 AM, Mathieu Lirzin wrote: ... > Here is an updated patch with a rationale in the ChangeLog: > > Thanks for the review (to both of you). Thank you. I've pushed that.

Re: Not distributing README-release automatically.

2017-03-14 Thread Jim Meyering
On Tue, Mar 14, 2017 at 10:34 AM, Bruno Haible wrote: > Mathieu Lirzin wrote: >> Here is the patch: > > Given the code from gnulib-tool that you are removing, I think: > >> +EXTRA_DIST += top/GNUmakefile > > This should read > >EXTRA_DIST += $(top_srcdir)/GNUmakefile > >> +EXTRA_DIST += top/ma

Re: Not distributing README-release automatically.

2017-03-14 Thread Jim Meyering
On Tue, Mar 14, 2017 at 4:34 AM, Mathieu Lirzin wrote: > Jim Meyering writes: > >> On Tue, Mar 7, 2017 at 8:08 AM, Mathieu Lirzin wrote: >>> >>> Jim Meyering writes: >>> >>>> On Sun, Mar 5, 2017 at 8:12 AM, Mathieu Lirzin wrote: >>&g

Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-13 Thread Jim Meyering
On Mon, Mar 13, 2017 at 2:07 AM, Bruno Haible wrote: > the -e option is mandatory anyway when you use sed inside a pipe. Hi Bruno, I was surprised to read the above. What does it mean? This works with GNU sed and no "-e" option: $ echo abc|sed s/b/X/|cat aXc

Re: Not distributing README-release automatically.

2017-03-07 Thread Jim Meyering
On Tue, Mar 7, 2017 at 8:08 AM, Mathieu Lirzin wrote: > Hello Jim, > > Jim Meyering writes: > >> On Sun, Mar 5, 2017 at 8:12 AM, Mathieu Lirzin wrote: >>> >>> I have been using 'readme-release' module and was surprised to discover >>> that

Re: Not distributing README-release automatically.

2017-03-06 Thread Jim Meyering
On Sun, Mar 5, 2017 at 8:12 AM, Mathieu Lirzin wrote: > Hello, > > I have been using 'readme-release' module and was surprised to discover > that the "README-release" file was automatically distributed without any > mention in the "module/readme-release" file. > > After some digging I have discove

Re: coreutils snapshot vs gcc7-to-be: new test-calloc-gnu.c and test-canonicalize.c warnings

2017-03-04 Thread Jim Meyering
On Sat, Mar 4, 2017 at 5:21 PM, Bruno Haible wrote: > Hi Jim, > > Jim Meyering wrote: >> I've just fixed that with the attached and just-pushed gnulib patch: > > You "fixed" it by disabling a valuable test! I propose to restore the test > and instead

Re: coreutils snapshot vs gcc7-to-be: new test-calloc-gnu.c and test-canonicalize.c warnings

2017-03-04 Thread Jim Meyering
On Fri, Mar 3, 2017 at 4:30 PM, Jim Meyering wrote: > Building the latest coreutils snapshot with gcc just built from its > own latest git, I hit this: > > test-calloc-gnu.c: In function 'main': > test-calloc-gnu.c:32:5: warning: product '23058430092136939

Re: coreutils snapshot vs gcc7-to-be: new test-calloc-gnu.c and test-canonicalize.c warnings

2017-03-04 Thread Jim Meyering
On Sat, Mar 4, 2017 at 2:33 AM, Bruno Haible wrote: > Jim Meyering wrote: >> test-canonicalize.c:78:13: error: argument 1 null where non-null >> expected [-Werror=nonnull] >> result1 = canonicalize_file_name (null_ptr ()); >> ^~~~

coreutils snapshot vs gcc7-to-be: new test-calloc-gnu.c and test-canonicalize.c warnings

2017-03-03 Thread Jim Meyering
Building the latest coreutils snapshot with gcc just built from its own latest git, I hit this: test-calloc-gnu.c: In function 'main': test-calloc-gnu.c:32:5: warning: product '2305843009213693952 * 8' of arguments 1 and 2 exceeds 'SIZE_MAX' [-Walloc-size-larger-than=] p = calloc ((size_t

Re: The non-recursive-gnulib-prefix-hack module

2017-02-01 Thread Jim Meyering
On Wed, Feb 1, 2017 at 2:28 PM, John W. Eaton wrote: > Is there anything I can do to help get this change accepted as part of > gnulib? > > I'd really like to be able to use a completely non-recursive Makefile for > Octave. Hi John, A great step in the right direction would be to ensure that your

Re: [Grep-devel] bug#25390: Segfault with sed 4.3

2017-01-14 Thread Jim Meyering
n run against an ASAN-enabled sed. That is because valgrind just doesn't work when the binary is ASAN-enabled. So I have extemded init.cfg's require_valgrind_ function so that it also detects this case and skips the test. I will push the attached shortly, after which you are welcome to

Re: [PATCH 2/2] maint: time stamp -> timestamp

2017-01-10 Thread Jim Meyering
" rule to prohibit things like "can not", so it's easy to add there: From 94386a13667c645fd42544a7fd302c39fcdf Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 10 Jan 2017 07:19:02 -0800 Subject: [PATCH] maint.mk: enforce spelling of "

FYI: giving Assaf Gordon commit rights to the gnulib repository

2017-01-03 Thread Jim Meyering
IMHO, Assaf Gordon has been doing enough fine work for long enough that it is time to give him commit/push access to gnulib. He is in the unusual position (savannah admin) of being able to grant himself that access, so I've just told him he is welcome to do that. Welcome, Assaf! Jim

Re: [PATCH] dfa: narrow the scope of many local variables

2017-01-02 Thread Jim Meyering
Thanks.

[PATCH] dfa: narrow the scope of many local variables

2017-01-01 Thread Jim Meyering
FYI, I've just pushed this: >From 387fd77e70fe9016d30e462d46c1126b32fe449b Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 31 Dec 2016 08:06:24 -0800 Subject: [PATCH] dfa: narrow the scope of many local variables * lib/dfa.c: Now that we are no longer constrained to c

Re: bug in do-release-commit-and-tag

2016-12-31 Thread Jim Meyering
On Sat, Dec 31, 2016 at 3:18 PM, Eric Blake wrote: > I'm considering the use of do-release-commit-and-tag for releasing m4 > 1.4.18, but I tested it while in the middle of a git rebase, and got: > > $ ./build-aux/do-release-commit-and-tag 1.4.18 stable > ./build-aux/do-release-commit-and-tag: line

Re: [PATCH] maint.mk: ensure gnulib_dir is defined before use in shell

2016-12-31 Thread Jim Meyering
On Sat, Dec 31, 2016 at 2:10 PM, Eric Blake wrote: ... > Thanks. Given your patch, I reworded things slightly; here's what I'm > pushing. ... > +# You can override this variable in cfg.mk if your gnulib submodule lives > +# in a different location. > +gnulib_dir ?= $(srcdir)/gnulib Thanks for the

Re: [PATCH] maint.mk: ensure gnulib_dir is defined before use in shell

2016-12-31 Thread Jim Meyering
eLog > index eb5867f..e69ce32 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2016-12-30 Eric Blake > + > + maint.mk: ensure gnulib_dir is defined before use in shell > + * top/maint.mk (gnulib_dir): Hoist earlier. > + > 2016-12-30 Jim M

Re: avoid new "syntax-check" failure

2016-12-30 Thread Jim Meyering
On Fri, Dec 30, 2016 at 9:47 AM, Jim Meyering wrote: > Because grep now uses only symbols from intprops.h that have been > added relatively recently, the hard-coded (out of date) list of > symbols in the maint.mk rule caused the > sc_prohibit_intprops_without_use to trigger erroneous

avoid new "syntax-check" failure

2016-12-30 Thread Jim Meyering
submodule separately. I may remove the hard-coded list altogether in this case, but there are many similar tests, and not all are as straightforward. From e9ae724b20657de728050bf07f1dd1aaa019599c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 30 Dec 2016 09:42:06 +0100 Subject: [PATCH

Re: [PATCH] getopt: fix parallel test failure

2016-12-30 Thread Jim Meyering
On Thu, Dec 29, 2016 at 10:07 PM, Eric Blake wrote: > I hit a testsuite failure due to a failure removing test-getopt.tmp, > when running tests in parallel. > > * tests/test-getopt-posix.c (TEST_GETOPT_TMP_NAME): Set name. > * tests/test-getopt-gnu.c (TEST_GETOPT_TMP_NAME): Likewise. > * tests/tes

Re: getprogname and libtool

2016-12-18 Thread Jim Meyering
On Sat, Dec 17, 2016 at 3:27 PM, Bruno Haible wrote: > Followup to this discussion from October 2016: > > Jim: >> > I did not mean to imply by that message that we should eliminate every >> > use of the program_name module. My desire is more to avoid accidental >> > use of it when the getprogname

FYI: dfa: add an assertion to avoid coverity false positive

2016-12-13 Thread Jim Meyering
d, 7 insertions(+) diff --git a/ChangeLog b/ChangeLog index 8f1671a..69be242 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2016-12-12 Jim Meyering + + dfa: add an assertion to avoid coverity false positive + * lib/dfa.c (realloc_trans_if_necessary): Otherwise, coverity +

Re: [Grep-devel] patches for removing DFA_CASE_FOLD

2016-12-13 Thread Jim Meyering
On Tue, Dec 13, 2016 at 2:51 PM, Paul Eggert wrote: > On 12/13/2016 12:26 PM, Arnold Robbins wrote: >> >> - dfa->syntax.case_fold = (dfaopts & DFA_CASE_FOLD) != 0; >> + dfa->syntax.case_fold = (bits & RE_ICASE) != 0 > > > I'm afraid that didn't work, due to a missing semicolon. I fixed that up,

Re: MSVC and fpending

2016-12-12 Thread Jim Meyering
On Mon, Dec 12, 2016 at 5:58 PM, Bruno Haible wrote: > Hi Jim, > > On Windows with MSVC, the 'fpending' module does not pass its test, > because config.h defines > > #define PENDING_OUTPUT_N_BYTES 1 > > In order to get this right, the expression should be > > ((struct { unsigned char *_ptr; un

Re: [Grep-devel] [PATCH] dfa: fix performance bug that recomputes trans

2016-12-09 Thread Jim Meyering
On Fri, Dec 9, 2016 at 3:11 PM, Paul Eggert wrote: > * lib/dfa.c (build_state): Fix performance bug introduced in Nov > 25 on-demand changes. The bug caused build_state to reset all > d->trans elements to -2 even when d->trans was already non-null. > Use C99 style decls after statements in this f

yesterday's grep-2.27 release candidate could infloop

2016-11-29 Thread Jim Meyering
ee0d1acc8e050f51 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 29 Nov 2016 10:45:46 -0800 Subject: [PATCH] dfa: avoid new infinite loop This would infloop: echo cx | LC_ALL=C grep -E 'c\b[x ]' * lib/dfa.c (dfastate): When constructing a new state table, we could initially decl

Re: bug#24975: Matching issues with characters whose encoding ends in some other character

2016-11-27 Thread Jim Meyering
On Sun, Nov 20, 2016 at 9:53 PM, Jim Meyering wrote: > On Sun, Nov 20, 2016 at 2:59 PM, Stephane Chazelas > wrote: >> 2016-11-20 21:50:28 +, Stephane Chazelas: >>> $ locale charmap >>> GB18030 >>> $ printf '\uC9\n'

Re: [PATCH] dfa: addition of new state on demand

2016-11-25 Thread Jim Meyering
On Fri, Nov 25, 2016 at 11:03 AM, Paul Eggert wrote: > Norihiro Tanaka wrote: >> >> Can anyone review this change? > > > Thanks for doing all that, and sorry about the late review. I reviewed it, > tweaked its commit message and propagated that into ChangeLog (the gnulib > practice), and installed

[PATCH] fix test driver leaks: exclude, malloc, realloc

2016-11-20 Thread Jim Meyering
FYI, I've just pushed the attached, so that grep's subset of gnulib tests now pass leak-free. From 19a23ce7c07fcac4c969dfec254ba02e59975e96 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 20 Nov 2016 08:33:38 -0800 Subject: [PATCH] fix test driver leaks: exclude, malloc, reallo

[PATCH] strftime: don't use __THROW

2016-11-14 Thread Jim Meyering
I've just pushed the attached, to avoid new warnings when attempting to build coreutils with the latest from gnulib: From c3b131294aa42b7997cc9b9a0bbb2934aa27fd6c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 13 Nov 2016 18:15:36 -0800 Subject: [PATCH] strftime: don't use __T

Re: manywarnings.m4 optimization request

2016-10-29 Thread Jim Meyering
On Fri, Oct 28, 2016 at 7:05 AM, Tim Ruehsen wrote: > Hi, > > during some GNU internal discussion I was asked to post my proposal / request > here. > > "I use manywarnings.m4 in my projects which take ~9s here (~25% of the whole > ./configure run). > One gcc invocation per (possible) warning optio

Re: Automatically-generated regexp documentation

2016-10-23 Thread Jim Meyering
On Fri, Oct 21, 2016 at 1:17 PM, Eric Blake wrote: > I'm planning to script the > conversion of all the tags, but am trying to figure out if it is worth > back-dating the tags, and whether an unsigned annotated tag or a simpler > lightweight tag is the better thing to push in place of each tag tha

Re: The non-recursive-gnulib-prefix-hack module

2016-10-22 Thread Jim Meyering
On Sat, Oct 22, 2016 at 10:25 AM, Bruno Haible wrote: > This is better now. But still better would be to not hardcode 'lib' at all, > and instead use whatever value was passed to gnulib-tool via --source-base. > Below is a proposed patch. (The variable $gl_source_base is already used in a > simila

[PATCH] printf.m4: fix a bug in detecting printf %j support

2016-10-20 Thread Jim Meyering
ChangeLog index a1a314b..48b1d1d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2016-10-20 Jim Meyering + + printf.m4: fix a bug in detecting printf %j support + * m4/printf.m4 (gl_PRINTF_SIZES_C99): Fail any system for which + uintmax_t is defined in neither stdint.h

Re: getprogname and libtool

2016-10-18 Thread Jim Meyering
On Tue, Oct 18, 2016 at 3:32 PM, Bruno Haible wrote: > Hi Jim, ... > 2016-10-18 Bruno Haible > > getprogname tests: Avoid failure in packages that use libtool. > * tests/test-getprogname.c (main): Strip "lt-" prefix. > Based on a patch by Ji

Re: getprogname and libtool

2016-10-18 Thread Jim Meyering
On Tue, Oct 18, 2016 at 2:29 PM, Bruno Haible wrote: > Daiki Ueno wrote: >> > The consequence is that in packages that use GNU libtool, such programs >> > will >> > print "lt-prog" instead of "prog" in their usage message and other >> > messages. >> > This will disturb >> > * the hacker who us

Re: getprogname and libtool

2016-10-18 Thread Jim Meyering
On Tue, Oct 18, 2016 at 12:07 PM, Daiki Ueno wrote: > Bruno Haible writes: > >> The consequence is that in packages that use GNU libtool, such programs will >> print "lt-prog" instead of "prog" in their usage message and other messages. >> This will disturb >> * the hacker who uses the programs

Re: getprogname: comments and test failure on Cygwin

2016-10-18 Thread Jim Meyering
On Tue, Oct 18, 2016 at 6:07 AM, Daiki Ueno wrote: > Hello, > > Jim Meyering writes: > >> On Sun, Oct 16, 2016 at 5:15 AM, Pádraig Brady wrote: >>> On 16/10/16 12:55, Bruno Haible wrote: >>>> Hi, >>>> >>>> The 'getprogname&

Re: The non-recursive-gnulib-prefix-hack module

2016-10-16 Thread Jim Meyering
On Sun, Oct 16, 2016 at 5:13 AM, Bruno Haible wrote: > Hi Jim, all, > > When I try to use the gnulib-tool --create-testdir option to produce a testdir > for all modules, it encounters errors and produces no toplevel Makefile.in: > > $ ./gnulib-tool --create-testdir --with-tests --dir=/tmp/testdir1

Re: what platforms are you testing on?

2016-10-16 Thread Jim Meyering
On Sun, Oct 16, 2016 at 4:43 AM, Bruno Haible wrote: > Hi all, > > Noticing that the new 'getprogname' module probably exhibits a compilation > error on HP-UX, IRIX, OSF/1 (error "getprogname module not ported to this > OS"), > I would like to update the list of supported platforms at > https://w

Re: getprogname: comments and test failure on Cygwin

2016-10-16 Thread Jim Meyering
On Sun, Oct 16, 2016 at 5:15 AM, Pádraig Brady wrote: > On 16/10/16 12:55, Bruno Haible wrote: >> Hi, >> >> The 'getprogname' module test fails on Cygwin 2.6, because the returned >> value is "test-getprogname", not "test-getprogname.exe". (On mingw, on the >> other hand, it really is "test-getpro

Re: dependencies with incompatible licenses: parse-datetime

2016-10-15 Thread Jim Meyering
On Sat, Oct 15, 2016 at 7:15 AM, Bruno Haible wrote: > When I run > > $ ./gnulib-tool --create-testdir --with-tests --dir=/tmp/testdir1 > > I get these warnings, among others: > > gnulib-tool: warning: module parse-datetime depends on a module with an > incompatible license: error > gnulib-tool:

Re: license change of futimens was incomplete

2016-10-15 Thread Jim Meyering
On Sat, Oct 15, 2016 at 7:14 AM, Bruno Haible wrote: > Can we change the license of the modules 'gettime', 'timespec', 'utimens' > to 'LGPL'? Yes. Thanks for noticing/addressing.

Re: getprogname() for IBM z/OS

2016-10-14 Thread Jim Meyering
On Thu, Oct 13, 2016 at 1:10 PM, Jim Meyering wrote: > On Thu, Oct 13, 2016 at 1:50 AM, Pádraig Brady wrote: >> On 13/10/16 02:43, Daniel Richard G. wrote: >>> On Wed, 2016 Oct 12 11:04+0100, Pádraig Brady wrote: >>>> >>>> You only want to strdup onc

Re: getprogname() for IBM z/OS

2016-10-13 Thread Jim Meyering
On Thu, Oct 13, 2016 at 1:50 AM, Pádraig Brady wrote: > On 13/10/16 02:43, Daniel Richard G. wrote: >> On Wed, 2016 Oct 12 11:04+0100, Pádraig Brady wrote: >>> >>> You only want to strdup once. >>> So you could use a static to track that as is done in the AIX case. >> >> Ah, I see, the program nam

Re: 2 patches: long-options.c vs -Wimplicit-fallthrough and .m4 nits

2016-10-12 Thread Jim Meyering
ng to avoid relearning Perl. :-) Sure. Update past this commit: commit 5769724fa57b3bcdf11aad52a3c25428bd555f46 Author: Jim Meyering Date: Sun Dec 27 21:49:39 2015 -0800 vc-dwim: port to perl5.22.1 * vc-dwim.pl (run_command): Use *SAVE_ERR and *SAVE_OUT consistently, to avoid new

2 patches: long-options.c vs -Wimplicit-fallthrough and .m4 nits

2016-10-11 Thread Jim Meyering
FYI: I've just pushed these: >From 0a4afb9850a6ca342ec111be88ea4d8d795633e8 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 5 Oct 2016 10:43:09 -0700 Subject: [PATCH 1/2] long-options: avoid new GCC 7 warning from -Wimplicit-fallthrough * lib/long-options.c (parse_long_options

Re: FYI: [PATCH] utimecmp: avoid new GCC 7 warning from -Wbool-operation

2016-10-05 Thread Jim Meyering
On Wed, Oct 5, 2016 at 9:17 AM, Jim Meyering wrote: > Without this (just pushed) and some other changes, I could not build > coreutils using GCC 7: Here's one more: with this, coreutils' subset of gnulib compiles warning/error free. From d392d4925dd6649ad11b5885a0602d14069f685c

Re: FYI: [PATCH] utimecmp: avoid new GCC 7 warning from -Wbool-operation

2016-10-05 Thread Jim Meyering
On Wed, Oct 5, 2016 at 9:51 AM, Paul Eggert wrote: > On 10/05/2016 09:17 AM, Jim Meyering wrote: >> >> * lib/utimecmp.c (utimecmp): Do not apply "~" to a boolean. > > Hah! And just Monday I was telling students how C operations like binary +, > unary and binar

FYI: [PATCH] utimecmp: avoid new GCC 7 warning from -Wbool-operation

2016-10-05 Thread Jim Meyering
Without this (just pushed) and some other changes, I could not build coreutils using GCC 7: From ee54eda045a47253f458e73702bf775eb4a21d4c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 5 Oct 2016 09:13:55 -0700 Subject: [PATCH] utimecmp: avoid new GCC 7 warning from -Wbool-operation MIME

FYI: [PATCH] vasnprintf.c: avoid spurious warning from GCC 7

2016-10-02 Thread Jim Meyering
show_bug.cgi?id=77817 From e63f5eb55570a1ea3e51ce47df33689785e085c1 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 2 Oct 2016 12:09:13 -0700 Subject: [PATCH] vasnprintf.c: avoid spurious warning from GCC 7 The presence of cpp directives renders this "FALLTHROUGH" comment ineffect

FYI: dfa: build: avoid warning from GCC 7's new -Wimplicit-fallthrough

2016-09-28 Thread Jim Meyering
dfa.c evokes a new warning from GCC 7. I fixed it with this: From 5f919be9d0db97e8daecaa61e6f4ff3b96b2a0fe Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 28 Sep 2016 21:20:38 -0700 Subject: [PATCH] dfa: build: avoid warning from GCC 7's new -Wimplicit-fallthrough * lib/dfa.c (dfass

Re: [PATCH] getprogname: port to OpenBSD 5.1

2016-09-28 Thread Jim Meyering
On Wed, Sep 28, 2016 at 11:28 AM, Jim Meyering wrote: > FYI: grep (due to its use of the new getprogname module) would fail to > configure on OpenBSD 5.1. I'll soon push this to gnulib and then > update grep's gnulib submodule to latest to pull it in. Glad I tested on Fedora

[PATCH] getprogname: port to OpenBSD 5.1

2016-09-28 Thread Jim Meyering
FYI: grep (due to its use of the new getprogname module) would fail to configure on OpenBSD 5.1. I'll soon push this to gnulib and then update grep's gnulib submodule to latest to pull it in. From d02282b67dcc6d42be8ab89e5ae2122dd01be7b4 Mon Sep 17 00:00:00 2001 From: Jim Meyering Dat

Re: [PATCH 2/2] stdint: support new _WIDTH macros

2016-09-22 Thread Jim Meyering
On Thu, Sep 22, 2016 at 11:48 AM, Paul Eggert wrote: > On 09/22/2016 11:08 AM, Jim Meyering wrote: >> >> it still fails (no limits.h is created) > > > Sorry about that. I managed to reproduce the problem with Fedora 24 GCC > 6.2.1 by overriding its limits.h, and ins

Re: [PATCH 2/2] stdint: support new _WIDTH macros

2016-09-22 Thread Jim Meyering
On Thu, Sep 22, 2016 at 10:55 AM, Paul Eggert wrote: > On 09/22/2016 09:22 AM, Jim Meyering wrote: >> >> the following fails: >> >>./gnulib-tool --create-testdir --dir=/tmp/x --with-tests --test stdint > > > Odd, I'm not seeing those failures on x86-64

Re: [PATCH 2/2] stdint: support new _WIDTH macros

2016-09-22 Thread Jim Meyering
On Thu, Sep 15, 2016 at 3:45 PM, Paul Eggert wrote: > * doc/posix-headers/stdint.texi: Document this. > * lib/stdint.in.h: Add support for INTMAX_WIDTH. etc. > * m4/stdint.m4 (gl_STDINT_H): Require gl_LIMITS_H. Check for > support for INTMAX_WIDTH, etc. as well as for support for just C99. > * mo

Re: bug#24256: new module for grep's DFA matcher

2016-09-11 Thread Jim Meyering
On Sat, Sep 10, 2016 at 5:55 PM, Jim Meyering wrote: > On Sat, Sep 10, 2016 at 2:00 PM, Assaf Gordon wrote: >> Hello Jim and all, >> >>> On Sep 10, 2016, at 14:44, Jim Meyering wrote: >>> >>> Finally, here is a similar change, but now for gnu sed. For

Re: dfa-match-aux build error

2016-09-11 Thread Jim Meyering
On Sun, Sep 11, 2016 at 4:16 PM, Paul Eggert wrote: > Thanks for the heads-up. I installed the attached patches into Gnulib and > the resulting dfa-tests module works for me on Solaris 10 sparc (Oracle > Studio 12.5). I don't have easy access to Solaris 9 (which Oracle no longer > supports) but fr

Re: bug#24256: new module for grep's DFA matcher

2016-09-10 Thread Jim Meyering
On Sat, Sep 10, 2016 at 2:00 PM, Assaf Gordon wrote: > Hello Jim and all, > >> On Sep 10, 2016, at 14:44, Jim Meyering wrote: >> >> Finally, here is a similar change, but now for gnu sed. For it, I also >> had to make some small code changes to adapt to the new

Re: [PATCH v2 0/4] New getprogname module

2016-09-08 Thread Jim Meyering
On Wed, Sep 7, 2016 at 11:05 AM, Jim Meyering wrote: > On Wed, Sep 7, 2016 at 10:22 AM, Gisle Vanem wrote: >> Jim Meyering wrote: >> >>> +# elif HAVE_DECL___ARGV >>> + return last_component (__argv); >> >> This should be: >> return last

Re: [PATCH v2 0/4] New getprogname module

2016-09-07 Thread Jim Meyering
On Wed, Sep 7, 2016 at 10:22 AM, Gisle Vanem wrote: > Jim Meyering wrote: > >> +# elif HAVE_DECL___ARGV >> + return last_component (__argv); > > This should be: > return last_component (*__argv); > > Or with a bit more care: > if (*__argv == N

Re: [PATCH] flexmember: port better to GCC + valgrind

2016-09-07 Thread Jim Meyering
On Wed, Sep 7, 2016 at 2:03 AM, Paul Eggert wrote: > With a char[] flexible array member in a struct with nontrivial > alignment, GCC-generated code can access past the end of the > array, because GCC assumes there are padding bytes to get the > struct aligned. So the common idiom of malloc (offs

Re: [PATCH v2 0/4] New getprogname module

2016-09-07 Thread Jim Meyering
On Tue, Sep 6, 2016 at 4:22 PM, Jim Meyering wrote: > On Tue, Sep 6, 2016 at 12:38 PM, Gisle Vanem wrote: >> Jim Meyering wrote: >> >>> From the output of that mingw configure run, it appears they are not >>> declared -- at least not in any header included by

Re: [PATCH v2 0/4] New getprogname module

2016-09-06 Thread Jim Meyering
On Tue, Sep 6, 2016 at 12:38 PM, Gisle Vanem wrote: > Jim Meyering wrote: > >> From the output of that mingw configure run, it appears they are not >> declared -- at least not in any header included by this particular >> test program: >> >> checking whether

Re: [PATCH v2 0/4] New getprogname module

2016-09-06 Thread Jim Meyering
On Tue, Sep 6, 2016 at 6:49 AM, Pino Toscano wrote: > Hi Jeremy, > > On Tuesday, 6 September 2016 13:13:52 CEST T J wrote: >> Anyway, it appears that this has not been tested on Windows/MinGW as >> it currently does not work. Everything worked fine with the old >> progname module. >> >> A sample b

<    1   2   3   4   5   6   7   8   9   10   >