FYI,
From 2f1a477706b06256ddca33739a771e3d97d011f1 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 21 Jan 2012 18:12:30 +0100
Subject: [PATCH] bootstrap: fail when bootstrap_post_import_hook fails
Otherwise, it's far too easy to miss diagnostics emitted
between gnulib
Joel E. Denny wrote:
On Tue, 17 Jan 2012, Jim Meyering wrote:
Below is a patch that adds a --no-cluster option, which I believe does
what Stefano wants. I want it too. OK to push?
Hi Joel,
Thanks. That looks fine, but please adjust the preceding comment
to keep in sync with the new
Bruno Haible wrote:
Paul Eggert wrote:
The cat INSTALL argument is not that persuasive
The other argument is that when viewing a file with vi and scrolling
through it, the cursor interrupts the reading flow when it is placed
on the last line and that line is not a blank one.
But of course,
Karl Berry wrote:
However, I am optimistic that I will be able to make matching
changes upstream.
Sorry, but for myself, I think it is a terrible waste of time to be
thinking about this for fdl*.texi. The blank lines don't hurt anything
Hi Karl,
I know this hurts your
As mentioned, ...
From 44c4f75581a7774594e5a225ab43c9c211e4abb4 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 19 Jan 2012 06:14:31 +0100
Subject: [PATCH] bootstrap: add bootstrap_post_import_hook
Bison does still need something like the gnulib_mk_hook whose
Barely worth a changelog entry...
From 1685c6effebceb4d718486558ed54e794d1547ac Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 17 Jan 2012 17:30:33 +0100
Subject: [PATCH] maint: spell file systems with two words, not one
* m4/ls-mntd-fs.m4 (MOUNTED_INTERIX_STATVFS
FYI,
From 1685c6effebceb4d718486558ed54e794d1547ac Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 17 Jan 2012 17:30:33 +0100
Subject: [PATCH] maint: spell file systems with two words, not one
* m4/ls-mntd-fs.m4 (MOUNTED_INTERIX_STATVFS): Spell file systems with
two
From: Jim Meyering meyer...@redhat.com
* cfg.mk: Enable sc_prohibit_cloexec_without_use.
* lib/dup-safer-flag.c: Don't include cloexec.h. Not needed.
---
ChangeLog|6 ++
cfg.mk |1 -
lib/dup-safer-flag.c |2 --
3 files changed, 6 insertions(+), 3
From: Jim Meyering meyer...@redhat.com
* build-aux/pmccabe.css: Remove trailing blanks.
* doc/acl-cygwin.txt: Likewise.
* doc/gnu-oids.texi: Likewise
* cfg.mk: Enable sc_trailing_blank.
Exempt build-aux/texinfo.tex and doc/Copyright/assign.future.manual.
---
ChangeLog |7
From: Jim Meyering meyer...@redhat.com
* cfg.mk: Enable sc_prohibit_intprops_without_use
* tests/test-nanosleep.c: Don't include intprops.h. Not needed.
* lib/ftoastr.c: Likewise.
---
ChangeLog |4
cfg.mk |1 -
lib/ftoastr.c |1 -
tests
From: Jim Meyering meyer...@redhat.com
* cfg.mk: Enable sc_prohibit_openat_without_use.
Exempt lib/selinux-at.c.
---
ChangeLog |4
cfg.mk|2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index a85f74e..ec42f95 100644
--- a/ChangeLog
sc_prohibit_hash_pjw_without_use
[5/8] maint: enable sc_prohibit_intprops_without_use
[6/8] maint: enable sc_prohibit_cloexec_without_use
[7/8] maint: enable sc_prohibit_openat_without_use
[8/8] maint: enable sc_trailing_blank
Here are the ChangeLog entries:
2012-01-17 Jim Meyering meyer...@redhat.com
maint
From: Jim Meyering meyer...@redhat.com
* cfg.mk: New file, to disable all currently-failing tests.
We'll enable them one by one, as they are made to pass.
* Makefile (sc_maint): New rule.
---
ChangeLog |5 +
Makefile |7 +++
cfg.mk| 56
From: Jim Meyering meyer...@redhat.com
Apply syntax rules at home as well as abroad. Most changes
were induced by running this:
make srcdir=. _build-aux=build-aux -f top/maint.mk \
sc_prohibit_empty_lines_at_EOF | grep -v modules/ \
| xargs perl -pi -0777 -e 's/\n\n+$/\n/'
* cfg.mk
From: Jim Meyering meyer...@redhat.com
* cfg.mk: Enable sc_prohibit_hash_pjw_without_use.
* top/maint.mk (sc_prohibit_hash_pjw_without_use): Adjust regexp
to match any use of \hash_pjw\, i.e., not necessarily with a
following (.
---
ChangeLog|6 ++
cfg.mk |1 -
top
Bruno Haible wrote:
Hi Jim,
* doc/regexprops-generic.texi: Add a newline at EOF. There was none.
Good point. It was more of a problem with 'cvs' than with 'git'. But I
like this effort anyway.
* doc/Copyright/assign.translation.manual: Remove empty lines at EOF.
*
Joel E. Denny wrote:
On Mon, 26 Dec 2011, Jim Meyering wrote:
I think the result is an improvement, but it is still not as readable as I
would like, or maybe it's just not as readable as I am used to (git log
output). Why? ... Because when some clumped entries are adjacent to a
multi
Eric Blake wrote:
...
diff --git a/build-aux/bootstrap b/build-aux/bootstrap
...
@@ -758,7 +758,7 @@ fi
# Autoreconf runs aclocal before libtoolize, which causes spurious
# warnings if the initial aclocal is confused by the libtoolized
# (or worse out-of-date) macro directory.
-if grep
$no_recursive -I $m4_base
$ACLOCAL_FLAGS \
|| exit 1
Thanks for the fix.
In the interests of documenting-in-code (not just in logs)
and not letting such a kludge hang around forever, I've added comments:
From 3386ea50cda0973a5ff5c258e2ddfcb39b59bc9b Mon Sep 17 00:00:00 2001
From: Jim Meyering
Jim Meyering wrote:
...
Thanks for the fix.
In the interests of documenting-in-code (not just in logs)
and not letting such a kludge hang around forever, I've added comments:
...
-# Tell autoreconf not to invoke autopoint or libtoolize; they were run above.
+# Some systems (RHEL 5) are using
Stefano Lattarini wrote:
Hello Gnulibers.
I've recently noticed that the gnupload script present in the automake
repository is *not* synced from an external source like I thought, and
like is done for other maintainer-oriented scripts and files that are
not automake-specific (such as
Stefano Lattarini wrote:
Hi Jim, thanks for the quick reply.
...
Attached is the proposed patch. I will push as soon as I have an ACK.
...
+2011-01-15 Stefano Lattarini stefano.lattar...@gmail.com
+
+ gnupload: we hold the master copy of this script now
+ For motivation and more
Eric Blake wrote:
On 01/11/2012 04:44 PM, Paul Eggert wrote:
On 01/11/12 15:24, Eric Blake wrote:
+ best.len = 0;
I have some qualms about adding unnecessary initializations
merely to silence GCC. It's not just that it bloats the
runtime -- it's that it makes the code more confusing,
Reuben Thomas wrote:
On 12 January 2012 02:13, Bruno Haible br...@clisp.org wrote:
- In copy-file.h declare the right function name.
Ah yes, I must've missed warnings for this, sorry.
- In the tests I also had to drop the test with /dev/full, since - unlike
/dev/null - this device does
Christian Grothoff wrote:
Just FYI, amatus (the reporter) now writes: Nevermind. I got confused. and
marked the bug as resolved...
Thanks for letting us know.
Reuben Thomas wrote:
Ping! I've not heard anything about this; my current patch (as used in
GNU Zile) still seems to work.
Hi Reuben,
Thanks for the reminder.
A couple of suggestions:
ERR_READ may be too generic, risking collision with symbols defined by
other applications. Perhaps names
The sense of the offending sentence was reversed.
I.e., we print the names of bad files, not those of conforming ones.
From f9813bce2c06a6130a68db4478d1b16ddadaf276 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 10 Jan 2012 17:32:32 +0100
Subject: [PATCH] maint.mk: fix
Reuben Thomas wrote:
On 10 January 2012 16:58, Eric Blake ebl...@redhat.com wrote:
Yes, --dir is optional if you don't specify --create-testdir.
Right, so could you please fix the documentation accordingly?
Hi Reuben,
It is good practice when asking for help (and getting it)
to volunteer
Reuben Thomas wrote:
On 10 January 2012 18:14, Reuben Thomas r...@sc3d.org wrote:
It is good practice when asking for help (and getting it)
to volunteer the patch that would have saved you some trouble.
Since you've just hit a particular problem you are perhaps better
placed than anyone else
Bruno Haible wrote:
Here's a proposed series of tweaks and alignments to the 'acl' and 'copy-file'
modules, to make Reuben's proposed change to 'copy-file' easier.
The first change is not backward compatible, but the only users of copy_acl()
are coreutils and 'copy-file' in gnulib, and I've
search path.
I've pushed this:
From 89c006fbb40a0455ad309155be38277490c0b94f Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 9 Jan 2012 10:12:18 +0100
Subject: [PATCH] test-init.sh: avoid a subshell
* tests/test-init.sh: Remove protective subshell.
Suggested
depending on. To avoid further hassle,
I've simply hard-coded the elided @node line in each of the
two fdl.texi-including files.
From 620d56c8661e3375dc7c86661436ca51515edd88 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 9 Jan 2012 12:07:20 +0100
Subject: [PATCH
Jim Meyering wrote:
Normally, updating from gnulib is mostly a no-op.
This time, however, was different.
bootstrap saw some much needed changes, and adapting
to those required some long-overdue cleanup in bootstrap.conf.
(notably the use of $bt)
This also includes an fdl.texi update, which
that there are no uses of
/ignore_ptr\ *\(/ in code it indexes.
From 530dd1744036b6f2b62aea156b399c7cec024d27 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 10 Jan 2012 08:38:52 +0100
Subject: [PATCH] ignore-value: remove deprecated ignore_ptr function
* lib/ignore
FYI,
From 1fa2b522480d4834a8c2724eec571d5ad56031e4 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 8 Jan 2012 14:35:22 +0100
Subject: [PATCH] select.c: indent with spaces, not TABs
* lib/select.c (windows_poll_handle): Indent with spaces, not TABs.
---
ChangeLog
Werner LEMBERG wrote:
the normal usage of gnulib is to import files into a project, this is,
calling `gnulib-tool --import', then adding the imported files to the
repository.
Hi Werner,
In my experience, that is not normal usage.
I (and AFAIK, everyone who contributes regularly here)
Bruno Haible wrote:
Jim Meyering wrote:
...
Thanks, this fixed the failures of this test on several platforms.
But it introduced a minor problem: spurious output of the test.
On AIX 6.1:
./test-init.sh[42]: There: not found.
PASS: test-init.sh
On Solaris 10/x86:
./test-init.sh: line
Joel Brobecker wrote:
Hi Jim,
Currently parted work and an imminent coreutils release are taking all of
my time. Maybe Joel Denny can help? At worst, I'll follow up next week.
This really has no urgency at all. I've done the update for GDB and
we are good for another year.
Also, I am
new failures, where quote-emitted `...' failed to match my expectation
of '...'-everywhere.
For now, I've adapted coreutils' tests so that that they expect the
new, inconsistent output.
From e8fb9b01699ee235fd4d3c6d0d413d40006a5014 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
At least on darwin, using the very latest from gnulib,
http://hydra.nixos.org/build/1731154
that shows how grep's gnulib-tests exposed one failure:
building test-lock.log
/bin/sh: line 1: 69786 Abort trap EXEEXT='' srcdir='.'
LOCALE_FR='fr_FR.ISO8859-1'
Bruno Haible wrote:
Jim Meyering wrote:
At least on darwin, using the very latest from gnulib,
http://hydra.nixos.org/build/1731154
that shows how grep's gnulib-tests exposed one failure:
building test-lock.log
FAIL: test-lock
And the test's log [1] says:
FAIL: test-lock (exit
Joel Brobecker wrote:
Hello, and Happy New Year :-).
Hi Joel,
Happy new year to you, too.
Currently parted work and an imminent coreutils release are taking all of
my time. Maybe Joel Denny can help? At worst, I'll follow up next week.
I am trying to use gnulib's update-copyright script to
Bruno Haible wrote:
Jim Meyering wrote in
https://lists.gnu.org/archive/html/coreutils/2012-01/msg00059.html:
FAIL: rm/unread3
rm: unable to record current working directory: Too many open files
rm: unable to record current working directory: Too many open files
I
output.
compare may generate diff -c output or even cmp output.
This should fix it:
From 68571c92aeffdded292b047f1ea3c25bd5f73b49 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 5 Jan 2012 16:43:04 +0100
Subject: [PATCH] test-init.sh: avoid failure on HP-UX 11.00
* tests
Stefano Lattarini wrote:
Hi Jim.
On 01/05/2012 04:46 PM, Jim Meyering wrote:
Looking at Bruno's recent test-init.sh failure,
I noticed the unnecessary sub-shells here:
From a815c2160e6d6cc27d934e669ef9486bab310db3 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu
FYI,
From 2438ef921151227c7acbecc7975cd612b548a94d Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 4 Jan 2012 17:54:57 +0100
Subject: [PATCH] test-vc-list-files-cvs.sh: remove obsolete comment
* tests/test-vc-list-files-cvs.sh: Remove obsolete comment about
double exit
Stefano Lattarini wrote:
On 01/03/2012 06:10 PM, Jim Meyering wrote:
FYI, here's a snapshot of what will soon be coreutils-8.15,
expected on Thursday or Friday.
coreutils snapshot:
http://meyering.net/cu/coreutils-ss.tar.xz 5.2 MB
http://meyering.net/cu/coreutils
Looking through the matches for FIXME.*2012, this takes care of
one of them:
From 943bf5a92b5a7a3e4b3a7178654c5491244ee8aa Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 3 Jan 2012 11:35:43 +0100
Subject: [PATCH] maint.mk: remove temporary transition aid from over 1.5
|6 ++
build-aux/gitlog-to-changelog |4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index b65842a..efa62c0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-01-02 Jim Meyering meyer...@redhat.com
+
+ gitlog-to-changelog: fix
FYI,
From 744b6c6ea8c72b372750ed31f3afed8420b236eb Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 2 Jan 2012 15:53:06 +0100
Subject: [PATCH] gitlog-to-changelog: describe input syntax in --help output
* build-aux/gitlog-to-changelog (usage) [SPECIAL SYNTAX]: New
in a test suite?
I agree that it's not worth the bother, so did this:
From bf1eb2d3b4bd6704ad0dc5c0a666803db876f2b4 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 3 Jan 2012 08:21:09 +0100
Subject: [PATCH] init.sh: do not try to accommodate compare arguments
starting
FYI,
From fc9846f7408ed30a3421eff5450ff5287cd66ddd Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 1 Jan 2012 10:00:41 +0100
Subject: [PATCH] version-etc: update copyright year reported by --version
* lib/version-etc.c (COPYRIGHT_YEAR): Update to 2012.
Copyright (C
I've done this:
maint: update all copyright year number ranges
Run make update-copyright.
[master 1602f0a] maint: update all copyright year number ranges
3355 files changed, 3355 insertions(+), 3355 deletions(-)
Paul Eggert wrote:
On OpenVMS st_ino is an array of three ino_t values, so grep's
a.st_ino == b.st_ino compares *pointers*, and yields 0. Ouch.
For other GNU programs we often don't worry about OpenVMS,
but grep is a special case, as it's actually used on OpenVMS
.
+
2011-12-25 Jim Meyering meyer...@redhat.com
gitlog-to-changelog: do not clump multi-paragraph entries
diff --git a/lib/canonicalize.c b/lib/canonicalize.c
index 4fe9f30..c73a963 100644
--- a/lib/canonicalize.c
+++ b/lib/canonicalize.c
@@ -31,6 +31,8 @@
#include xalloc.h
Pádraig Brady wrote:
On 12/30/2011 02:43 PM, Pádraig Brady wrote:
On 12/30/2011 01:49 PM, Eric Blake wrote:
On 12/30/2011 04:04 AM, Jim Meyering wrote:
- if (lstat (rname, st) != 0)
+ if ((logical?stat:lstat) (rname, st) != 0)
Please add spaces around operators
Jim Meyering wrote:
Pádraig Brady wrote:
On 12/30/2011 01:49 PM, Eric Blake wrote:
On 12/30/2011 04:04 AM, Jim Meyering wrote:
- if (lstat (rname, st) != 0)
+ if ((logical?stat:lstat) (rname, st) != 0)
Please add spaces around operators:
if ((logical ? stat
I've decided to go ahead and make this change, in spite of the lack of
policy anywhere else. I'll update --help with a note about this separately.
Gary, it's based on the change from you and is still in your name, so
I'll wait for an ACK before I push.
Jim
From
FYI, a minor bug fix:
From e15863f1ee27315eaa63e83ad2c17d832d64b951 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 30 Dec 2011 19:00:49 +0100
Subject: [PATCH] gitlog-to-changelog: don't malfunction when name contains
%-directive
* build-aux/gitlog-to-changelog (main
Paul Eggert wrote:
I found this one while looking for `quoting' issues:
* build-aux/announce-gen (print_changelog_deltas): Fix typo in
diagnostic: a missing '$' meant that the command was not output.
...
# The exit code should be 1.
# Allow in case there are no modified ChangeLog
Stefano Lattarini wrote:
On 12/23/2011 05:19 PM, Jim Meyering wrote:
However, I would prefer an adaptive/hybrid solution: if a commit log
is composed of two or more paragraphs, keep it in a separate block.
Otherwise, merge entries that would otherwise have a date--name--email
header
In case anyone feels like looking in the next couple of hours,
here is the new series of three change-sets:
From 94eb544e23cd3e9d6cc5f0bd834525b41c43ec2d Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 23 Dec 2011 10:53:10 +0100
Subject: [PATCH 1/3] test-framework-sh
Bruno Haible wrote:
Jim Meyering wrote:
+License:
+GPLed build tool
Hmm, for me, init.sh is not a build tool but rather a simple piece of tests
code. I would mark it as 'GPL'. This would be consistent with what the
Makes sense. I've adjusted.
documentation [1] states about the license
2011-12-22 Jim Meyering meyer...@redhat.com
correct previous ChangeLog entry: s/set -x/set -e/
Spotted by Stefano Lattarini.
init.sh: avoid unwarranted test failure when using set -x
* tests/init.sh (compare): Ignore nonzero exit from compare_dev_null_
Stefano Lattarini wrote:
On 12/23/2011 03:38 PM, Jim Meyering wrote:
Stefano Lattarini wrote:
Hello Gnulibers.
Currently, the `gitlog-to-changelog' script clusters ChangeLog entries with
the same date together, placing them under a single date line in the
generated output.
So we have
From: Jim Meyering meyer...@redhat.com
Date: Fri, 23 Dec 2011 16:44:55 +0100
Subject: [PATCH] test-framework-sh: distribute init.sh
* modules/test-framework-sh (EXTRA_DIST): Append init.sh.
Otherwise, make -C gnulib-tests check (at least in grep) would
fail due to the lack of init.sh.
---
ChangeLog
Stefano Lattarini wrote:
On 12/23/2011 04:11 PM, Jim Meyering wrote:
Stefano Lattarini wrote:
I hope the above argument will make you reconsider this position;
...
Position? I had not taken a position. Any feature request should be
accompanied by justification. The questions above
FYI, after updating to the latest tests/init.sh, I noticed new
failures in vc-dwim's make check. Tracked it down to this:
From ed2ad641686263add14f2081d659da0cc3a76536 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 22 Dec 2011 12:42:32 +0100
Subject: [PATCH] init.sh
Stefano Lattarini wrote:
Hi Jim.
On 12/22/2011 12:44 PM, Jim Meyering wrote:
FYI, after updating to the latest tests/init.sh, I noticed new
failures in vc-dwim's make check. Tracked it down to this:
From ed2ad641686263add14f2081d659da0cc3a76536 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Pádraig Brady wrote:
On 12/22/2011 11:44 AM, Jim Meyering wrote:
FYI, after updating to the latest tests/init.sh, I noticed new
failures in vc-dwim's make check. Tracked it down to this:
diff --git a/tests/init.sh b/tests/init.sh
index 19c0cf4..458a448 100644
--- a/tests/init.sh
+++ b
7d3d2d00059b7b616596f015b37e334c27212722 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 22 Dec 2011 19:03:43 +0100
Subject: [PATCH] init.sh: new module, and add minimal tests of its compare
function
* modules/init.sh-tests: New file.
* tests/test-init.sh: New file.
* modules/init.sh: New file
Andersson g...@gisladisker.se.
+
2011-12-17 Jim Meyering meyer...@redhat.com
bootstrap: remove some now-unneeded code
diff --git a/build-aux/bootstrap b/build-aux/bootstrap
index a95c654..505a05e 100755
--- a/build-aux/bootstrap
+++ b/build-aux/bootstrap
@@ -1,6 +1,6 @@
#! /bin/sh
# Print
Joachim Schmitz wrote:
...
Hmm DIR_TO_FD() is :
#define DIR_TO_FD(Dir_p) -1
In config.h:
/* the name of the file descriptor member of DIR */
/* #undef DIR_FD_MEMBER_NAME */
#ifdef DIR_FD_MEMBER_NAME
# define DIR_TO_FD(Dir_p) ((Dir_p)-DIR_FD_MEMBER_NAME)
#else
# define DIR_TO_FD(Dir_p)
Jim Meyering wrote:
Here is a proposed patch to bring gnulib's bootstrap back
into sync with the one from coreutils.
Back in September I made the following two changes to coreutils' bootstrap:
maint: bootstrap: run autopoint and libtoolize *before* gnulib-tool
http://git.sv.gnu.org
Reuben Thomas wrote:
Patch follows. I've taken advantage of this being a tiny fix to try to
use vc-dwim to DTRT, so please do pick me up on anything I've failed
to get perfect.
Thanks, Reuben, but this is what I see:
From 4697cf715d0e5cda49eb80935218490b2324dbb3 Mon Sep 17 00:00:00
2001From:
Reuben Thomas wrote:
I attach the patch this time. I think putting them inline used to work
with plain text formatting, and I got complaints when I attached them
(because they got the wrong MIME type), but I see that now I get
text/x-patch as the MIME type; hooray!
Applied.
Please see about
Reuben Thomas wrote:
On 18 December 2011 15:30, Jim Meyering j...@meyering.net wrote:
Applied.
Please see about fixing your client, because most people
here prefer in-line (not attached) patches.
I'll see if I can use Emacs for composing messages with patches in
future; I manage to use
Reuben Thomas wrote:
On 18 December 2011 15:40, Jim Meyering j...@meyering.net wrote:
If you had written this in ChangeLog, vc-dwim would have
produced the log entry that I created manually:
README-release: fix punctuation
* top/README-release: s/:/./
So my error was not writing
Reuben Thomas wrote:
On 18 December 2011 15:42, Jim Meyering j...@meyering.net wrote:
Right.
Sorry to be brainless; I think it has taken me at least a year to get
Not brainless ;-)
Just a habit you have not yet acquired.
the reflex to at least try vc-dwim before sending a patch. I wonder
Reuben Thomas wrote:
On 18 December 2011 16:44, Jim Meyering j...@meyering.net wrote:
Done:
vc-dwim: warn when there is no one-line summary
http://git.sv.gnu.org/cgit/vc-dwim.git/commit/?id=231b79e0e57a08655
Thanks, that's great. Do you really still class vc-dwim as of beta
quality
Reuben Thomas wrote:
On 18 December 2011 17:38, Jim Meyering j...@meyering.net wrote:
Reuben Thomas wrote:
Thanks, that's great. Do you really still class vc-dwim as of beta
quality (secundum Savannah status, it is)?
No. What makes you say that?
https://savannah.gnu.org/projects/vc-dwim
FYI, we've been using this in coreutils for some time, so...
From feaf4df70588cf1ee30b4879a1048cc143135a67 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker m...@bernhard-voelker.de
Date: Mon, 5 Sep 2011 13:28:20 +0200
Subject: [PATCH] build: let bootstrap resort to wget for downloading .po
files
In comparing gnulib's bootstrap and the one in coreutils,
I saw something strange... code that cannot work ;-)
This fix makes it work as intended:
From ae92f6e5746d1eacc77af8f3ee568cc8205f5dea Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 17 Dec 2011 16:28:55 +0100
pushing this.
From 9242694f4b54542988bef93102394714091b29a5 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 17 Dec 2011 17:00:44 +0100
Subject: [PATCH] bootstrap: remove some now-unneeded code
This script arose back when gnulib-tool was young.
Since then, it has seen
Joachim Schmitz wrote:
From: Paul Eggert [mailto:egg...@cs.ucla.edu]
Sent: Thursday, December 15, 2011 7:07 PM
To: Joachim Schmitz
Cc: Jim Meyering; bug-coreut...@gnu.org; bug-gnulib@gnu.org
Subject: Re: coreutils-8.14, rm -r fails with EBADF
On 12/15/11 08:28, Jim Meyering wrote:
If you
Joachim Schmitz wrote:
From: Jim Meyering [mailto:j...@meyering.net]
Sent: Friday, December 16, 2011 11:51 AM
To: Joachim Schmitz
Cc: 'Paul Eggert'; bug-gnulib@gnu.org; bug-coreut...@gnu.org
Subject: Re: coreutils-8.14, rm -r fails with EBADF
Joachim Schmitz wrote:
From: Paul Eggert
Joachim Schmitz wrote:
I got coreutils-8.9, 8.13 and 8.14 to compile for my platform, and most of the
Thanks for the report.
More details will help us help you:
Which platform is that?
Including your config.h might help.
utilities work, but as soon as it comes to recurring thru the file
Joachim Schmitz wrote:
...
but what I really need to know is what happened just prior, in fts_read.
Can you run gdb, set a breakpoint in fts_read and show us the result of
stepping
through fts_read? That would be most useful.
Sorry, no gdb, the debugger here is calls eInspect (but is
FYI,
From f5c2e2ac7d4ca2f6ba15e56a245f348899360a00 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 12 Dec 2011 10:57:17 +0100
Subject: [PATCH] argmatch: don't hard-code `' when listing valid option
arguments
* lib/argmatch.c (argmatch_valid): Don't hard-code `%s
I use a umask of 077.
That is rather irregular (022 is more common), but for a good reason.
It might have saved me from exploit via at least one flaw (the automake
dist abuse CVE).
Anyhow, many tools fail to account for the possibility of a restrictive
umask, and gnupload is one of them.
If I'm
Simon Josefsson wrote:
Jim Meyering j...@meyering.net writes:
Eric Blake wrote:
On 12/03/2011 09:00 AM, Simon Josefsson wrote:
What does -funit-at-a-time really do? My gcc 4.4 manual says:
`-funit-at-a-time'
This option is left for compatibility reasons. `-funit-at-a-time'
has
Simon Josefsson wrote:
Jim Meyering j...@meyering.net writes:
I can live with the status quo, but it would make -Wvla more useful
not to put such constructs in commonly-included header files.
FWIW, I find these definitions from gettext.h are rarely needed, so
unless you really need them
Bruno Haible wrote:
On Minix 3.1.8, I get this spurious output from the test-verify.sh test:
mktemp: not found
PASS: test-verify.sh
This patch fixes it. OK to apply?
2011-12-04 Bruno Haible br...@clisp.org
tests: Avoid spurious error message on platforms without mktemp
/^(License)$/$1:/' $(git grep -l '^License$' gl)
From 79c5fcc681b823a4e5fbb8fd1baa47db4eccd86c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 3 Dec 2011 14:04:17 +0100
Subject: [PATCH] maint: add missing : after License in local gnulib
module files
This avoids spurious
Bruno Haible wrote:
Hi Jim,
Bruno, what do you think about making gnulib-tool warn about
that syntax error?
You can not anticipate all kinds of typos that can occur. Similar things
would have happened if someone wrote
Licence:
instead of
License:
IMO warnings that rely on
Hi Bruno,
This is in the context of manywarnings, so I'll write to bug-gnulib,
of course, you're welcome to add bug-gettext, if desired.
I tried enabling -Wvla for coreutils and found that it provoked hundreds
of warnings, all due to this:
../lib/gettext.h:262:3: error: variable length
Bruno Haible wrote:
Jim Meyering wrote:
How about diagnosing a missing License: when
the module is not a -test one?
Neat idea. This one can be implemented without a heuristic. Done as follows:
Thanks!
2011-12-03 Bruno Haible br...@clisp.org
gnulib-tool: Verify that the License
Bruno Haible wrote:
Hi Jim,
I tried enabling -Wvla for coreutils and found that it provoked hundreds
of warnings, all due to this:
../lib/gettext.h:262:3: error: variable length array 'msg_ctxt_id'\
is used [-Werror=vla]
That comes from this inline function from gettext.h:
Eric Blake wrote:
On 12/03/2011 09:00 AM, Simon Josefsson wrote:
What does -funit-at-a-time really do? My gcc 4.4 manual says:
`-funit-at-a-time'
This option is left for compatibility reasons. `-funit-at-a-time'
has no effect, while `-fno-unit-at-a-time' implies
Eric Blake wrote:
When running a testsuite on FreeBSD, I saw a lot of:
1+ records in
0+1 records out
10 bytes transferred in 0.63 secs (158875 bytes/sec)
literring the testsuite, and traced it to the fact that we
were silencing one, but not the other, dd usage in our fallback.
*
701 - 800 of 3394 matches
Mail list logo
