Gary V. Vaughan wrote:
I made these changes in gnulib-local/top/README-release while making
a start at leveraging the gnulib release machinery into GNU Libtool,
but they seem generally applicable too.
Thanks for the suggestions.
However, it's not quite ready.
Okay to push?
I'm glad you
Gary V. Vaughan wrote:
...
-* Run ./configure make maintainer-clean
Why do you want to remove the make maintainer-clean?
I saw no justification, so maybe it's an accident.
Hmm... half and half. Here's the relevant bit of ChangeLog:
+ Don't try to run ./configure right after git pull
Gary V. Vaughan wrote:
On 19 Oct 2011, at 20:13, Jim Meyering wrote:
Gary V. Vaughan wrote:
Jim, please consider pulling it into coreutils master as a better fix than
twidding Makefiles after the fact in bootstrap.conf.
This -Iintl option will disappear with gettext version 0.19 - because
Gary V. Vaughan wrote:
...
On the other hand, if by incremental you really mean chunking my rewrite
into
patches that add a function here and there, and disable bits of the old script
when they are no longer called, then I could be persuaded to do that. How
big should the chunks be to make
Gary V. Vaughan wrote:
Jim, please consider pulling it into coreutils master as a better fix than
twidding Makefiles after the fact in bootstrap.conf.
This -Iintl option will disappear with gettext version 0.19 - because
then gettextize --intl will not work any more; it's already deprecated.
I ran gnulib's top-level make check, and cppi spotted this:
From ca3be51f7beb529726b066d1da34acd338828b24 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 19 Oct 2011 15:28:46 +0200
Subject: [PATCH] posix_openpt: remove spurious #endif
* lib/posix_openpt.c (posix_openpt
Gary V. Vaughan wrote:
Hi Pádraig, Jim,
Is there anything else I can do to help you incorporate this, and the
matching bootstrap.conf I wrote for you into coreutils now that the
release is out?
Hi Gary,
Thanks for persevering. I have just tried it.
It looks like your coreutils working
:
From 775119f83d459107178933d4baa8886e91b19a9c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 10 Oct 2011 08:49:37 +0200
Subject: [PATCH] test-renameat: don't leave behind a temporary file
* tests/test-renameat.c (main): Don't forget to remove a temporary file.
ERROR
Jim Meyering wrote:
Bruno Haible wrote:
On MacOS X 10.5, the following gnulib tests fail to link:
...
This is apparently due to the recent implementation change of getcwd().
This patch should fix it:
2011-10-08 Bruno Haible br...@clisp.org
Tests: Avoid link failures w.r.t. libintl
Bruno Haible wrote:
On MacOS X 10.5, the following gnulib tests fail to link:
...
This is apparently due to the recent implementation change of getcwd().
This patch should fix it:
2011-10-08 Bruno Haible br...@clisp.org
Tests: Avoid link failures w.r.t. libintl.
*
);
}
else /* FreeBSD, MacOS X, IRIX, Tru64 */
{
--
1.7.7.rc0.362.g5a14
From d813b688732c3a0da947f91cbb19cb78a627209e Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 5 Oct 2011 15:06:49 +0200
Subject: [PATCH 2/2] file-has-acl: revert both recent
Bruno Haible wrote:
Jim Meyering wrote:
I propose to push Kamil's fix (mainly to have a record of it,
in case we need it later), but then to immediately revert it
along with the file-has-acl.c change that started this.
That seems to be the right thing to do, going forward,
since the kernel
Gary V. Vaughan wrote:
Sorry I didn't notice your reply sooner.
On 22 Sep 2011, at 23:38, Jim Meyering wrote:
Gary V. Vaughan wrote:
* g...@github.com:gvvaughan/GNU-coreutils.git in gary/bootstrap
https://github.com/gvvaughan/GNU-coreutils/commits/gary/bootstrap
I'll try to find time
Gary V. Vaughan wrote:
Hi Jim,
On 4 Oct 2011, at 17:09, Jim Meyering wrote:
Gary V. Vaughan wrote:
Sorry I didn't notice your reply sooner.
On 22 Sep 2011, at 23:38, Jim Meyering wrote:
Gary V. Vaughan wrote:
* g...@github.com:gvvaughan/GNU-coreutils.git in gary/bootstrap
https
Kamil Dudka wrote:
The commit 95f7c57 introduced an unintended change in behavior of ls -L.
I am attaching a patch that restores the old behavior. Thanks in advance
for considering the patch!
Kamil
From 75836c03cb21d616591b11164b626556d9f26152 Mon Sep 17 00:00:00 2001
From: Kamil Dudka
Kamil Dudka wrote:
On Mon October 3 2011 12:45:01 Jim Meyering wrote:
Can you describe how to make ls -L misbehave without this patch?
if you have a symlink to a file with ACL, 'ls -Ll' does not print the '+'
at end of the column with permission bits.
Thanks. I expect to add something like
Kamil Dudka wrote:
On Mon October 3 2011 13:09:21 Jim Meyering wrote:
Kamil Dudka wrote:
On Mon October 3 2011 12:45:01 Jim Meyering wrote:
Can you describe how to make ls -L misbehave without this patch?
if you have a symlink to a file with ACL, 'ls -Ll' does not print the '+'
at end
was introduced with 2011-07-22 commit 95f7c57f,
+ file-has-acl: use acl_extended_file_nofollow if available.
+ See http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/28538
+
2011-10-01 Jim Meyering meyer...@redhat.com
maint.mk: adjust a release-related rule not to require use
Kamil Dudka wrote:
On Mon October 3 2011 15:02:20 Bruno Haible wrote:
The function name should explain the semantics of the function. The fact
that it's a wrapper around acl_extended_file is something one can see by
reading the code.
Maybe call it acl_extended_file_optimized?
Sounds good.
Bruno Haible wrote:
Jim Meyering wrote:
I've taken the liberty of adding the above file.
Oops, I forgot a git add command. Thanks for the fix.
If you always write ChangeLog entries before committing, using
vc-dwim --commit to perform the commit would prevent precisely this
problem (among
In preparing to stop building gzip-compressed tarballs in a few
projects I maintain, this change comes in handy:
From 244794a7887f13d9cdb91fed96932cc479905b96 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 1 Oct 2011 17:33:42 +0200
Subject: [PATCH] maint.mk: adjust
Bruno Haible wrote:
FAIL: test-fgetc.exe
FAIL: test-fputc.exe
FAIL: test-fread.exe
FAIL: test-fwrite.exe
All these fail on a stream whose file descriptor has been closed. Most
libraries won't do such a thing. Therefore I don't find it worth to fix
this. Just document it.
But two of the
on non-MSVC platforms.
* tests/test-fputc.c (main): Likewise.
* tests/test-fread.c (main): Likewise.
* tests/test-fwrite.c (main): Likewise.
Reported by Jim Meyering.
Hi Bruno,
Thank you for the quick fix.
With that, coreutils-updated-to-use-latest-from-gnulib
now
Bruno Haible wrote:
Jim Meyering wrote:
-#if MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING
+#if HAVE_MSVC_INVALID_PARAMETER_HANDLER \
+ MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING
gl_msvc_inval_ensure_handler ();
#endif
That is a detail specific to MSVC. Why
Reuben Thomas wrote:
I've just been playing with gengetopt. There's a lot to like: it gives
me (potentially multi-language) options handling for one line per
option (plus any extra text I want) in a simple .ggo file, and half a
dozen lines of code (four of which really should be redundant as
Bruno Haible wrote:
Hi Jim,
About this change of fts.c from 2011-08-18.
The declaration of max_entries in line 1339 comes after a statement. Not
valid C99.
s/C99/C89/
gnulib's conventions are still to not require a C99 compiler.
Hi Bruno,
I see so much more value in using C99's
Bruno Haible wrote:
Hi Jim,
About this change of fts.c from 2011-08-18.
The declaration of max_entries in line 1339 comes after a statement. Not
valid C99.
s/C99/C89/
Oops, yes. Not valid C89.
C89 is now more than 12 years old
You meant s/C89/C99/ ?
No, I meant s/12/22/, to
-futimens.h:29:7: error: shadowed declaration is here [-Werror=shadow]
cc1: all warnings being treated as errors
I fixed it like this:
From 90520caf3cfe735b83237a11034b7aa0c3bb05b9 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 24 Sep 2011 21:02:15 +0200
Subject: [PATCH
Bruno Haible wrote:
Hi Jim,
Here's another prososed patch
On MSVC, I got a link error because save-cwd.c was compiled to invoke the
chdir_long() function, but lib/chdir-long.c was not compiled.
The reason is that while save-cwd.c uses pathmax.h to define PATH_MAX when
it makes sense and
Bruno Haible wrote:
Hi Jim,
Here's a proposal to modernize the 'ftruncate' module. It's triggered by link
errors that I got on MSVC 9, because the 'ftruncate' module, while present in
gnulib, is marked as 'obsolete' and therefore not included by default.
This classification was based on the
Gary V. Vaughan wrote:
* g...@github.com:gvvaughan/GNU-coreutils.git in gary/bootstrap
https://github.com/gvvaughan/GNU-coreutils/commits/gary/bootstrap
I'll try to find time for this next week.
I glanced through the first few lines of your script and found
FGREP=fgrep
EGREP=egrep
...
Bruno Haible wrote:
I've just stumbled again across these failures on FreeBSD 6.4.
FreeBSD 6.4:
test-rename.h:342: assertion failed
Abort trap (core dumped)
FAIL: test-rename
test-rename.h:342: assertion failed
Abort trap (core dumped)
FAIL: test-renameat
Jim, you've usually OKed
Paul Eggert wrote:
On 09/18/11 12:11, Jim Meyering wrote:
Since kFreeBSD also lacks /proc/self/fd support, this has the
drawback of making getcwd non-thread-safe, and making it possible
that getcwd will exit under some unusual conditions. But neither
of those matter to coreutils,
I
Jim Meyering wrote:
Martin von Gagern wrote:
...
5. sc_prohibit_always-defined_macros reports missing files:
The sc_prohibit_always-defined_macros check will cause error messages
about missing files to be emitted if elements from the gl_other_headers_
list are not present (i.e. not imported
FYI, this syncs this change from coreutils' init.sh:
From c37da522c67143c74f2a6ddc25dda4b87a0a5032 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 19 Sep 2011 19:27:53 +0200
Subject: [PATCH] tests: use printf, not echo in init.sh's warn_ function
* tests/init.sh (warn_
Montosh Bisht wrote:
Few errors were reported in the test. Hope this helps.
uname -a
Linux devhost 2.6.40.4-5.fc15.x86_64 #1 SMP Tue Aug 30 14:38:32 UTC
2011 x86_64 x86_64 x86_64 GNU/Linux
Fedora 15
gcc --version
gcc (GCC) 4.6.1 20110908 (Red Hat 4.6.1-9)
export CFLAGS='-pipe -Ofast
Eric Blake wrote:
+ date: accept 'hence' as opposite of 'ago'
+ * lib/parse-datetime.y (relative_time_table): Add 'hence'.
+ * tests/test-parse-datetime.c (main): Enhance test.
+ Suggested by Jesse Wilson.
...
diff --git a/lib/parse-datetime.y b/lib/parse-datetime.y
index
Jim Meyering wrote:
Michael Stone wrote:
On Fri, Sep 16, 2011 at 06:54:32PM +0200, Jim Meyering wrote:
Michael Stone wrote:
This one was actually in gnulib; what's the best way to pursue it?
FAIL: test-getcwd (exit: 16)
Hi Michael,
Thanks for the report.
I'll
Michael Stone wrote:
This one was actually in gnulib; what's the best way to pursue it?
FAIL: test-getcwd (exit: 16)
Hi Michael,
Thanks for the report.
I'll Cc bug-gnulib, but to start with, note that test-getcwd.c's main
does this:
return test_abort_bug () +
Michael Stone wrote:
On Fri, Sep 16, 2011 at 06:54:32PM +0200, Jim Meyering wrote:
Michael Stone wrote:
This one was actually in gnulib; what's the best way to pursue it?
FAIL: test-getcwd (exit: 16)
Hi Michael,
Thanks for the report.
I'll Cc bug-gnulib
Martin von Gagern wrote:
...
It might not be worth the effort/disruption.
One advantage of using Makefile rules is that it's easy to override
the defaults, as you see in the examples above.
Not so hard with shell scripts either. Use source cfg.sh instead of
-include ./cfg.mk and everything
Stefano Lattarini wrote:
...
Converting to a stand-alone script is a fine and seductive idea.
About an yaer ago I had proposed a similar move for automake's own
maintainer checks; see this RFC patch:
http://lists.gnu.org/archive/html/automake-patches/2010-07/msg00081.html
At first glance, I
not be worth the effort/disruption.
One advantage of using Makefile rules is that it's easy to override
the defaults, as you see in the examples above.
From e2c54cb6998369800c2a18df71bb4d0253e472ec Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 14 Sep 2011 14:39:35
in
+ $(gl_other_headers_) that do not exist, say because a project
+ does not use a corresponding module.
+
2011-09-14 Jim Meyering meyer...@redhat.com
maint.mk: sc_tight_scope: propagate failure from sub-make
diff --git a/top/maint.mk b/top/maint.mk
index bbb67ec..0137df1
Bruno Haible wrote:
On 2011-09-04 I committed this:
2011-09-04 Bruno Haible br...@clisp.org
acl: Improve support of NFSv4 ACLs on Solaris 10 (newer version).
* lib/acl-internal.h (ACE_*, NEW_ACE_*): Define also on newer Solaris
10.
(OLD_ALLOW, OLD_DENY): New macros.
Simon Josefsson wrote:
Jim Meyering j...@meyering.net writes:
lib/gc.h is copyright Simon Josefsson under the GPLv2 or later.
I suspect that Simon will be happy to adjust that.
I've done that now.
Thanks, Simon!
Jim Meyering wrote:
Paul Eggert wrote:
On 09/05/11 16:41, Karl Berry wrote:
There are a few files in gnulib that are not copyright of the FSF,
There are?
Yes, there are. I expect there are several trivial files without
any copyright notices (and which are public domain) but I just
Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 8 Sep 2011 17:26:05 +0200
Subject: [PATCH] maint.mk: mark the post-release commit log with maint:
prefix
* top/maint.mk (emit-commit-log): Add maint: prefix to the
one-line commit-log summary.
---
ChangeLog|6
Bruno Haible wrote:
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project gnulib - GNU portability library.
Bruno Haible wrote:
Hi Jim, Paul,
I hope to be able to make the coreutils-8.13 release on Wednesday.
There is a regression: A new compilation error on OSF/1 5.1.
CC openat.o
cc: Error: openat.h, line 59: In this statement, AT_SYMLINK_NOFOLLOW is not
declared. (undeclared)
Paul Eggert wrote:
On 09/05/11 16:41, Karl Berry wrote:
There are a few files in gnulib that are not copyright of the FSF,
There are?
Yes, there are. I expect there are several trivial files without
any copyright notices (and which are public domain) but I just now
audited gnulib for
Bruno Haible wrote:
The change to lib/set-mode-acl.c fixed the first test failure. For the
second test failure, I'm applying this fix:
And finally, clean up the pieces of unused Solaris code:
2011-09-05 Bruno Haible br...@clisp.org
acl: Clean up Solaris code.
*
Jim Meyering wrote:
Bruno Haible wrote:
The change to lib/set-mode-acl.c fixed the first test failure. For the
second test failure, I'm applying this fix:
And finally, clean up the pieces of unused Solaris code:
2011-09-05 Bruno Haible br...@clisp.org
acl: Clean up Solaris code
J.T. Conklin sent the following to me privately and I made some
tiny adjustment. Any comments before I push it?
We both admit that it's not complete, but trying to describe
in text what the grammar does is a losing game.
Suggestions for improvements are most welcome.
From
Bruno Haible wrote:
Jim Meyering wrote:
There was actually one failure on Solaris 10:
FAIL: test-copy-acl-1.sh (exit: 1)
==
+ test 1 = 0
+ func_tmpdir
+ : /var/tmp
tmp=/var/tmp/glj4aWlm
+ test -n /var/tmp/glj4aWlm
+ test -d /var/tmp
Thien-Thi Nguyen wrote:
() Jim Meyering j...@meyering.net
() Tue, 06 Sep 2011 12:40:47 +0200
Suggestions for improvements are most welcome.
[...]
+@example
+1972-09-24T20:02:00,00-0500 # @sc{iso} 8601 extended date and
time of day format
+@end example
This is kind
Paul Eggert wrote:
Further testing with tar has revealed a bug with AIX 7.1's
implementation of fstatat (this time for real, I think :-).
I'm installing this patch into gnulib so that it can propagate
into tar.
openat: test for fstatat (AT_FDCWD, ..., 0) bug
This tests for another fstatat
Richard W.M. Jones wrote:
On Sat, Sep 03, 2011 at 04:45:28PM +0200, Gillen Daniel wrote:
I'm just posting this here in case someone is interested in building
hivex on Windows (mingw32). The attached patch allows building the
lib but not the tools (hivexsh etc..) as there are some more
FYI, I've just pushed this in Bruno's name:
From 0cfe1ace2814772d708260aaa8938196222afd5d Mon Sep 17 00:00:00 2001
From: Bruno Haible br...@clisp.org
Date: Fri, 2 Sep 2011 14:13:59 +0200
Subject: [PATCH] tests: init.sh: work also with any non-GNU diff that
supports -u
* tests/init.sh: Relax
Bruno Haible wrote:
Jim Meyering wrote:
FYI, I've just pushed this in Bruno's name:
I see it pushed in coreutils, not in gnulib.
Rather than checking for GNU diff via --version, simply check
for support for -u itself. Useful at least on OpenBSD 4.9.
Also useful on AIX 7.1, IRIX 6.5
I've just pushed this.
Documentation coming in the next few days, one way or another.
From c2ecbc9a8262595b27f741e41375d06213a30fb6 Mon Sep 17 00:00:00 2001
From: J.T. Conklin j...@acorntoolworks.com
Date: Wed, 17 Aug 2011 16:40:49 -0700
Subject: [PATCH] parse-datetime: accept ISO 8601 date and
issues like this:
From 8af631b398b3b97adc501810007d1d8eecffc8b0 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 31 Aug 2011 16:43:29 +0200
Subject: [PATCH] test-parse-datetime.c: accommodate a relatively strict gcc
warning
* tests/test-parse-datetime.c (gmt_offset
Eric Blake wrote:
On 08/31/2011 08:44 AM, Jim Meyering wrote:
@@ -93,21 +93,21 @@ tm_diff (struct tm const *a, struct tm const *b)
}
#endif /* ! HAVE_TM_GMTOFF */
-long
-gmt_offset()
+static long
+gmt_offset ()
Shouldn't this be:
static long
gmt_offset (void)
to avoid yet more
Pádraig Brady wrote:
On 08/31/2011 03:25 PM, Jim Meyering wrote:
diff --git a/lib/parse-datetime.y b/lib/parse-datetime.y
+iso_8601_time:
+tUNUMBER zone_offset
+ {
+set_hhmmss (pc, $1.value, 0, 0, 0);
+pc-meridian = MER24;
There is a tab introduced above.
Thanks
00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 31 Aug 2011 17:47:18 +0200
Subject: [PATCH] tests: avoid spurious assertion failure in test-float.c
* tests/test-float.c (test_long_double): Comment out assertion
that is failing on ppc64 with at least gcc-4.4.4.
---
ChangeLog
Pádraig Brady wrote:
On 08/31/2011 04:48 PM, Jim Meyering wrote:
The test-float test is failing on ppc64 with:
gcc version 4.4.4 20100630 (Red Hat 4.4.4-10) (GCC)
(albeit an aging Fedora 12 system)
due to the failure of this assertion:
ASSERT (LDBL_MIN_EXP = DBL_MIN_EXP
Bruno Haible wrote:
Jim Meyering wrote:
IMHO the latter (enhancing gcc) makes more sense.
OK, I've reported it as a GCC bug here:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50154
Thanks!
[re-adding bug-gnulib to the Cc list]
Dmitry Sivachenko wrote:
On Fri, Aug 19, 2011 at 09:33:04PM +0200, Jim Meyering wrote:
Once we have the parse-datetime dateTtime patch,
I'll be ready to release coreutils-8.13.
It's been almost 4 months and over 170 commits since 8.12,
so we're overdue
Bruno Haible wrote:
Paul Eggert wrote:
portable programs should not pass a NULL format to 'error', so this is not
a gnulib bug.
Yes. But why does it not yield a GCC warning?
foo.c =
#include errno.h
#include stdlib.h
extern void error
Reuben Thomas wrote:
diff --git a/top/README-release b/top/README-release
index 69841d2..0299c82 100644
--- a/top/README-release
+++ b/top/README-release
@@ -40,7 +40,7 @@ Here are most of the steps we (maintainers) follow
when making a release.
# TYPE must be stable, beta or alpha
J.T. Conklin wrote:
Jim Meyering j...@meyering.net writes:
I would change two doc-related things:
[...]
- I noticed that the new format iso 8601 date T iso 8601 date
is not documented. There's already a sentence or two on the
@sc{iso} 8601 date format. Dare I ask? ... Would
Jim Meyering wrote:
Paul Eggert wrote:
Thanks for all that work to make fts better! A couple of minor things
about comments:
On 08/18/2011 06:53 AM, Jim Meyering wrote:
+ into memory at once. However, When an fts_compar function
The However, can be removed (there are too many
From: Jim Meyering meyer...@redhat.com
---
lib/fts.c | 21 +
1 files changed, 1 insertions(+), 20 deletions(-)
diff --git a/lib/fts.c b/lib/fts.c
index 7210c1b..c96dd9d 100644
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -1233,12 +1233,6 @@ fts_build (register FTS *sp, int type
From: Jim Meyering meyer...@redhat.com
---
lib/fts.c | 49 -
1 files changed, 24 insertions(+), 25 deletions(-)
diff --git a/lib/fts.c b/lib/fts.c
index 62ce38f..776dda5 100644
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -1242,38 +1242,37 @@ fts_build
From: Jim Meyering meyer...@redhat.com
---
lib/fts.c | 28 +---
1 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/lib/fts.c b/lib/fts.c
index c96dd9d..62ce38f 100644
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -1192,6 +1192,17 @@ set_stat_type (struct stat *st
A few weeks ago, I noticed that removing a directory with very many
entries made rm -rf use an inordinate amount of memory. I've fixed the
underlying fts module to batch its readdir calls in the common case,
thus to imposing a reasonable ceiling on memory usage. The ceiling of
~30MB is reached
From: Jim Meyering meyer...@redhat.com
---
lib/fts.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/fts.c b/lib/fts.c
index 9e935ba..48919f7 100644
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -1229,7 +1229,6 @@ static FTSENT *
internal_function
fts_build (register
From: Jim Meyering meyer...@redhat.com
---
lib/fts.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/fts.c b/lib/fts.c
index 776dda5..b8b7c5a 100644
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -1192,7 +1192,7 @@ set_stat_type (struct stat *st, unsigned int dtype)
st
From: Jim Meyering meyer...@redhat.com
* lib/fts.c (__opendir2): Give it a new parameter, Pdir_fd, rather
than surreptitiously using sole caller's dir_fd.
---
lib/fts.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/fts.c b/lib/fts.c
index b8b7c5a..33ecffb
From: Jim Meyering meyer...@redhat.com
We are about to use this to manage any directory with
too many entries to read all of them into memory at once.
To do that, we'll need to save the DIR* pointer in each
affected FTSENT struct.
* lib/fts_.h: Include dirent.h.
(struct FTSENT) [fts_dirp]: New
From: Jim Meyering meyer...@redhat.com
Before this change, traversing (via rm -rf, find, du, etc.) an N-entry
directory would require about 256*N bytes of memory. Thus, it was
easy to construct a directory too large to be processed by any of
those tools. With this change, the maximum memory
Eric Blake wrote:
On 08/18/2011 07:53 AM, Jim Meyering wrote:
From: Jim Meyeringmeyer...@redhat.com
---
lib/fts.c | 21 +
1 files changed, 1 insertions(+), 20 deletions(-)
diff --git a/lib/fts.c b/lib/fts.c
index 7210c1b..c96dd9d 100644
--- a/lib/fts.c
+++ b/lib
Pádraig Brady wrote:
With the default threshold of 100,000, the maximum is under 30MB
and slightly faster than the first run:
...
0
+---Gi
0 4.481
hell, and ran out of spare time.
This change rolls things back to support extended format, the 'T'
corner case fixes, test cases, and doc changes.
Many thanks to Jim Meyering who's been waiting very patiently and
gently nudging me to complete this patch.
Subject: [PATCH] Parse ISO 8601
Jim Meyering wrote:
Eric Blake wrote:
On 08/18/2011 07:53 AM, Jim Meyering wrote:
From: Jim Meyeringmeyer...@redhat.com
---
lib/fts.c | 21 +
1 files changed, 1 insertions(+), 20 deletions(-)
diff --git a/lib/fts.c b/lib/fts.c
index 7210c1b..c96dd9d 100644
Paul Eggert wrote:
On 08/18/2011 02:25 PM, Jim Meyering wrote:
I had to
comment out the two verify uses to make coverity succeed in
analyzing parse-datetime.c
Dumb question: How does 'verify' break coverity?
Is there a plausible workaround?
(Sorry, I don't use coverity.)
I haven't pursued
Applying fts (via find, rm, du, chmod -R, etc.) to a directory with 4
million entries would make the parent program consume about 1GiB of RSS.
Similarly, with 32 million entries, the parent would require about 8GiB of
memory. Thus, with a large enough directory, these tools become unusable.
Paul Eggert wrote:
On 08/13/2011 03:17 PM, Bruno Haible wrote:
Jim, Eric, Paul, you are the maintainers of 'bootstrap'. Any objection
against James' patch [1]?
No, it looks OK to me; please apply. If we run into problems
we can fix them later.
I agree.
Sorry the patch languished for so
FYI,
From 17857d41b41e7b22ba58e4e0d98693ee14f022d4 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 11 Aug 2011 14:16:35 +0200
Subject: [PATCH] git-version-gen: correct the advice in a comment
* build-aux/git-version-gen: Correct comment.
Don't recommend to list
Gijs van Tulder wrote:
Paul Eggert wrote:
Thanks for the base64 bug report and patch; I applied it,
Thanks. (That's quick!)
As for the base32 part, would you be willing to assign the
copyright to the Free Software Foundation, so that we could
install it in gnulib?
Certainly. How do I do
River Tarnell wrote:
I'm using coreutils 8.5 on Solaris 10.
GNU 'sort' fails to sort some input, while Solaris 'sort' handles it
correctly:
willow% /opt/ts/gnu/bin/sort sort_test.txt
/opt/ts/gnu/bin/sort: string comparison failed: Illegal byte sequence
/opt/ts/gnu/bin/sort: Set LC_ALL='C'
Bruno Haible wrote:
Hi Paul,
when you rebased your proposed commits, the ChangeLog entries did not go
in at the top. Are you using the 'git-merge-changelog' driver?
No, I used git rebase -i, generated a revised patch, and then
applied it with git am.
Hmm, it may be that the merge
Reuben Thomas wrote:
On 24 July 2011 21:05, Reuben Thomas r...@sc3d.org wrote:
I just came across the copy-file module, which does exactly what I
want (it is even geared to making backup files), but (unfortunately
for use in an interactive program) exits on error.
Just to move this along a
Reuben Thomas wrote:
By the way, I note that the return value of chown is ignored where no
other return value is; is this an oversight, or is it really the case
that this is the one operation whose failure can be overlooked?
I think the rationalization is that depending on the type of the
I noticed a false positive that came down to spacing.
Fixed with this:
From 8068b5d283630a295b2929b9dc6a65916b10f52f Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 2 Aug 2011 14:54:34 +0200
Subject: [PATCH] maint.mk: relax the default _gl_TS_function_match regexp
.
+
2011-07-25 Jim Meyering meyer...@redhat.com
tests: test-update-copyright.sh: remove unnecessary rm commands
diff --git a/build-aux/git-version-gen b/build-aux/git-version-gen
index 686f703..6d71446 100755
--- a/build-aux/git-version-gen
+++ b/build-aux/git-version-gen
@@ -1,6 +1,6
Bruno Haible wrote:
Sam Steingold wrote:
If I prepend -I$(srcdir)/gllib to CPPFLAFS, then
#include regex.h
will read the gnulib header, not the system header.
Yes.
How can you be sure that this will not lead to any problems given that
the libgnu.a does _not_ include regex.o?
Because
Stefano Lattarini wrote:
Hi Eric, and thanks for the quick patch.
...
If you haven't already pushed this, I'd like to suggest to credit Jim too
here: it was him who've had the idea of marking the comments as FIXME,
and to suggest the removal of the hacks once a more modern autoconf can be
Paolo Bonzini wrote:
On 07/26/2011 10:26 PM, Jim Meyering wrote:
I don't know about typical mingw file system usage.
Do mingw users use NTFS often?
Yes, all of them. MinGW is just the name of the free compiler
toolchain for Windows. Unlike cygwin, it uses the MS C library, so
Pádraig Brady wrote:
On 16/07/11 01:51, Paul Eggert wrote:
On 07/15/11 03:28, Pádraig Brady wrote:
What I was getting was that it's probably better to leave
the following to the app too:
#ifndef SA_RESETHAND
# define SA_RESETHAND 0
/* Now the app writer knows they need to handle this case
901 - 1000 of 3393 matches
Mail list logo
