On 06/02/2014 08:45 PM, Ben Walton wrote:
> The value is set in se
>
> On Mon, Jun 2, 2014 at 8:31 PM, Pádraig Brady wrote:
>> On 06/02/2014 08:13 PM, Ben Walton wrote:
>>> * In the non-Win32 variant of rpl_rename, it is possible that
>>> dst_exists may be set but not used. Mark it with the
On 06/02/2014 12:45 PM, Ben Walton wrote:
The value is only referenced if RENAME_DEST_EXISTS_BUG is set.
Otherwise, it's set but never used again. This patch addresses the
case where RENAME_DEST_EXISTS_BUG is unset. Thanks -Ben
Since that's not obvious, it might be a bit cleaner to have somet
The value is set in se
On Mon, Jun 2, 2014 at 8:31 PM, Pádraig Brady wrote:
> On 06/02/2014 08:13 PM, Ben Walton wrote:
>> * In the non-Win32 variant of rpl_rename, it is possible that
>> dst_exists may be set but not used. Mark it with the unused
>> attribute to avoid compiler warnings
On 06/02/2014 08:13 PM, Ben Walton wrote:
> * In the non-Win32 variant of rpl_rename, it is possible that
> dst_exists may be set but not used. Mark it with the unused
> attribute to avoid compiler warnings.
>
> Signed-off-by: Ben Walton
> ---
> lib/rename.c | 2 +-
> 1 file changed, 1
* In the non-Win32 variant of rpl_rename, it is possible that
dst_exists may be set but not used. Mark it with the unused
attribute to avoid compiler warnings.
Signed-off-by: Ben Walton
---
lib/rename.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rename.c b/
