Re: [PATCH] maint.mk: also prohibit lower-case @var@

2012-02-07 Thread Eric Blake
On 02/03/2012 12:27 AM, Jim Meyering wrote: > Eric Blake wrote: >> * top/maint.mk (sc_makefile_at_at_check): Enhance check to cover >> lower case, like @top_srcdir@. >> >> Signed-off-by: Eric Blake >> --- >> >> Any objections to this? I noticed that libvirt had a mix >> of $(top_srcdir) and @top_

Re: [PATCH] maint.mk: also prohibit lower-case @var@

2012-02-02 Thread Jim Meyering
Eric Blake wrote: > * top/maint.mk (sc_makefile_at_at_check): Enhance check to cover > lower case, like @top_srcdir@. > > Signed-off-by: Eric Blake > --- > > Any objections to this? I noticed that libvirt had a mix > of $(top_srcdir) and @top_srcdir@ in the same variable, and > traced it to a wea

[PATCH] maint.mk: also prohibit lower-case @var@

2012-02-02 Thread Eric Blake
* top/maint.mk (sc_makefile_at_at_check): Enhance check to cover lower case, like @top_srcdir@. Signed-off-by: Eric Blake --- Any objections to this? I noticed that libvirt had a mix of $(top_srcdir) and @top_srcdir@ in the same variable, and traced it to a weak syntax check not catching the di