Re: [PATCH] poll: fix regression in Win32 emulation of poll function

2017-05-11 Thread Bruno Haible
Daniel P. Berrange wrote: > Perhaps I'm mis-understanding, but I was looking at this code: > > h = (HANDLE) _get_osfhandle (pfd[i].fd); > assure (h != NULL); > if (IsSocketHandle (h)) > { > int requested = FD_CLOSE; > > /* see above; socket handles ar

Re: [PATCH] poll: fix regression in Win32 emulation of poll function

2017-05-11 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 04:36:46PM +0200, Bruno Haible wrote: > Daniel P. Berrange wrote: > > Perhaps I'm mis-understanding, but I was looking at this code: > > > > h = (HANDLE) _get_osfhandle (pfd[i].fd); > > assure (h != NULL); > > if (IsSocketHandle (h)) > > { > >

Re: [PATCH] poll: fix regression in Win32 emulation of poll function

2017-05-11 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 03:15:46PM +0200, Bruno Haible wrote: > Hi Daniel, > > > it does not actually make poll() function correctly. We're still passing > > HANDLE objects to the rpl_select() method, instead of calling > > the native select() method. > > I don't agree with your reasoning. The se

Re: [PATCH] poll: fix regression in Win32 emulation of poll function

2017-05-11 Thread Bruno Haible
Hi Daniel, > it does not actually make poll() function correctly. We're still passing > HANDLE objects to the rpl_select() method, instead of calling > the native select() method. I don't agree with your reasoning. The select() calls in lib/poll.c:511 and lib/poll.c:547 is not passing a HANDLE, r

Re: [PATCH] poll: fix regression in Win32 emulation of poll function

2017-05-11 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 01:02:14PM +0100, Daniel P. Berrange wrote: > The previous commit: > > commit 17f1e64f00011fb745019119e21b26e4aba65e4b > Author: Paul Eggert > Date: Tue Feb 24 16:16:19 2015 -0800 > > poll: port to MSVC v18 on MS-Windows 8.1 > > Problem reported by Gisle

[PATCH] poll: fix regression in Win32 emulation of poll function

2017-05-11 Thread Daniel P. Berrange
The previous commit: commit 17f1e64f00011fb745019119e21b26e4aba65e4b Author: Paul Eggert Date: Tue Feb 24 16:16:19 2015 -0800 poll: port to MSVC v18 on MS-Windows 8.1 Problem reported by Gisle Vanem in: http://lists.gnu.org/archive/html/bug-gnulib/2015-02/msg00139.html *