Re: [PATCH] posix_openpt: new module

2011-10-20 Thread Bruno Haible
Eric, * doc/posix-functions/posix_openpt.texi: Mention ENOENT error code. Which platforms failed with ENOENT? On those platforms that don't have posix_openpt() already, except AIX and native Windows, you attempt to open /dev/ptmx. If it does not exist, the function fails with ENOENT.

Re: [PATCH] posix_openpt: new module

2011-10-20 Thread Bruno Haible
Jim Meyering wrote: diff --git a/lib/posix_openpt.c b/lib/posix_openpt.c index 3b7d4cf..19cd0b6 100644 --- a/lib/posix_openpt.c +++ b/lib/posix_openpt.c @@ -46,5 +46,3 @@ posix_openpt (int flags) return master; } - -#endif Another pretty basic failure, that makes me think I'm the

Re: [PATCH] posix_openpt: new module

2011-10-20 Thread Bruno Haible
Eric Blake wrote: +2011-10-17 Eric Blake ebl...@redhat.com + + posix_openpt: new module + * modules/posix_openpt: New module. + * m4/posix_openpt.m4: New file. + * lib/posix_openpt.c: Likewise. + * m4/stdlib_h.m4 (gl_STDLIB_H): Check for decl. +

Re: [PATCH] posix_openpt: new module

2011-10-19 Thread Bruno Haible
Hi Eric, This module fails to build on several platforms. On AIX 5.1: test-posix_openpt.c:24: error: 'posix_openpt' undeclared here (not in a function) test-posix_openpt.c: In function 'main': test-posix_openpt.c:45: warning: implicit declaration of function 'posix_openpt' make: 1254-004 The

Re: [PATCH] posix_openpt: new module

2011-10-19 Thread Eric Blake
On 10/19/2011 03:50 AM, Bruno Haible wrote: Hi Eric, This module fails to build on several platforms. On AIX 5.1: test-posix_openpt.c:24: error: 'posix_openpt' undeclared here (not in a function) Thanks for fixing that. 2011-10-19 Bruno Haiblebr...@clisp.org posix_openpt: Fix

Re: [PATCH] posix_openpt: new module

2011-10-19 Thread Jim Meyering
I ran gnulib's top-level make check, and cppi spotted this: From ca3be51f7beb529726b066d1da34acd338828b24 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 19 Oct 2011 15:28:46 +0200 Subject: [PATCH] posix_openpt: remove spurious #endif * lib/posix_openpt.c

[PATCH] posix_openpt: new module

2011-10-18 Thread Eric Blake
* modules/posix_openpt: New module. * m4/posix_openpt.m4: New file. * lib/posix_openpt.c: Likewise. * m4/stdlib_h.m4 (gl_STDLIB_H): Check for decl. (gl_STDLIB_H_DEFAULTS): Set defaults. * modules/stdlib (Makefile.am): Substitute macros. * lib/stdlib.in.h (posix_openpt): Declare. * MODULES.html.sh