Eric Blake wrote:
> On 08/31/2011 08:44 AM, Jim Meyering wrote:
>> @@ -93,21 +93,21 @@ tm_diff (struct tm const *a, struct tm const *b)
>> }
>> #endif /* ! HAVE_TM_GMTOFF */
>>
>> -long
>> -gmt_offset()
>> +static long
>> +gmt_offset ()
>
> Shouldn't this be:
>
> static long
> gmt_offset (void
On 08/31/2011 08:44 AM, Jim Meyering wrote:
@@ -93,21 +93,21 @@ tm_diff (struct tm const *a, struct tm const *b)
}
#endif /* ! HAVE_TM_GMTOFF */
-long
-gmt_offset()
+static long
+gmt_offset ()
Shouldn't this be:
static long
gmt_offset (void)
to avoid yet more warnings about K&R declarati
some style issues like this:
>From 8af631b398b3b97adc501810007d1d8eecffc8b0 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 31 Aug 2011 16:43:29 +0200
Subject: [PATCH] test-parse-datetime.c: accommodate a relatively strict gcc
warning
* tests/test-parse-datetime.c (gmt_offset): Dec