Trying to build coreutils on rawhide (with all warnings and -Werror, of course), I am seeing new spurious failures in gnulib-tests/:
test-accept.c: In function 'main': test-accept.c:33:3: error: statement with no effect [-Werror=unused-value] cc1: all warnings being treated as errors They're all the same. For reference, here's the definition of that function: int gl_sockets_startup (int version _GL_UNUSED) { #if WINDOWS_SOCKETS if (version > initialized_sockets_version) { WSADATA data; int err; err = WSAStartup (version, &data); if (err != 0) return 1; if (data.wVersion < version) return 2; if (initialized_sockets_version == 0) register_fd_hook (close_fd_maybe_socket, ioctl_fd_maybe_socket, &fd_sockets_hook); initialized_sockets_version = version; } #endif return 0; } Note how it always returns 0 for non-Windows systems. IMHO, it's fine just to ignore failure in tests/*.c. Since (void) works, I'm not bothering with ignore-value.h. >From 722f6dd800d2885c71106aa4ac79c7ae265822ae Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@redhat.com> Date: Mon, 23 Jan 2012 15:51:02 +0100 Subject: [PATCH] tests: avoid spurious warning about gl_sockets_startup * tests/test-accept.c (main): Mark as "(void)". * tests/test-accept4.c (main): Likewise. * tests/test-bind.c (main): Likewise. * tests/test-connect.c (main): Likewise. * tests/test-getpeername.c (main): Likewise. * tests/test-getsockname.c (main): Likewise. * tests/test-getsockopt.c (main): Likewise. * tests/test-listen.c (main): Likewise. * tests/test-recv.c (main): Likewise. * tests/test-recvfrom.c (main): Likewise. * tests/test-send.c (main): Likewise. * tests/test-sendto.c (main): Likewise. * tests/test-setsockopt.c (main): Likewise. * tests/test-shutdown.c (main): Likewise. --- ChangeLog | 18 ++++++++++++++++++ tests/test-accept.c | 2 +- tests/test-accept4.c | 2 +- tests/test-bind.c | 2 +- tests/test-connect.c | 2 +- tests/test-getpeername.c | 2 +- tests/test-getsockname.c | 2 +- tests/test-getsockopt.c | 2 +- tests/test-listen.c | 2 +- tests/test-recv.c | 2 +- tests/test-recvfrom.c | 2 +- tests/test-send.c | 2 +- tests/test-sendto.c | 2 +- tests/test-setsockopt.c | 2 +- tests/test-shutdown.c | 2 +- 15 files changed, 32 insertions(+), 14 deletions(-) diff --git a/ChangeLog b/ChangeLog index 20aa6d4..cb51779 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,21 @@ +2012-01-23 Jim Meyering <meyer...@redhat.com> + + tests: avoid spurious warning about gl_sockets_startup + * tests/test-accept.c (main): Mark as "(void)". + * tests/test-accept4.c (main): Likewise. + * tests/test-bind.c (main): Likewise. + * tests/test-connect.c (main): Likewise. + * tests/test-getpeername.c (main): Likewise. + * tests/test-getsockname.c (main): Likewise. + * tests/test-getsockopt.c (main): Likewise. + * tests/test-listen.c (main): Likewise. + * tests/test-recv.c (main): Likewise. + * tests/test-recvfrom.c (main): Likewise. + * tests/test-send.c (main): Likewise. + * tests/test-sendto.c (main): Likewise. + * tests/test-setsockopt.c (main): Likewise. + * tests/test-shutdown.c (main): Likewise. + 2012-01-21 Bruno Haible <br...@clisp.org> locale-fr.m4: Fix for Android. diff --git a/tests/test-accept.c b/tests/test-accept.c index 201e130..265ef64 100644 --- a/tests/test-accept.c +++ b/tests/test-accept.c @@ -30,7 +30,7 @@ SIGNATURE_CHECK (accept, int, (int, struct sockaddr *, socklen_t *)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-accept4.c b/tests/test-accept4.c index d6de017..b81c25c 100644 --- a/tests/test-accept4.c +++ b/tests/test-accept4.c @@ -33,7 +33,7 @@ SIGNATURE_CHECK (accept4, int, (int, struct sockaddr *, socklen_t *, int)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-bind.c b/tests/test-bind.c index b4b5739..e97be2a 100644 --- a/tests/test-bind.c +++ b/tests/test-bind.c @@ -31,7 +31,7 @@ SIGNATURE_CHECK (bind, int, (int, const struct sockaddr *, socklen_t)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-connect.c b/tests/test-connect.c index 6e43bf8..9ef8923 100644 --- a/tests/test-connect.c +++ b/tests/test-connect.c @@ -31,7 +31,7 @@ SIGNATURE_CHECK (connect, int, (int, const struct sockaddr *, socklen_t)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-getpeername.c b/tests/test-getpeername.c index f15b32f..b0545c6 100644 --- a/tests/test-getpeername.c +++ b/tests/test-getpeername.c @@ -30,7 +30,7 @@ SIGNATURE_CHECK (getpeername, int, (int, struct sockaddr *, socklen_t *)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-getsockname.c b/tests/test-getsockname.c index 91100c6..7e5d463 100644 --- a/tests/test-getsockname.c +++ b/tests/test-getsockname.c @@ -30,7 +30,7 @@ SIGNATURE_CHECK (getsockname, int, (int, struct sockaddr *, socklen_t *)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-getsockopt.c b/tests/test-getsockopt.c index 38145a7..24730b0 100644 --- a/tests/test-getsockopt.c +++ b/tests/test-getsockopt.c @@ -29,7 +29,7 @@ SIGNATURE_CHECK (getsockopt, int, (int, int, int, void *, socklen_t *)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-listen.c b/tests/test-listen.c index 3ea82d4..b81558a 100644 --- a/tests/test-listen.c +++ b/tests/test-listen.c @@ -29,7 +29,7 @@ SIGNATURE_CHECK (listen, int, (int, int)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-recv.c b/tests/test-recv.c index a147d5d..2186b8e 100644 --- a/tests/test-recv.c +++ b/tests/test-recv.c @@ -29,7 +29,7 @@ SIGNATURE_CHECK (recv, ssize_t, (int, void *, size_t, int)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-recvfrom.c b/tests/test-recvfrom.c index 1447620..7f6f6f6 100644 --- a/tests/test-recvfrom.c +++ b/tests/test-recvfrom.c @@ -32,7 +32,7 @@ SIGNATURE_CHECK (recvfrom, ssize_t, int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-send.c b/tests/test-send.c index febbe20..7b068d1 100644 --- a/tests/test-send.c +++ b/tests/test-send.c @@ -29,7 +29,7 @@ SIGNATURE_CHECK (send, ssize_t, (int, const void *, size_t, int)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-sendto.c b/tests/test-sendto.c index 88fad93..1d0e410 100644 --- a/tests/test-sendto.c +++ b/tests/test-sendto.c @@ -33,7 +33,7 @@ SIGNATURE_CHECK (sendto, ssize_t, int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-setsockopt.c b/tests/test-setsockopt.c index cc78a1b..c14d217 100644 --- a/tests/test-setsockopt.c +++ b/tests/test-setsockopt.c @@ -29,7 +29,7 @@ SIGNATURE_CHECK (setsockopt, int, (int, int, int, const void *, socklen_t)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { diff --git a/tests/test-shutdown.c b/tests/test-shutdown.c index 91d979a..be9f550 100644 --- a/tests/test-shutdown.c +++ b/tests/test-shutdown.c @@ -29,7 +29,7 @@ SIGNATURE_CHECK (shutdown, int, (int, int)); int main (void) { - gl_sockets_startup (SOCKETS_1_1); + (void) gl_sockets_startup (SOCKETS_1_1); /* Test behaviour for invalid file descriptors. */ { -- 1.7.9.rc2.2.g183d6