Re: [PATCH 01/11] Fix base64 module to work with grub codebase

2021-12-09 Thread Daniel Kiper
Bumping the thread... Please take a look below... On Tue, Nov 23, 2021 at 05:24:31PM +0100, Daniel Kiper wrote: > CC-ing Vladimir... > > On Tue, Nov 09, 2021 at 02:34:25PM -0500, Robbie Harwood wrote: > > Paul Eggert writes: > > > On 10/28/21 12:32, Robbie Harwood wrote: > > > > > >> I don't

Re: [PATCH 01/11] Fix base64 module to work with grub codebase

2021-11-23 Thread Daniel Kiper
CC-ing Vladimir... On Tue, Nov 09, 2021 at 02:34:25PM -0500, Robbie Harwood wrote: > Paul Eggert writes: > > > On 10/28/21 12:32, Robbie Harwood wrote: > > > >> I don't know why Patrick chose to > >> not use that instead, but a local test seems to work. > > > > Is grub2 intended to be portable

Re: [PATCH 01/11] Fix base64 module to work with grub codebase

2021-11-09 Thread Robbie Harwood
Paul Eggert writes: > On 10/28/21 12:32, Robbie Harwood wrote: > >> I don't know why Patrick chose to >> not use that instead, but a local test seems to work. > > Is grub2 intended to be portable to compilers that don't support > ? If that's the issue, I suggest that grub2 stop worrying >

Re: [PATCH 01/11] Fix base64 module to work with grub codebase

2021-11-09 Thread Paul Eggert
On 10/28/21 12:32, Robbie Harwood wrote: I don't know why Patrick chose to not use that instead, but a local test seems to work. Is grub2 intended to be portable to compilers that don't support ? If that's the issue, I suggest that grub2 stop worrying that. Surely every compiler of interest

Re: [PATCH 01/11] Fix base64 module to work with grub codebase

2021-11-09 Thread Simon Josefsson via Gnulib discussion list
Robbie Harwood writes: > So I think our way forward is to move where we nerf _GL_ATTRIBUTE_CONST > in grub2. I've tested that this works and will submit to grub2. > > Longer-term, this problem could be avoided by dropping the const > attribute from isbase64(). Since uchar_in_range is a macro,

Re: [PATCH 01/11] Fix base64 module to work with grub codebase

2021-10-28 Thread Robbie Harwood
Simon Josefsson writes: > Robbie Harwood writes: > >> The gnulib module makes use of booleans via the header. As >> GRUB does not provide any POSIX wrapper header for this, but instead >> implements support for bool in , we need to patch >> base64.h to not use anymore. We unfortunately cannot

Re: [PATCH 01/11] Fix base64 module to work with grub codebase

2021-10-27 Thread Simon Josefsson via Gnulib discussion list
Robbie Harwood writes: > The gnulib module makes use of booleans via the header. As > GRUB does not provide any POSIX wrapper header for this, but instead > implements support for bool in , we need to patch > base64.h to not use anymore. We unfortunately cannot include > instead, as it would

[PATCH 01/11] Fix base64 module to work with grub codebase

2021-10-25 Thread Robbie Harwood
From: Patrick Steinhardt The gnulib module makes use of booleans via the header. As GRUB does not provide any POSIX wrapper header for this, but instead implements support for bool in , we need to patch base64.h to not use anymore. We unfortunately cannot include instead, as it would then use