Re: [PATCH 1/5] win32: Use ANSI functions

2009-10-02 Thread Bruno Haible
I wrote: > It would be best if clisp would change its macro 'UNICODE' to > 'ENABLE_UNICODE'. This is done now. Paolo Bonzini wrote: > > 1) Ability to look up the documentation. The next developers to maintain > > this code should be able to google the function names and use the > > names

Re: [PATCH 1/5] win32: Use ANSI functions

2009-10-01 Thread Paolo Bonzini
On 10/02/2009 01:47 AM, Bruno Haible wrote: 1) Ability to look up the documentation. The next developers to maintain this code should be able to google the function names and use the names that are commonly in use. While I'll drop this patch, I'll note that we _do_ use *A names when we

Re: [PATCH 1/5] win32: Use ANSI functions

2009-10-01 Thread Bruno Haible
Hi Paolo, > This first one uses ANSI functions whenever we're passing or receiving > strings, so that compiling with -DUNICODE succeeds. ... Ok? I object, for the reason of maintainability of code. 1) Ability to look up the documentation. The next developers to maintain this code should be a

Re: [PATCH 1/5] win32: Use ANSI functions

2009-10-01 Thread Paolo Bonzini
On 10/01/2009 04:54 PM, Jim Meyering wrote: Just glancing through, some space-before-TAB sequences jumped out at me because they were highlighted. When changing so much, you might want to switch the affected file to space-only indentation. Sure. Will do so before committing. Paolo

Re: [PATCH 1/5] win32: Use ANSI functions

2009-10-01 Thread Jim Meyering
Paolo Bonzini wrote: > Hi all, this is the first of a few patches to a few Win32 implementations > of gnulib modules. > > This first one uses ANSI functions whenever we're passing or receiving > strings, so that compiling with -DUNICODE succeeds. I started from the > list of Win32 API functions, w

[PATCH 1/5] win32: Use ANSI functions

2009-10-01 Thread Paolo Bonzini
Hi all, this is the first of a few patches to a few Win32 implementations of gnulib modules. This first one uses ANSI functions whenever we're passing or receiving strings, so that compiling with -DUNICODE succeeds. I started from the list of Win32 API functions, which I got from grep -orh '\<