Re: [PATCH v2 00/10] Update libunistring-related modules to Unicode 7.0.0

2014-11-12 Thread Daiki Ueno
Daiki Ueno writes: > Paul Eggert writes: > >> On 10/23/2014 04:43 AM, Pádraig Brady wrote: >>> Except for the assert() nit, I can't find any issues. >> >> My only nit was adding the "#if 0"; might as well just delete the code >> instead. I only read the code; I didn't test it. > > Thanks. Will

Re: [PATCH v2 00/10] Update libunistring-related modules to Unicode 7.0.0

2014-10-23 Thread Daiki Ueno
Paul Eggert writes: > On 10/23/2014 04:43 AM, Pádraig Brady wrote: >> Except for the assert() nit, I can't find any issues. > > My only nit was adding the "#if 0"; might as well just delete the code > instead. I only read the code; I didn't test it. Thanks. Will fix those in the next update.

Re: [PATCH v2 00/10] Update libunistring-related modules to Unicode 7.0.0

2014-10-23 Thread Paul Eggert
On 10/23/2014 04:43 AM, Pádraig Brady wrote: Except for the assert() nit, I can't find any issues. My only nit was adding the "#if 0"; might as well just delete the code instead. I only read the code; I didn't test it.

Re: [PATCH v2 00/10] Update libunistring-related modules to Unicode 7.0.0

2014-10-23 Thread Pádraig Brady
On 10/23/2014 09:01 AM, Daiki Ueno wrote: > Hello, > > This is an update of the patches I posted on bug-libunistring two weeks ago: > https://lists.gnu.org/archive/html/bug-libunistring/2014-10/msg1.html > > Changes from v1: > - The line-breaking implementation has been updated for LBP_HL and

[PATCH v2 00/10] Update libunistring-related modules to Unicode 7.0.0

2014-10-23 Thread Daiki Ueno
Hello, This is an update of the patches I posted on bug-libunistring two weeks ago: https://lists.gnu.org/archive/html/bug-libunistring/2014-10/msg1.html Changes from v1: - The line-breaking implementation has been updated for LBP_HL and LBP_RI - The changes to gen-uninames.lisp is included -