On 12/7/21 10:51, Robbie Harwood wrote:
I don't believe we have an implementation of abort() that can
be called. (We have grub_abort() instead.) If that's the correct
reason, then DEBUG_ASSERT would work and I can make that change.
Looking into the code a bit more, it looks like a DEBUG_ASSER
Paul Eggert writes:
> On 12/1/21 19:20, Paul Eggert wrote:
>> On 12/1/21 13:02, Robbie Harwood wrote:
>>> @@ -1099,7 +1099,7 @@ optimize_utf8 (re_dfa_t *dfa)
>>> }
>>> break;
>>> default:
>>> - abort ();
>>> + break;
>>> }
>>
>> Likewise, it's not clear why this
On 12/1/21 19:20, Paul Eggert wrote:
On 12/1/21 13:02, Robbie Harwood wrote:
@@ -1099,7 +1099,7 @@ optimize_utf8 (re_dfa_t *dfa)
}
break;
default:
- abort ();
+ break;
}
Likewise, it's not clear why this change is needed. The 'abort' should
not be reachable.
On 12/1/21 13:02, Robbie Harwood wrote:
@@ -1099,7 +1099,7 @@ optimize_utf8 (re_dfa_t *dfa)
}
break;
default:
- abort ();
+ break;
}
Likewise, it's not clear why this change is needed. The 'abort' should
not be reachable.
Is the intent to make the
It's not clear why this change is needed. POSIX says that for regerror
"the application shall ensure is the last non-zero value returned by
regcomp() or regexec() with the given value of preg". If an application
violates a "shall" requirement, behavior is undefined so it's OK for
regerror to ab
