Re: check-news target fails if NEWS file starts with a copyright header

2010-06-08 Thread Peter Simons
Hi Jim, > Any additional comments or suggestions? no, I'm happy with the end result. Thank you. Take care, Peter

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-08 Thread Jim Meyering
Peter Simons wrote: > > How about removing the use of "head" and using this as the default: > > > > sed -n 1,10p > > yes, that is a really good idea. Thanks for the patch. I've adjusted that to move comments from the log into maint.mk, where future users will be more likely to read them. Once

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-08 Thread Peter Simons
Hi Jim, > How about removing the use of "head" and using this as the default: > > sed -n 1,10p yes, that is a really good idea. Take care, Peter >From b0e59e16e848f5a6f65fb2a8d5cb16a5355a8a37 Mon Sep 17 00:00:00 2001 From: Peter Simons Date: Mon, 7 Jun 2010 15:24:21 +0200 Subject: [PATCH]

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-07 Thread Jim Meyering
Peter Simons wrote: ... > > If you're motivated, propose a patch. > > My suggested solution is attached. Thanks, but that does not allow us to select ranges like "just line 3" or "lines 20-22". How about removing the use of "head" and using this as the default: sed -n 1,10p

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-07 Thread Peter Simons
Jim Meyering wrote: > My wanting to minimize risk is now "irrational fears"? No, of course not. The desire to minimize risks is perfectly reasonable. However, your perception of the risks involved in this change strikes me as somewhat exaggerated. > Is there some reason you'd rather not move

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-07 Thread Jim Meyering
Peter Simons wrote: > Jim Meyering wrote: > > The penalty for an inadequate test would be to release without updating > > NEWS. > > so, according to your logic, expecting any of the top 10 lines of NEWS to > match a particular regular expression is "adequate", but expecting any of > the top, say

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-07 Thread Peter Simons
Jim Meyering wrote: > The penalty for an inadequate test would be to release without updating > NEWS. so, according to your logic, expecting any of the top 10 lines of NEWS to match a particular regular expression is "adequate", but expecting any of the top, say 11 lines, of NEWS to match that

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-07 Thread Jim Meyering
Peter Simons wrote: > Karl Berry writes: > > However, I also see no harm in looking at the first 20 lines instead > > of the first 10 lines to match the version. > > yes, I agree with Karl here. The current implementation enforces a > policy that feels rather odd. A NEWS file that features the re

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-06 Thread Peter Simons
Karl Berry writes: > However, I also see no harm in looking at the first 20 lines instead > of the first 10 lines to match the version. yes, I agree with Karl here. The current implementation enforces a policy that feels rather odd. A NEWS file that features the release heading in line 10 is co

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Jim Meyering
Karl Berry wrote: > A while ago, Karl encouraged GNU maintainers to just license files like > > Well, more precisely, I attempted to clarify rms' recommendation which > has been the intention since the early days of GNU. I don't make policy > decisions like this myself :). > > However, I don'

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Karl Berry
A while ago, Karl encouraged GNU maintainers to just license files like Well, more precisely, I attempted to clarify rms' recommendation which has been the intention since the early days of GNU. I don't make policy decisions like this myself :). However, I don't see any particular problem wi

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Ralf Wildenhues
Hi Jim, Peter, * Jim Meyering wrote on Fri, Jun 04, 2010 at 02:40:20PM CEST: > > You may want to put the copyright at the end of NEWS. > Human readers prefer it that way, too ;-) > > Here's what I use: > > > Copyright (C)

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Jim Meyering
Peter Simons wrote: > the NEWS file of the GNU Autoconf Archive begins with a copyright header. As a > result, the check-news target fails, because the output of "head ./NEWS" > doesn't contain the release line that target is looking for. > > I have worked around the problem by patching maint.mk as

check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Peter Simons
Hi, the NEWS file of the GNU Autoconf Archive begins with a copyright header. As a result, the check-news target fails, because the output of "head ./NEWS" doesn't contain the release line that target is looking for. I have worked around the problem by patching maint.mk as follows: sed -i -e '