Re: clang warnings in regcomp.c

2020-10-10 Thread Bruno Haible
Paul Eggert wrote: > > What is the point of these parentheses? > > Haven't a clue. It's an unusual style. > > > static reg_errcode_t preorder (bin_tree_t *root, > > - reg_errcode_t (fn (void *, bin_tree_t *)), > > + reg_errcode_t fn (void *,

Re: clang warnings in regcomp.c

2020-09-06 Thread Paul Eggert
On 9/6/20 5:45 PM, Bruno Haible wrote: What is the point of these parentheses? Haven't a clue. It's an unusual style. static reg_errcode_t preorder (bin_tree_t *root, - reg_errcode_t (fn (void *, bin_tree_t *)), + reg_errcode_t fn

clang warnings in regcomp.c

2020-09-06 Thread Bruno Haible
clang produces these warning about regcomp.c: regcomp.c(40,25): warning: redundant parentheses surrounding declarator [-Wredundant-parens] regcomp.c(43,19): warning: redundant parentheses surrounding declarator [-Wredundant-parens] regcomp.c(1226,44): warning: redundant parentheses surrounding