getaddrinfo needs socklen, sync from coreutils

2005-09-23 Thread Jim Meyering
I've just discovered/fixed a build problem with the getaddrinfo module. It didn't depend on the socklen module (for the declaration of socklen_t). So I've merged these changes from coreutils: 2005-09-23 Jim Meyering <[EMAIL PROTECTED]> * modules/getaddrinfo (Depends-on): Add socklen. 2

Re: getaddrinfo needs socklen, sync from coreutils

2005-09-23 Thread Jim Meyering
Paul Eggert <[EMAIL PROTECTED]> wrote: > Bruno Haible <[EMAIL PROTECTED]> writes: > >> This is redundant. The module dependency from 'getaddrinfo' to 'socklen' >> already implies that gl_SOCKLEN_T must be invoked from configure.ac, >> directly or indirectly. No need to repeat the module dependenci

Re: getaddrinfo needs socklen, sync from coreutils

2005-09-24 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > I've just discovered/fixed a build problem with the getaddrinfo module. > It didn't depend on the socklen module (for the declaration of socklen_t). > So I've merged these changes from coreutils: Hm. socklen_t is POSIX. Shouldn't getaddrinfo assume a PO

Re: getaddrinfo needs socklen, sync from coreutils

2005-09-24 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> I've just discovered/fixed a build problem with the getaddrinfo module. >> It didn't depend on the socklen module (for the declaration of socklen_t). >> So I've merged these changes from coreutils: > > Hm. s

Re: getaddrinfo needs socklen, sync from coreutils

2005-09-24 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> wrote: > >> Jim Meyering <[EMAIL PROTECTED]> writes: >> >>> I've just discovered/fixed a build problem with the getaddrinfo module. >>> It didn't depend on the socklen module (for the declaration of socklen_t). >>> So I

Re: getaddrinfo needs socklen, sync from coreutils

2005-09-26 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> I was thinking of a similar situation with >> strdup: I thought many modules used strdup without depending on the >> strdup module > > Huh? The modules canon-host, getaddrinfo, glob, hard-locale, iconvme, userspec > all depend on

Re: [bug-gnulib] getaddrinfo needs socklen, sync from coreutils

2005-09-23 Thread Bruno Haible
Jim Meyering wrote: > # Prerequisites of lib/getaddrinfo.h and lib/getaddrinfo.c. > AC_DEFUN([gl_PREREQ_GETADDRINFO], [ > + AC_REQUIRE([gl_SOCKLEN_T]) >AC_REQUIRE([gl_C_RESTRICT]) >AC_REQUIRE([gl_SOCKET_FAMILIES]) This is redundant. The module dependency from 'getaddrinfo' to 'socklen'

Re: [bug-gnulib] getaddrinfo needs socklen, sync from coreutils

2005-09-23 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > This is redundant. The module dependency from 'getaddrinfo' to 'socklen' > already implies that gl_SOCKLEN_T must be invoked from configure.ac, > directly or indirectly. No need to repeat the module dependencies in the > *.m4 files. Right you are. I und

Re: [bug-gnulib] Re: getaddrinfo needs socklen, sync from coreutils

2005-09-26 Thread Bruno Haible
Simon Josefsson wrote: > I was thinking of a similar situation with > strdup: I thought many modules used strdup without depending on the > strdup module Huh? The modules canon-host, getaddrinfo, glob, hard-locale, iconvme, userspec all depend on strdup. And getpass doesn't, because it uses strdup