Re: maintainer-makefile: quoting

2012-08-06 Thread Jim Meyering
Simon Josefsson wrote: > Jim Meyering writes: > >> Adding quotes is the solution, but you must then remove >> one layer of backslash quoting: > > Of course, thank you. What I was mostly surprised about was that nobody > else had run into this. I suppose bash doesn't trigger the problem. So > is

Re: maintainer-makefile: quoting

2012-08-06 Thread Simon Josefsson
Jim Meyering writes: > Adding quotes is the solution, but you must then remove > one layer of backslash quoting: Of course, thank you. What I was mostly surprised about was that nobody else had run into this. I suppose bash doesn't trigger the problem. So is this a problem with dash, or was t

Re: maintainer-makefile: quoting

2012-08-06 Thread Jim Meyering
Simon Josefsson wrote: > I got this error from syntax-check: > > jas@latte:~/src/libidn$ make sc_vulnerable_makefile_CVE-2012-3386 > vulnerable_makefile_CVE-2012-3386 > /bin/sh: 2: Syntax error: "(" unexpected > make: *** [sc_vulnerable_makefile_CVE-2012-3386] Fel 2 > jas@latte:~/src/libidn$ > > Th

maintainer-makefile: quoting

2012-08-06 Thread Simon Josefsson
I got this error from syntax-check: jas@latte:~/src/libidn$ make sc_vulnerable_makefile_CVE-2012-3386 vulnerable_makefile_CVE-2012-3386 /bin/sh: 2: Syntax error: "(" unexpected make: *** [sc_vulnerable_makefile_CVE-2012-3386] Fel 2 jas@latte:~/src/libidn$ The patch below appears to fix it. This