Re: musl, fdopen test

2012-06-20 Thread Bruno Haible
> > 2012-06-19 Bruno Haible > > > > fdopen: Allow implementations that don't reject invalid fd arguments. > > * m4/fdopen.m4 (gl_FUNC_FDOPEN): Let the test pass if fdopen(-1,...) > > succeeds. > > Reported by Rich Felker . > > Thanks, Bruno. > That patch looks perfect.

Re: musl, fdopen test

2012-06-19 Thread Jim Meyering
Bruno Haible wrote: ... >> My thought in having musl skip the test is to maximize performance of >> fdopen, assuming you might be using it in a situation like on a newly >> accept()ed network connection where every syscall counts (think >> multi-threaded httpd). For read-only fdopen, no syscalls ar

Re: musl, fdopen test

2012-06-19 Thread Bruno Haible
Rich Felker wrote: > > >> Replacement of fdopen, because of > > >> checking whether fdopen sets errno... no > > > > > > There was one bug here (failure to set errno when mode string was > > > invalid) but I don't think that's the case gnulib was testing for. It > > > seems gnulib wants an error