Re: readutmp: Non-portable UT_PID use.

2012-09-14 Thread Mats Erik Andersson
Dear all, torsdag den 6 september 2012 klockan 07:59 skrev Jim Meyering detta: > Eric Blake wrote: > > > > Jim likes favoring < over >, so I'm swapping this to '0 < UT_PID (u)'. > > Thanks Mats and Eric. That looks fine. With this new readutmp module, I have renovated the talkd server of GNU I

Re: readutmp: Non-portable UT_PID use.

2012-09-05 Thread Jim Meyering
Eric Blake wrote: > On 09/05/2012 02:08 PM, Mats Erik Andersson wrote: >> Dear all, >> >> the module readutmp is broken for the standard use >> >> read_utmp(..., READ_UTMP_USER_PROCESS | READ_UTMP_CHECK_PIDS) >> >> for all releases of FreeBSD until 8.3, and all OpenBSD ever released. > > Thanks

Re: readutmp: Non-portable UT_PID use.

2012-09-05 Thread Eric Blake
On 09/05/2012 02:08 PM, Mats Erik Andersson wrote: > Dear all, > > the module readutmp is broken for the standard use > > read_utmp(..., READ_UTMP_USER_PROCESS | READ_UTMP_CHECK_PIDS) > > for all releases of FreeBSD until 8.3, and all OpenBSD ever released. Thanks for the report. > >>From 6

readutmp: Non-portable UT_PID use.

2012-09-05 Thread Mats Erik Andersson
Dear all, the module readutmp is broken for the standard use read_utmp(..., READ_UTMP_USER_PROCESS | READ_UTMP_CHECK_PIDS) for all releases of FreeBSD until 8.3, and all OpenBSD ever released. The reason is that those systems do not provide `utmp.ut_pid', thus making the macro UT_PID(u) ident