Re: rules, rules, and more (code policy) rules

Simon Josefsson [EMAIL PROTECTED] wrote: Ok. How about maint.mk and maint-cfg.mk? Sounds good. Installed. Auto-completing maint* is causing me problem already... while this is very minor, it also occurred to me that cfg is rather incorrect. maint-cfg.mk will likely contain a lot of local

Re: rules, rules, and more (code policy) rules

Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: Simon Josefsson [EMAIL PROTECTED] writes: If I forget to run ./configure ..., I'd rather get a warning than have GNUmakefile run it for me. Providing the rules might be nice, as long as they're hooked to some

Re: rules, rules, and more (code policy) rules

Simon Josefsson [EMAIL PROTECTED] writes: * build-aux/Makefile.maint: I will hurt my fingers over this name (and the related Makefile.cfg), when completing for Makefile.am, so I would prefer to have names that doesn't begin with 'Makefile'. gnulib.mk and gnulib-cfg.mk? gnulib.mk and

Re: rules, rules, and more (code policy) rules

Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: # Make tar archive easier to reproduce. export TAR_OPTIONS = --owner=0 --group=0 --numeric-owner Those options help minimize unnecessary differences between tar archives. ... Still, I think the TAR stuff is

Re: rules, rules, and more (code policy) rules

Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: I'm now using this (with a couple of modifications) in GNU SASL. One thing that struck me as very useful, is the ability to invoke tests without having to autoreconf + configure. ... If I forget to run

Re: rules, rules, and more (code policy) rules

Simon Josefsson [EMAIL PROTECTED] writes: If I forget to run ./configure ..., I'd rather get a warning than have GNUmakefile run it for me. Providing the rules might be nice, as long as they're hooked to some nonstandard target. Yep, I agree. It should be possible to override this in

Re: rules, rules, and more (code policy) rules

Simon Josefsson [EMAIL PROTECTED] wrote: I think CVS_LIST has some disadvantages: * Unrelated to the core problem. The core problem is how to list all C code or header files. Even if you use CVS_LIST, you'll have to filter it further, excluding generated files the maintainer has no

Re: rules, rules, and more (code policy) rules

Simon Josefsson [EMAIL PROTECTED] wrote: # Make tar archive easier to reproduce. export TAR_OPTIONS = --owner=0 --group=0 --numeric-owner Those options help minimize unnecessary differences between tar archives. ... Still, I think the TAR stuff is different. You can't set TAR_OPTIONS in

Re: rules, rules, and more (code policy) rules

Simon Josefsson [EMAIL PROTECTED] wrote: I'm now using this (with a couple of modifications) in GNU SASL. One thing that struck me as very useful, is the ability to invoke tests without having to autoreconf + configure. ... If I forget to run ./configure ..., I'd rather get a warning than

Re: rules, rules, and more (code policy) rules

Jim Meyering [EMAIL PROTECTED] writes: Using 'find . -name *.[chly]` seem more appropriate. Or? Some tests do: sc_space_tab: @( $(CVS_LIST) ) /dev/null 21 || :\ where CVS_LIST is: # cvsu is part of the cvsutils package: http://www.red-bean.com/cvsutils/

Re: rules, rules, and more (code policy) rules

How about this approach? The Makefile.maint is intentionally minimal. I'll merge reliable tests from Coreutils Makefile.maint as we move along. Maintainers can put additional rules into Makefile.cfg if they want. I would expect that most of Coreutils' Makefile.maint would go into Makefile.cfg,

Re: rules, rules, and more (code policy) rules

I'm now using this (with a couple of modifications) in GNU SASL. One thing that struck me as very useful, is the ability to invoke tests without having to autoreconf + configure. I had to make sure that GNUmakefile include Makefile.maint even when Makefile doesn't exist for this to work. GNU

Re: rules, rules, and more (code policy) rules

Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: I'm going through Coreutils GNUmakefile and Makefile.maint to identify useful rules. Some question pop up: 1) Is this rule generally safe? Does it assume GNU tar? Is there a real problem solved by this, or

Re: rules, rules, and more (code policy) rules

Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: Jim Meyering [EMAIL PROTECTED] writes: I tend to forget, too, so have automated quite a few policy checks, over the years. You might try adding some checks like those in coreutils' Makefile.maint. Here are the

Re: rules, rules, and more (code policy) rules

A lot of the tests look like: sc_cast_of_argument_to_free: @grep -E '\free \(\(' $(srcdir)/{lib,src}/*.[chly] \ I.e., the paths and filenames are hardcoded. Using 'find . -name *.[chly]` seem more appropriate. Or? Some tests do: sc_space_tab: @( $(CVS_LIST) )

Re: rules, rules, and more (code policy) rules

Simon Josefsson [EMAIL PROTECTED] wrote: I'm going through Coreutils GNUmakefile and Makefile.maint to identify useful rules. Some question pop up: 1) Is this rule generally safe? Does it assume GNU tar? Is there a real problem solved by this, or is it just nice? # Make tar archive

Re: rules, rules, and more (code policy) rules

Jim Meyering [EMAIL PROTECTED] writes: For example, here's the change I've just made so that the rule works even when gzip doesn't support the --rsyncable option: Thanks. That reminds me, I had made several changes to Bison's Makefile.maint (one of which did something similar for --rsyncable,

Re: rules, rules, and more (code policy) rules

Paul Eggert [EMAIL PROTECTED] wrote: 2006-02-10 Paul Eggert [EMAIL PROTECTED] * Makefile.maint (CVS_LIST): Don't assume cvsu is available. (CVS_LIST_EXCEPT): New macro, to simplify exception-processing. Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT. ... Thanks for