According to Ian Beckwith on 1/6/2010 6:05 PM: > Hi, > > select (LGPLv2+) and nanosleep (GPL) both need a dependency on > sockets (LGPLv2+).
nanosleep already depends on select. And: ./gnulib-tool --with-tests --test select already pulls in sockets as one of its indirect dependencies. Oh, I see. sockets is only coming in as a dependency of select-tests, not select. But select.m4 definitely uses gl_SOCKETS, which is only provided by sockets. So --with-tests was masking the bug. Pushing this: -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net
From 654c876d285ca580043bf3074f7f66128b08bad0 Mon Sep 17 00:00:00 2001 From: Eric Blake <e...@byu.net> Date: Wed, 6 Jan 2010 19:44:15 -0700 Subject: [PATCH] select: add missing dependency * modules/select-tests (Depends-on): Move sockets dependency... * modules/select (Depends-on): ...here. Reported by Ian Beckwith. Signed-off-by: Eric Blake <e...@byu.net> --- ChangeLog | 5 +++++ modules/select | 1 + modules/select-tests | 1 - 3 files changed, 6 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 367a97f..715826f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2010-01-06 Eric Blake <e...@byu.net> + select: add missing dependency + * modules/select-tests (Depends-on): Move sockets dependency... + * modules/select (Depends-on): ...here. + Reported by Ian Beckwith. + doc: regenerate INSTALL * doc/INSTALL: Reflect recent autoconf update. * doc/INSTALL.ISO: Likewise. diff --git a/modules/select b/modules/select index dbdaa72..18865f1 100644 --- a/modules/select +++ b/modules/select @@ -7,6 +7,7 @@ m4/select.m4 Depends-on: alloca +sockets sys_select configure.ac: diff --git a/modules/select-tests b/modules/select-tests index fff6ec3..6635e80 100644 --- a/modules/select-tests +++ b/modules/select-tests @@ -15,7 +15,6 @@ extensions inet_pton errno perror -sockets socket bind setsockopt -- 1.6.4.2
signature.asc
Description: OpenPGP digital signature