On 12/11/2012 03:04 AM, Akim Demaille wrote:
> It fixed it for all the versions of GCC I have: warning-free
> compilation of lib/.
Thanks for checking it; I pushed that.
Le 10 déc. 2012 à 20:00, Paul Eggert a écrit :
> On 12/10/12 00:23, Akim Demaille wrote:
>> Maybe the non-inline branch should use __attribute__(__used__)?
>
> Sure, but you mean __unused__ not __used__, right?
Yep, sorry.
> Here's an updated proposal. All I did was add _GL_UNUSED in the
> t
On 12/10/12 00:23, Akim Demaille wrote:
> Maybe the non-inline branch should use __attribute__(__used__)?
Sure, but you mean __unused__ not __used__, right?
Here's an updated proposal. All I did was add _GL_UNUSED in the
two lines of the non-inline branch.
---
ChangeLog | 8
Le 9 déc. 2012 à 22:32, Paul Eggert a écrit :
> On 12/09/2012 07:46 AM, Akim Demaille wrote:
>> No, it does not. Actually, it breaks it completely.
>
> Ah, I expect it's because I forgot about the second branch in that #if.
> How about this patch instead?
Hi Paul,
Thanks for addressing this.
On 12/09/2012 07:46 AM, Akim Demaille wrote:
> No, it does not. Actually, it breaks it completely.
Ah, I expect it's because I forgot about the second branch in that #if.
How about this patch instead?
---
ChangeLog | 7 +++
m4/extern-inline.m4 | 16 +++-
2 files chang
Hi Paul,
Le 7 déc. 2012 à 18:37, Paul Eggert a écrit :
> If you're a Darwin user can you please report this bug?
Done, registered as "12841334".
> Also, does the following patch work around the problem for you?
> If so, I'll push it into gnulib.
No, it does not. Actually, it breaks it comple
On 12/07/2012 12:45 AM, Akim Demaille wrote:
> I don't understand
> why GCC does not accept that inline functions call static
> functions that are inline too.
The C Standard requires a diagnostic here, as the rule that you
quoted is a constraint. So this is really more a question for
the develop
Le 5 déc. 2012 à 17:19, Eric Blake a écrit :
> What I have instead done in libvirt to allow compilation with older gcc
> is the following:
>
># Gnulib uses '#pragma GCC diagnostic push' to silence some
># warnings, but older gcc doesn't support this.
>AC_CACHE_CHECK([whether pragma
Le 7 déc. 2012 à 01:18, Jim Meyering a écrit :
> Hi Akim,
>
> I've turned off -Wcast-qual warning for coreutils, grep, diffutils, etc.
> For us, that seems to be the best route, since we try hard not to
> add new casts (so there's little risk of introducing new violations),
> and since the few
Hi Paul,
Le 6 déc. 2012 à 18:48, Paul Eggert a écrit :
> In file included from ../../../lib/mbschr.c:23:0:
> ../../../lib/mbschr.c: At top level:
> ../../../lib/mbuiter.h:201:181: warning: '__inline_memset_chk' is static but
> used in inline function 'mbuiter_multi_copy' which is not static [en
Paul Eggert wrote:
...
> ../../../lib/basename-lgpl.c:50:10: warning: cast discards
> '__attribute__((const))' qualifier from pointer target type [-Wcast-qual]
>return (char *) base;
>
> This is harmless.
> Perhaps basename-lgpl.c should add a suitably-protected
> # pragma GCC diagnostic ignor
On 12/06/12 00:05, Akim Demaille wrote:
> Is there some documentation/page/whatever detailing the decisions
> (and their rationale) that gnulib has made with respect to compiler
> warnings?
I'm afraid not. It's haphazard and pretty much depends on the
compiler being used by the coreutils develope
Hi Paul!
Le 5 déc. 2012 à 17:58, Paul Eggert a écrit :
> On 12/05/2012 07:34 AM, Akim Demaille wrote:
>> I can't compile Bison with GCC 4.3 and 4.4 (newer ones seem to
>> be happy,
>
> When you say "can't compile", do you mean you mean the compilation
> fails? The diagnostics you sent all seem
On 12/05/2012 07:34 AM, Akim Demaille wrote:
> I can't compile Bison with GCC 4.3 and 4.4 (newer ones seem to
> be happy,
When you say "can't compile", do you mean you mean the compilation
fails? The diagnostics you sent all seemed to be just warnings.
On 12/05/2012 08:41 AM, Akim Demaille wrote
Hi Eric!
Le 5 déc. 2012 à 17:19, Eric Blake a écrit :
> I'm not sure if your patch is needed. Remember, newer gcc understands
> '#pragma GCC diagnostic push', but gcc 4.4 does not.
Actually, all the similar functions in this file do have
their prototype. See for instance xnrealloc which is
ri
On 12/05/2012 08:34 AM, Akim Demaille wrote:
> Hi friends,
>
> I can't compile Bison with GCC 4.3 and 4.4 (newer ones seem to
> be happy, I have not tried to understand why).
You may be hitting some of the problems with 'inline' that Paul has
recently been trying to fix, coupled with features lac
Hi friends,
I can't compile Bison with GCC 4.3 and 4.4 (newer ones seem to
be happy, I have not tried to understand why).
The attached patch fixes the issue.
There are also many warnings (see below for GCC 4.4), but I don't know if you
care.
Cheers!
Akim
gmake[3]: Entering directory
17 matches
Mail list logo
