Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Sat, May 09, 2009 at 12:13:01PM +0200, Richard van den Berg wrote: > On 5/9/09 9:14 AM, Frank Blendinger wrote: >> I'll talk to the mpd developers to see if they are willing to support >> RVA2/RGAD and/or APE tags. > > I used mpd before switching to a Squeezebox. IIRC it is written in perl. >

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Sat, May 09, 2009 at 05:29:50PM +0200, Richard van den Berg wrote: > Since you already came to the conclusion that mp3gain is about the only > implementation of the Replay Gain algorithm, I'm sure it uses 89dB as > well. From mp3gain.c: > >> /* the TAG version of the suggested Track Gain sho

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Sat, May 09, 2009 at 06:37:19PM +0200, Richard van den Berg wrote: > On 5/9/09 6:01 PM, H. Langos wrote: >> The volume attribute however is limited in its scale. it can only go from >> -100% to +100%. The lower bound is ok as it represents silence, but the >> upper bound is BS as it only allows

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 6:01 PM, H. Langos wrote: The volume attribute however is limited in its scale. it can only go from -100% to +100%. The lower bound is ok as it represents silence, but the upper bound is BS as it only allows gains of 6dB. Very good point, I didn't think of that. Quite a shame to li

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
Hi Frank, On Fri, May 08, 2009 at 12:14:53PM +0200, Frank Blendinger wrote: > > On Thu 2009-05-07 21:16, Richard van den Berg > proclaimed: > > On 5/7/09 5:06 PM, H. Langos wrote: > >> What's important is the fact that there seems to be a standard that defines > >> how volume adjustment data can

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 4:41 PM, H. Langos wrote: Well, the gain is given in dB relative to a reference level that most times is 83dB (But sometimes might be 89dB. The nasty details are here: http://www.mars.org/mailman/public/mad-dev/2004-February/000993.html ) I assume that mp3gain uses 83dB. But it wouldn't

Re: [Bug-gnupod] DESC field in iTunesDB / lyrics display

2009-05-09 Thread H. Langos
On Sat, May 09, 2009 at 04:03:09PM +0200, Richard van den Berg wrote: > On 5/9/09 3:52 PM, H. Langos wrote: >>> I forced the lyrics_flag to 1 in mk_mhit() but I still don't see the >>> description. Pressing the center button I still cycle through: >>> >>> volume -> position -> artwork -> rating >

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
Sorry about that. It's fixed now. cheers -henrik On Sat, May 09, 2009 at 01:04:15PM +0200, Richard van den Berg wrote: > On 5/8/09 2:26 PM, H. Langos wrote: >> BTW: I just added XRVA support as it is a too simple to let it pass. >> > > Always test before commit. ;-) > > Global symbol "%hs" req

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Fri, May 08, 2009 at 04:16:45PM +0200, Richard van den Berg wrote: > On 5/8/09 2:26 PM, H. Langos wrote: >> Yeap. And if mp3gain can't be changed to do write RVA2 tags by itself, >> maybe there is a way to make mp3gain only do the analysis and pass its >> result to a programm that can write th

Re: [Bug-gnupod] DESC field in iTunesDB

2009-05-09 Thread Richard van den Berg
On 5/9/09 3:52 PM, H. Langos wrote: I forced the lyrics_flag to 1 in mk_mhit() but I still don't see the description. Pressing the center button I still cycle through: volume -> position -> artwork -> rating strange. which generation ipod is that? http://support.apple.com/kb/HT1353

Re: [Bug-gnupod] DESC field in iTunesDB

2009-05-09 Thread H. Langos
On Fri, May 08, 2009 at 12:54:33PM +0200, Richard van den Berg wrote: > On 5/8/09 11:51 AM, H. Langos wrote: >> Smart playlists can have a "desc" attribute? I didn't know that. Does >> tunes2pod retain it? If so, could you send me the relevant lines from >> your >> GNUtunesDB.xml ? I will probab

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 9:14 AM, Frank Blendinger wrote: [...] gnupod_convert_OGG.pl uses Ogg::Vorbis::Header which may or may not support the RG tags. If you send me an ogg file (privately) that contains RG info I can check (and patch gnupod_convert_OGG.pl). I've sent you a private mail on this, it

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/8/09 2:26 PM, H. Langos wrote: BTW: I just added XRVA support as it is a too simple to let it pass. Always test before commit. ;-) Global symbol "%hs" requires explicit package name at /opt/local/lib/perl5/5.8.9/darwin-2level/GNUpod/FileMagic.pm line 542. $hs{RVA2} = $hs->{XRVA} if

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 9:14 AM, Frank Blendinger wrote: I'll talk to the mpd developers to see if they are willing to support RVA2/RGAD and/or APE tags. I used mpd before switching to a Squeezebox. IIRC it is written in perl. If they are using MP3::Info adding APE support is easy; just add an extra option

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Frank Blendinger
Hello Richard. On Fri 2009-05-08 13:30, Richard van den Berg proclaimed: > On 5/8/09 12:14 PM, Frank Blendinger wrote: >> You might want to take a look at this python script: >> http://mpd.wikia.com/wiki/Hack:ape2id3.py >> >> It will read the ReplayGain settings from APE tags and add it to ID3v2