[bug #34490] -[NSWorkspace open*] native system integration

2011-10-22 Thread julian
Follow-up Comment #14, bug #34490 (project gnustep): should have clarified, new patch still uses ShellExectureW() on WIN32 and NSTask/xdg-open elsewhere ___ Reply to this item at: __

[bug #34490] -[NSWorkspace open*] native system integration

2011-10-22 Thread julian
Follow-up Comment #13, bug #34490 (project gnustep): >regarding system(), I think the main problem is format string vulnerability well i am not sure this is a real problem, also validating the string shouldn't be hard but i've updated the patch to use NSTask btw. if the code you talked about i

[bug #34490] -[NSWorkspace open*] native system integration

2011-10-22 Thread Eric Wasylishen
Follow-up Comment #12, bug #34490 (project gnustep): ShellExecuteW() sounds like the right choice on win32 to me. regarding system(), I think the main problem is format string vulnerability… i.e. a malicious user sends you a file with a specially-consturcted filename and tells you to open it, and

[bug #34490] -[NSWorkspace open*] native system integration

2011-10-22 Thread julian
Follow-up Comment #11, bug #34490 (project gnustep): hmmm. i think the ShellExectureW() call is the *right* way to open a document/URL on windows, so it should work better than NSTask'ing "Explorer.exe /e" ... so porting the stuff to use NSTask would actually make it worse. (aren't there stripped

[bug #34490] -[NSWorkspace open*] native system integration

2011-10-22 Thread Eric Wasylishen
Follow-up Comment #10, bug #34490 (project gnustep): I wrote some code in gui for launching ghostscript using NSTask which could be borrowed for this (it handles searching through the PATH variable to find the requested executable, and handles the different PATH separators on win32 vs posix. Perha

[bug #34551] menus don't work when using os x 10.4 X11.app

2011-10-22 Thread Fred Kiefer
Follow-up Comment #1, bug #34551 (project gnustep): You will have to debug into the method [XGServer mouseLocationOnScreen:window:] to find out what is going on here. ___ Reply to this item at:

[bug #34490] -[NSWorkspace open*] native system integration

2011-10-22 Thread Fred Kiefer
Follow-up Comment #9, bug #34490 (project gnustep): I am willing to add a patch similar to this one. But like Richard I would prefer a solution that uses NSTask to start and external process. On Windows we could use the command "Explorer.exe /e, " followed by the file name to start the correspondi