Re: Changes in NSGeometry.m

do a cvs diff -u to get the diff against latest cvs in unified format. Unified diffs give more context information on the changes allowing the patches to be much more forgiving when applying agsinst modified files as well as easier to review. Cheers, Andy -- Andrew Ruder [EMAIL PROTECTED

PATCH: incorrect memcpy use

at a time and the use of memcpy seems to suggest that that couldn't happen. See what you think, and please apply. Thanks, Andrew Ruder portpatch.diff.gz Description: GNU Zip compressed data ___ Bug-gnustep mailing list [EMAIL PROTECTED] http://lists.gnu.org

NSPrintPanel.m

The connections made by the .gorm file as well as _savePath need to be released. Thanks -- Andrew Ruder 159a160,167 - (void) dealloc { RELEASE(_accessoryView); RELEASE(_savePath); RELEASE(_optionPanel); [super dealloc]; } ___ Bug

Very minor touchup

@private; was changed to @private in two different files. (Like I said, very minor, but not 'correct') Thanks -- Andrew Ruder --- NSComboBoxCell.h2002-12-23 17:18:05.0 -0600 +++ NSComboBoxCell.h.new2003-07-21 00:32:58.0 -0500 @@ -44,7 +44,7 @@ float

NSWindowController

of _document can't just be put in the dealloc method or is it more involved than that? (I'm not seeing any reason why not right away here...) -- Andrew Ruder ___ Bug-gnustep mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-gnustep

NSBundleAdditions.m

to be used, it could have). Clears up lots of double retains and releases _parentClassName in the dealloc methods. Thanks -- Andrew Ruder --- NSBundleAdditions.m 2003-07-21 03:43:39.0 -0500 +++ NSBundleAdditions.m.new 2003-07-21 03:42:51.0 -0500 @@ -763,6 +763,7 @@ - (void

NSMenuView.m

releases attr Thanks -- Andrew Ruder --- NSMenuView.m2003-07-21 03:12:07.0 -0500 +++ NSMenuView.m.new2003-07-21 03:10:55.0 -0500 @@ -1410,6 +1410,7 @@ - (void) dealloc { + RELEASE (attr); RELEASE (button); [super dealloc

NSSelection.m

Needed a dealloc routine Thanks -- Andrew Ruder --- NSSelection.m 2003-07-21 02:52:08.0 -0500 +++ NSSelection.m.new 2003-07-21 02:50:47.0 -0500 @@ -176,6 +176,14 @@ return self; } +- (void) dealloc +{ + RELEASE(_descriptionData); + + [super dealloc

GSServicesManager.m

This patch may be all-together unnecessary, but seems to maintain the ownership paradigm of OpenStep more correctly, and may safeguard against some unexpected happenings. Thanks. -- Andrew Ruder --- GSServicesManager.m 2003-07-21 03:55:58.0 -0500 +++ GSServicesManager.m.new 2003-07

GSMemoryPanel.m

Since it seems to be possible to create a GSMemoryPanel besides the shared one on the info panel, this class should probably have a dealloc method. Thanks -- Andrew Ruder --- GSMemoryPanel.m 2003-07-21 04:27:13.0 -0500 +++ GSMemoryPanel.m.new 2003-07-21 04:26:36.0 -0500

NSInputManager.m

_pendingKeyEvents needs to be released Thanks -- Andrew Ruder --- NSInputManager.m2003-07-21 04:32:17.0 -0500 +++ NSInputManager.m.new2003-07-21 04:31:30.0 -0500 @@ -473,6 +473,7 @@ - (void) dealloc { + RELEASE (_pendingKeyEvents); RELEASE (_rootBindingTable

NSOpenPanel.m

_fileTypes is retained but not released. thanks -- Andrew Ruder --- NSOpenPanel.m 2003-07-21 04:35:14.0 -0500 +++ NSOpenPanel.m.new 2003-07-21 04:34:46.0 -0500 @@ -282,8 +282,11 @@ return self; } -// dealloc is the same as NSSavePanel - +- (void)dealloc

Re: NSFileWrapper dealloc routine

On Mon, Jul 21, 2003 at 12:23:02AM -0500, Andrew Ruder wrote: Doesn't seem to call [super dealloc] in its dealloc routine. Unless someone knows of an obvious reason why it shouldn't do that, this patch should probably be applied. Thanks -- Andrew Ruder Going through this file again

NSWindow question

. Thanks -- Andrew Ruder --- NSWindow.m 2003-07-21 04:51:55.0 -0500 +++ NSWindow.m.new 2003-07-21 04:48:27.0 -0500 @@ -681,6 +681,8 @@ TEST_RELEASE(_defaultButtonCell); TEST_RELEASE(_cachedImage); TEST_RELEASE(_toolbar); + DESTROY(_lastView); + DESTROY(_lastDragView

Re: NSWindow question

are only destroyed, never just released. In this case, it would be safe to destroy them in the dealloc, regardless if its needed or not. -- Andrew Ruder ___ Bug-gnustep mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-gnustep

NSCursor.m

Adds a dealloc method for the _cursor_image variable. Fixes one of those retaining a autoreleased object issues. Thanks -- Andrew Ruder --- NSCursor.m 2003-07-21 15:55:47.0 -0500 +++ NSCursor.m.new 2003-07-21 15:53:58.0 -0500 @@ -62,7 +62,7 @@ NSCursor_class = self

NSResponder.m

_menu needs to be released. Added dealloc method. Thanks -- Andrew Ruder --- NSResponder.m.old 2003-07-22 00:55:33.0 -0500 +++ NSResponder.m 2003-07-21 16:44:30.0 -0500 @@ -332,7 +332,11 @@ return self; } - +- (void) dealloc +{ + RELEASE(_menu); + [super dealloc

Memory leaks

Ok, I'm pretty sure this patch gets rid of about 40~ cases of bad memory management in NSBundleAdditions.m Please look at patch before applying. Thanks -- Andrew Ruder 766a767 RELEASE(_parentClassName); 776d776 RETAIN(_className); 778d777 RETAIN(_parentClassName); 844d842 RETAIN

Off by 1 problem

encodings are supported. Or at least afaict. -- Andrew Ruder ___ Bug-gnustep mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-gnustep

Re: NSTextField problems

I've been unable to reproduce any of this. In what app can you reproduce it, and how? Does that app do anything special with the text network or text field? TalkSoup exhibits this behavior as well. - Andy Ruder ___ Bug-gnustep mailing list