Re: Fix, NSView (-releaseGState)

2010-09-23 Thread Georg Fleischmann
moves to another window. Application code will have to set this again. Fred Am 13.09.2010 10:05, schrieb Georg Fleischmann: Hi Fred, if (_gstate) if (_window) GSUndefineGState([_window graphicsContext], _gstate); _gstate = 0; I added this at the beginning of _viewWillMoveToWindow

Fix GDL2, EONotQualifier (-sqlStringForSQLExpression:)

2010-09-16 Thread Georg Fleischmann
here is another fix, which I seem to have forgotten to send last year. It's fixing an infinite loop / stack overflow in EOSQLQualifier.m, [EONotQualifier (EOQualifierSQLGeneration) -sqlStringForSQLExpression:]. The method needs to pass _qualifier as parameter, not self. Otherwise it will be

Re: Fix, NSView (-releaseGState)

2010-09-13 Thread Georg Fleischmann
else on this list, see any problem with that change? Fred Am 11.09.2010 12:24, schrieb Georg Fleischmann: here is a small patch for NSView (SVN 2010-09-10 and before) to prevent a crash in Cenon when closing a Graphic Window. The same code of Cenon works on Apple, so I suspect it's

Fix, NSView (-releaseGState)

2010-09-11 Thread Georg Fleischmann
not deep enough into that to have any idea. I also add the stack of the situation. Best wishes, Georg Fleischmann *** Source/NSView.m.old 2010-09-04 13:30:30.0 +0800 --- Source/NSView.m 2010-09-11 17:45:22.0 +0800 *** *** 2183,2189 */ - (void

Re: Fix, Base/GDL2 GSCompatibility.m (-boolValue)

2009-07-26 Thread Georg Fleischmann
wrote: Hey, Am Sonntag, den 26.07.2009, 11:10 +0800 schrieb Georg Fleischmann: I believe this is not correct. -boolValue is documented in Cocoa to do pretty much what the compatibility implementation does. So I believe the correct fix would be to simply remove our compatibility category

Re: Fix, Base/GDL2 GSCompatibility.m (-boolValue)

2009-07-25 Thread Georg Fleischmann
does it: #ifndef MAC_OS_X_VERSION_10_5 - (BOOL) boolValue { ... } #endif Best wishes, Georg On 25.07.2009, at 01:28, David Ayers wrote: Hello Georg, Am Freitag, den 17.07.2009, 10:50 +0800 schrieb Georg Fleischmann: here is a patch for Base to make GDL2 on Cocoa work with boolean values

Fix GDL2, EOSQLExpression (prepareSelectExpressionWithAttributes)

2009-07-24 Thread Georg Fleischmann
/EOSQLExpression ([EOSQLExpression - prepareSelectExpressionWithAttributes:]): set listString for flattened attributes with a definition like count (*) or sum(amount) * EOAccess/EOExpressionArray (EOExpressionArray - valueForSQLExpression:): use _infix instead of . Best wishes, Georg Fleischmann

GDL2, EOSQLQualifier Implementation

2009-07-23 Thread Georg Fleischmann
:] [EOSQLQualifier -sqlStringForSQLExpression:] [EOSQLQualifier -dealloc] implemented Best wishes, Georg Fleischmann *** EOAccess/EOSQLQualifier.m.old Sun Jul 19 12:18:00 2009 --- EOAccess/EOSQLQualifier.m Tue Jul 21 12:23:32 2009 *** *** 58,63 --- 58,64

Fix GDL2, EOSQLQualifier (EONotQualifier -schemaBasedQualifierWithRootEntity:)

2009-07-18 Thread Georg Fleischmann
(-sqlStringForNegatedQualifier:): get sqlStringForSQLExpression of the right qualifier Best wishes, Georg Fleischmann *** EOAccess/EOSQLQualifier.m.old Tue Jan 22 21:57:07 2008 --- EOAccess/EOSQLQualifier.m Sun Jul 19 12:16:11 2009 *** *** 495,505 - (EOQualifier

Fix, Base/GDL2 GSCompatibility.m (-boolValue)

2009-07-16 Thread Georg Fleischmann
here is a patch for Base to make GDL2 on Cocoa work with boolean values from EOModels. The boolean values in my EOModel files are stored as Y only, not a complete Yes ( allowsNull = Y; ). This (Y) works fine on a complete GNUstep system, but fails with the Compatibility code that is only

Fix, NSPrintOperation (-_print)

2009-07-13 Thread Georg Fleischmann
here is a small fix for printing of more than the first page. A MIN needs to be turned into a MAX. Best Wishes, Georg Fleischmann *** Source/NSPrintOperation.m.old 2009-03-13 14:31:29.0 +0800 --- Source/NSPrintOperation.m 2009-07-14 11:46:42.0 +0800

NSPrintOperation (-_printPaginateWithInfo:knowsRange:)

2009-07-13 Thread Georg Fleischmann
, the Dictionary will return nil and the doubleValue ends up undefined or 0. It should be 1.0. I suggest something like: if ([dict objectForKey: NSPrintScalingFactor]) info-printScale = [[dict objectForKey: NSPrintScalingFactor] doubleValue]; else info-printScale = 1.0; Best wishes, Georg

NSTextView -initWithCoder, recent changes not working

2009-06-28 Thread Georg Fleischmann
:3588 #6 0xb7cb0933 in -[NSApplication sendEvent:] (self=0x84a5eb0, _cmd=0x825c898, theEvent=0x97d5948) at NSApplication.m:1963 ... All of this worked before the change. Best wishes, Georg Fleischmann 2009-05-23 11:48-EDT Gregory John Casamento greg.casame...@gmail.com * Source

Re: Fix, Base, NSKeyValueCoding (SetValueForKey())

2009-06-23 Thread Georg Fleischmann
about my patch. However, you are correct, Cocoa does not have an ivar named _infoPanel in NSApplication. Will this be changed in GNUstep? Best wishes, Georg Fleischmann $1 = { isa = 0x442e0, _nextResponder = 0x0, _currentEvent = 0x8c2be30, _windowList = 0x452404, _keyWindow

Fix, Base, NSXMLParser (SetValueForKey())

2009-06-23 Thread Georg Fleischmann
including newline characters. I'm not aware of any side effects. Best wishes, Georg Fleischmann *** Source/NSXMLParser.m.old2009-05-12 13:30:54.0 +0800 --- Source/NSXMLParser.m2009-06-23 17:39:01.0 +0800 *** *** 1235,1240 --- 1235,1241

Fix, Base, NSKeyValueCoding (SetValueForKey())

2009-06-22 Thread Georg Fleischmann
in GNUstep. Best wishes, Georg Fleischmann *** Source/NSKeyValueCoding.m.old 2009-02-28 14:31:08.0 +0800 --- Source/NSKeyValueCoding.m 2009-06-23 11:28:56.0 +0800 *** *** 116,143 if ([[self class] accessInstanceVariablesDirectly] == YES

Fix, Base, NextStep encoding table

2009-05-31 Thread Georg Fleischmann
(0xFB plus the NextStep value). This makes the table sorted correctly. Best wishes, Georg Fleischmann *** Source/Additions/unicode/nextstep.h.old 2009-05-31 15:25:06.0 +0800 --- Source/Additions/unicode/nextstep.h 2009-05-31 15:30:35.0 +0800 *** *** 51,58

Fix, GDL2, PostgreSQLExpression (+formatValue:forAttribute:)

2009-05-31 Thread Georg Fleischmann
FROM unique_key t0 WHERE t0.entity_name = 'serial\_number' WARNING: nonstandard use of escape in a string literal LINE 1: ...ty_name FROM unique_key t0 WHERE t0.entity_name = 'serial \_n... Best wishes, Georg Fleischmann *** EOAdaptors/PostgreSQLAdaptor/PostgreSQLExpression.m.old 2008-04-04

Re: Fix, GDL2, EORelationship (-validateName:)

2008-05-01 Thread Georg Fleischmann
definition for '- _hasAnyAttributeNamed:' not found Best wishes, Georg Fleischmann On 30.04.2008, at 22:27, Matt Rice wrote: On Mon, Apr 28, 2008 at 11:56 PM, David Ayers [EMAIL PROTECTED] wrote: Hello Georg, Thanks for the report! Georg Fleischmann schrieb: here is a patch

Fix, GDL2, EORelationship (-validateName:)

2008-04-28 Thread Georg Fleischmann
an argument with the same name. Best wishes, Georg Fleischmann *** EOAccess/EORelationship.m.old Wed Mar 12 14:30:36 2008 --- EOAccess/EORelationship.m Mon Apr 28 16:27:05 2008 *** *** 1178,1186 *p] userInfo

Fix, GDL2, EOEntity (debug logging)

2008-04-28 Thread Georg Fleischmann
Hello, here are two small fixes in EOEntity for debug logging. The fix uses [dictionaryForPrimaryKey debugDescription] for logging, for the default (-description) will throw an exception (on Mac OS X) if the dictionary contains null entries. Best wishes, Georg Fleischmann *** EOAccess

Fix GDL2, PostgreSQLExpression (+formatValue:forAttribute:): writing of escaped strings

2008-04-02 Thread Georg Fleischmann
. Best wishes, Georg Fleischmann vhf interservice GmbH *** EOAdaptors/PostgreSQLAdaptor/PostgreSQLExpression.m.old Sun Dec 31 09:32:05 2006 --- EOAdaptors/PostgreSQLAdaptor/PostgreSQLExpression.m Mon Mar 31 14:21:18 2008 *** *** 97,103 NSString *formatted = nil

gnumake 2.0.0 issues....

2007-10-25 Thread Georg Fleischmann
-back.spec.in 2. Only very few of the GNUstep applications that were around still compile without changes. Mostly because the GNUSTEP_INSTALLATION_DIR is not supported any more. Best wishes, Georg Fleischmann ___ Bug-gnustep mailing list Bug-gnustep

Re: Fix, GMAppKit - Image loading

2006-11-16 Thread Georg Fleischmann
On Nov 9, 2006, Adam Fedor wrote: Look OK to me. Could you add the patch for me ? Best wishes, Georg ___ Bug-gnustep mailing list Bug-gnustep@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnustep

Fix, GMAppKit - Image loading

2006-11-05 Thread Georg Fleischmann
auto-compressed every day anew. Is this not supported any more? Best wishes, Georg 2005-11-11 Georg Fleischmann * gui/Model/GMAppKit.m [NSImage +createObjectForModelUnarchiver:] allow loading of images from the owners bundle *** gui/Model/GMAppKit.m.old2005-07-22 17:15

Fix, NSMatrix -deselectAllCells

2006-01-13 Thread Georg Fleischmann
row/column is within the allowed range. Best wishes, Georg 2006-01-13 Georg Fleischmann * gui/Source/NSMatrix.m [NSMatrix -deselectAllCells]: set _selectedRow/_selectedCol = -1 for an empty matrix, even if empty selection is not allowed. *** gui/Source

Fix, NSSliderCell - knob resizing

2005-11-13 Thread Georg Fleischmann
Hi, here is another little patch adding just two lines to allow resizing the knob of a slider. The knob image needs a [image setScalesWhenResized:YES] to allow scaling the image. Best wishes, Georg 2005-11-13 Georg Fleischmann * gui/Source/NSSliderCell.m [NSSliderCell

Fix, GMAppKit - Image loading

2005-11-11 Thread Georg Fleischmann
Hi, here is a patch for GMAppKit to allow loading of images from the owners bundle (not just the main bundle). Best wishes, Georg 2005-11-11 Georg Fleischmann * gui/Model/GMAppKit.m [NSImage +createObjectForModelUnarchiver:] allow loading of images from the owners bundle

Re: Fix, GMAppKit - Image loading

2005-11-11 Thread Georg Fleischmann
Hi Fred, could you just explain shortly why this patch is needed and also why this is not a general problem of the way [NSImage imageNamed:] is implemented? We are using imageNamed: for the GORM encoding as well, so if this is a general problem it should be fixed for this as well. Yes this

Fix, NSButtonCell / GMAppKit

2005-02-05 Thread Georg Fleischmann
to live with or without setting the title to nil. Georg 2005-02-05 Georg Fleischmann * gui/Model/GMAppKit.m [NSButtonCell -initWithModelArchiver:] set button title after setting image position to safe the title *** gui/Model/GMAppKit.m.old2005-02-05 14:58:07.0

Re: ANN: nib2gmodel version 0.9.0

2004-10-13 Thread Georg Fleischmann
Hi Adam, I want to make a few other changes then I'll probably package it up and have you try it out again... Ok. I also got an exception with popup buttons (on OpenStep) and now figured out how to fix it. Attached is the exception I got and the patch. [[self selectedItem] title] works, but

Patch to add new class method: [NSTimeZone +knownTimeZoneNames]

2004-10-07 Thread Georg Fleischmann
I implemented the method [NSTimeZone +knownTimeZoneNames] from the Apple specs. Here are the small patches to NSTimeZone.h and m. Georg 2004-10-07 Georg Fleischmann * base/Source/NSTimeZone.m +knownTimeZoneNames added *** base/Headers/Foundation/NSTimeZone.h.old2003

Re: Fix, NSTimeZone Abbreviations

2004-10-06 Thread Georg Fleischmann
That list cant be right - it's missing BST (British Summer Time = GMT+1) for starters. But if I print [NSTimeZone localTimeZone] on the Mac in front of me then it tells me that it is in BST, so preseuably OSX is quite happy to take that ? That's what I got returned on Mac OS-X and OpenStep

Fix, NSBitmapImageRep.h (NSTIFFCompression)

2004-10-05 Thread Georg Fleischmann
Hi, here is patch for NSTIFFCompression, to make it compatible to OpenStep/Cocoa. Georg 2004-10-05 Georg Fleischmann * gui/Headers/NSBitmapImageRep.h make NSTIFFCompression compatible with OpenStep/Cocoa *** gui/Headers/AppKit/NSBitmapImageRep.h.old 2003-09-08 04:07

Fix, NSCalendarDate (-initWithString:)

2004-10-05 Thread Georg Fleischmann
of the abbreviation, if available. Fixing this would be correct anyway. Probably both should be done. Georg 2004-10-05 Georg Fleischmann * base/Source/NSCalendarDate.m [-initWithString:] return to previous code, and try to load time zone abbreviation from name, first. *** base

Fix, NSTimeZone Abbreviations

2004-10-05 Thread Georg Fleischmann
Hi, I realized that the list of time zone abbreviations coming with GNUstep is very long and all keys are used multiple times. The dictionary generated for mapping uses the first match from the file, which would map CET to Africa (which would map back to WET). This is wrong, of course. The

Re: ANN: nib2gmodel version 0.9.0

2004-09-28 Thread Georg Fleischmann
Hi Adam, downloaded the new nib2gmodel. The link on the download page is missing a slash after gnustep: ftp://ftp.gnustep.org/pub/gnustepdev-apps/ (on this page: http://wwwmain.gnustep.org/resources/downloads.php?site=ftp%3A%2F%2Fftp.gnustep.org%2Fpub%2Fgnustep) Here are my compiling

Fix, NSCalendarDate

2004-04-10 Thread Georg Fleischmann
Hi, here is a little fix for NSCalendarDate. It avoids exceptions, when the time zone is created from an abbreviation. Georg 2004-04-11 Georg Fleischmann * base/Source/NSCalendarDate.m [NSCalendarDate initWithString:calendarFormat:locale:]: avoid exception

Re: Fix, NSLayoutManager

2004-03-15 Thread Georg Fleischmann
Alexander Malmberg wrote: However, in the original patch, the wrap-around is just ugly; it isn't really a problem since the wrap-around behavior of unsigned ints is defined by the c standard. It may not please the educated eye, but it works :-) Also, the patch doesn't need a cast which would

Re: Fix, NSView (Text Rotation)

2004-03-14 Thread Georg Fleischmann
Pete French wrote: I use rotated text a lot - I'll try and find some time to test these patches (though I hadnt really had any problems with rotated text anyway) Cenon uses a flipped view to display rotated text. Georg ___ Bug-gnustep mailing list

Fix, NSAffineTransform (Text Rotation)

2004-03-13 Thread Georg Fleischmann
Hi, here is the second patch to make text rotation work. It is for NSAffineTransform -rotationAngle. The patch just corrects the sign of the angle and always returns positive angles. Georg 2004-03-14 Georg Fleischmann * gui/Source/NSAffineTransform.m [NSView rotationAngle

Fix, NSView (Text Rotation)

2004-03-13 Thread Georg Fleischmann
text was clipped from the screen. The second problem was in lockFocusInRect. There was an extra function call just for rotated views, which only destroyed the rect. I only tested text rotation with Cenon, as I'm not aware of any other application using rotated text. Georg 2004-03-14 Georg

Fix, NSLayoutManager

2004-03-11 Thread Georg Fleischmann
Hi, here is a little patch for the NSLayoutManager fixing a problem with layout_char. layout_char is unsigned but may become negative, thus flipping over to huge positive. The huge positive value then is not sattisfying the '' comparison. Georg 2004-03-10 Georg Fleischmann * gui

Re: Fix, NSFont, XGFont (was RTFConsumer)

2002-10-10 Thread Georg Fleischmann
Most of this patch looks fine for me. What is missing is the special handling now needed for the getNSFont() function. Here we should make sure, that we always return a usefull font. As the only font we can be sure about is the user font in the default size we should return this, if any

Fix: NSWindow, constrainFrameRect

2002-10-09 Thread Georg Fleischmann
2002-08-30 Georg Fleischmann * gui/Source/NSWindow.m [-constrainFrameRect]: move window inside screen, if window top is below screen *** gui/Source/NSWindow.m.old Sun Oct 6 19:27:30 2002 --- gui/Source/NSWindow.m Wed Oct 9 18:57:44 2002

Fix, NSFont, XGFont (was RTFConsumer)

2002-10-09 Thread Georg Fleischmann
NSFontManager's -convertFont methods work as they should. All seems to work fine - I got no crash :-) My suggested RTFConsumer changes work much better, too. I will send the RTFConsumer patch in a separate mail with some additional comments. Georg 2002-10-09 Georg Fleischmann * gui/Source

Fix: RTFConsumer, -currentFont

2002-10-09 Thread Georg Fleischmann
with the desired family. So this approach seems a lot more tolerant to me. Maybe there is yet another and better way, but I have no idea at the moment. Georg 2002-10-09 Georg Fleischmann * gui/TextConverters/RTF/RTFConsumer.m [-currentFont]: allow composite font names like

Re: Fix: RTFConsumer, -currentFont

2002-09-05 Thread Georg Fleischmann
On my CVS I've got the following - which definitely creates the fonts using -initWithName:matrix: - since -initWithName:matrix: will never return nil, fontWithName:matrix: will never know if the font is available or not, and can't return nil. My mistake, it's all correct. Georg

Re: Fix: RTFConsumer, -currentFont

2002-09-03 Thread Georg Fleischmann
Hi Nicola, What about taking a completely different approach in the method, and instead doing a [NSFont fontWithName: fontName size: fontSize]; Well, this brought up a problem with [NSFont fontWithName:size:]: If the desired font is not available, the method returns a default font

Fix: RTFConsumer, -currentFont

2002-08-30 Thread Georg Fleischmann
Hi, here is a fix which corrects the RTFConsumer to return the correct font for composite fontNames such as Futura-Light or Futura-Book. Georg 2002-08-30 Georg Fleischmann * gui/TextConverters/RTF/RTFConsumer.m [-currentFont]: allow composite font names like 'FontFamily

Re: Fix: NSWindow, setFrameFromString and stringWithSavedFrame

2002-08-03 Thread Georg Fleischmann
Hi Nicola, I don't have an openstep system (nor a macosx) to test what actually happens in other systems - can someone else confirm that we really need to change the way we convert window frames into strings in order to be compatible ? I checked on Mac OS X, and it saves the lower/left

Fix: NSWindow, setFrameFromString and stringWithSavedFrame

2002-07-28 Thread Georg Fleischmann
Hi, I noticed that GNUstep uses flipped coordinates for the frame string in -setFrameFromString and -stringWithSavedFrame. On OpenStep the methods use normal coordinates. The attached patch removes the flipping. Georg 2002-07-28 Georg Fleischmann * gui/Source/NSWindow

Bug in Alpha compositing

2002-07-17 Thread Georg Fleischmann
Hi, I realized a new bug with alpha compositing. I found out that the problem appeared with the changes in XGGState.m -setColor:state: and -setAlphaColor: in May. If I use an earlier version of XGGState.m it works. As I don't have an idea of the changes and not much time at the moment, I

Re: Fix: NSMenu.m, -performActionForItemAtIndex:

2002-06-14 Thread Georg Fleischmann
Hi Nicola, thanks - looking at the code and API, wouldn't maybe be better that -performActionForItemAtIndex: does not perform any highlighting, and the caller performs it instead ? do you think it would be a good change ? The performAction is called from [NSMenuView -trackWithEvent:] (for

Fix: NSMenu.m, -performActionForItemAtIndex:

2002-06-11 Thread Georg Fleischmann
Hi again, here is a patch for PopUp Menus, which selects the item also for actions send from the item (not only for actions send by the popUpButtonCell). That's it. Thanks for the Color-Panel, that's a great improvement :-) Georg 2002-06-11 Georg Fleischmann * gui/Source/NSMenu.m

Fix: NSMenuView.m, -itemAdded:

2002-06-11 Thread Georg Fleischmann
here is a patch for NSMenuView to highlight/unhighlight the items correctly, when an item is added. Georg 2002-06-11 Georg Fleischmann * gui/Source/NSMenuView.m [NSMenuView -itemAdded:]: highlighting corrected *** gui/Source/NSMenuView.m.old Tue Jun 11 21:36:51 2002

Fix: XGServerWindow.m, -windowDevice:

2002-06-11 Thread Georg Fleischmann
and finally replaced the hack with a usleep(1) - that did it :-) Georg 2002-06-11 Georg Fleischmann * back/Source/x11/XGServerWindow.m [XGServerWindow windowDevice]: use usleep(1) to wait for X Server *** back/Source/x11/XGServerWindow.m.oldTue Jun 11 20:46:25 2002

Fix: GMAppKit.m (NSCell), -encodeWithModelArchiver:

2002-06-07 Thread Georg Fleischmann
pass. Georg 2002-06-07 Georg Fleischmann * gui/Model/GMAppKit.m [NSCell -encodeWithModelArchiver:]: restore sendActionMask *** gui/Model/GMAppKit.m.oldWed Apr 24 15:37:45 2002 --- gui/Model/GMAppKit.mThu Jun 6 19:52:47 2002 *** *** 229,235

Fix: NSControl.m, -mouseDown:

2002-06-07 Thread Georg Fleischmann
Hi, here is another patch to make continuous buttons/controls work. I just switched the if/else, so the NSPeriodicMask is set for continuous cells. Georg 2002-06-07 Georg Fleischmann * gui/Source/NSControl.m [NSControl -mouseDown:]: set NSPeriodicMask for continuous cells

Fix, GSSimpleLayoutManager

2002-05-17 Thread Georg Fleischmann
Hi, here are some small fixes for GSSimpleLayoutManager which check the array count of _lineLayoutInformation before accessing the array. The modifications allow (for example) a text box of zero size without getting an exception. Georg 2002-05-17 Georg Fleischmann * gui/Source

Fix, NSPrintOperation

2002-05-14 Thread Georg Fleischmann
of the file is needed earlier in deliverResults. The patch adds a local AutoreleasePool for the EPS context to get rid of the autorelease. Georg 2002-05-13 Georg Fleischmann * gui/Source/NSPrintOperation.m [NSPrintOperation(GSEPSPrintOperation) -createContext:]: add

Fix: GMAppKit.m for NSMenuItem

2002-04-21 Thread Georg Fleischmann
for submenu before setting the submenu would work too. Georg 2002-04-21 Georg Fleischmann * gui/Model/GMAppKit.m [NSMenuItem initWithModelUnarchiver:]: setAction after setSubmenu. *** gui/Model/GMAppKit.m.oldSun Apr 21 23:09:38 2002 --- gui/Model/GMAppKit.mSun

Re: NSApplication bug

2001-10-30 Thread Georg Fleischmann
I think we should verify how Blink works under MacOS-X and OPENSTEP to see if we need to generate an event to get the window updated. Here is a backstrace of a blinking cursor on OpenStep with a breakpoint in flushWindow (update is never called in this case). 'DocWindow' is a direct

Re: Fix: Printing

2001-10-04 Thread Georg Fleischmann
I added this patch although I completely rewrote the NSView changes. There's more that needs to be done when printing that just reseting the coordinates so I tried to account for that. It seemed to work for me but perhaps you can test it again. I finally tested the changes: The changes for

Fix: NSView, view clipping

2001-08-30 Thread Georg Fleischmann
. If someone has a better idea, I'm not angry at all. Georg 2001-08-31 Georg Fleischmann * gui/Source/NSView.m [NSView lockFocusInRect:]: DPSsave(ctxt) added [NSView unlockFocusWithFlush:]: DPSrestore(ctxt) added * gui/Headers/gnustep/gui/DPSOperators.h

Fix: NSCalendarDate, descriptionWithCalendarFormat:locale:

2001-08-28 Thread Georg Fleischmann
Hi, here is a little patch to make the millisec output of the description method work. Georg 2001-08-28 Georg Fleischmann * base/Source/NSCalendarDate.m [NSCalendarDate descriptionWithCalendarFormat:locale:]: make milliseconds works (%F) diff -u base/Source

Fix, NSBezierPath, appendBezierPathWithArc...

2001-08-01 Thread Georg Fleischmann
work at all. Georg 2001-08-01 Georg Fleischmann * gui/Source/NSBezierPath.m [NSBezierPath appendBezierPathWithArc...]: draw lineto to start point of arc diff -u gui/Source/NSBezierPath.m.old gui/Source/NSBezierPath.m --- gui/Source/NSBezierPath.m.old Sat May 19

XGGState, filled complex paths

2001-08-01 Thread Georg Fleischmann
. Only more complex paths use the new _doComplexPath method. I have created a screenshot which shows some paths: http://www.vhf.de/products/cenon/GNUstep1.jpg Georg 2001-08-01 Georg Fleischmann * xgps/Source/XGGState.m [XGGState _paintPath:]: more complex path handling added

Fix, NSWindow, constrain

2001-07-30 Thread Georg Fleischmann
think it would be correct to remove the constrain in [NSWindow setFrame:] too. 2001-07-30 Georg Fleischmann * gui/Source/NSWindow.m [NSWindow orderWindow:relativeTo:]: constrain added [NSWindow initWithContentRect:styleMask:backing:defer:screen:] and [NSWindow

Re: Fix, attributedStringConsumer

2001-07-30 Thread Georg Fleischmann
Hi Nicola, > sorry to be late in answering - can you send us a little RTF showing your > problem ? thanks. Here is an rtf stream containing just "text" and attached is the same as rtf file (both created on OpenStep). You can load the rtf file with Ink.app and should get the mentioned index out

Fix, NSWindow, initWithContentRect...

2001-07-27 Thread Georg Fleischmann
Hi, here is a little patch for NSWindows -initWithContentRect... to constrain the window frame to the screen. Otherwise a newly created window would never be checked against the screen. Georg 2001-07-27 Georg Fleischmann * gui/Source/NSWindow.m [NSWindow

Bug, application.make

2001-07-19 Thread Georg Fleischmann
Hi, Compiling todays snapshot (2001-07-19), I realized that the application makefile creates an error on my system: make[1]: Entering directory `/usr/local/src/GNUstep/core/gui/Model' /usr/GNUstep/System/Makefiles/application.make:61: *** missing separator. Stop. make[1]: Leaving directory

Re: Fix, IMConnectors, establishConnection

2001-04-12 Thread Georg Fleischmann
Hi Nicola, Ahm - I'm not convinced by the fix - but the problem is - I don't know exactly what problem you are having ! :-) Your right. Your fix looks much more promising, and in my tests it gives the same positive results. My problem was, that windows created from a gmodel file, were

Fix: NSView, setBoundsOrigin:

2001-04-09 Thread Georg Fleischmann
Hi, here is a patch for NSView to renew the gstate after setting a new origin. I hope it is useful ... Georg 2001-04-09 Georg Fleischmann * gui/Source/NSView.m [NSView setBoundsOrigin:]: renew gstate diff -u gui/Source/NSView.m.old gui/Source/NSView.m --- gui/Source

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter (2)

2001-03-06 Thread Georg Fleischmann
Hi Nicola, So - I'd rather propose the following change (I also added lots of comments to help future bug fixings) - if you can test it and it's Ok, we could use this one - I tested it: it doesn't do the job. startAngle = 0 endAngle = -450 clockwise it wouldn't work... it would draw a

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter (2)

2001-03-06 Thread Georg Fleischmann
Hi Nicola, Does this patch look right to you ? Absolutely, and it works for all I've tested. ...but I think the macos-x doc for NSBezierPath says that we should not draw the line in NSBezierPath. I need to look at it - but if the backend is using NSBezierPath to draw the arc, then what

Fix: NSBezierPath, appendBezierPathWithArcWithCenter (2)

2001-03-05 Thread Georg Fleischmann
mentioned. It also makes the code a little bit shorter. The problem was that circles (360 degree arcs) collapsed to zero in some cases. Georg 2001-03-05 Georg Fleischmann * gui/Source/NSBezierPath.m [NSBezierPath appendBezierPathWithArcWithCenter: ...]: Rearranged handling

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

2001-03-01 Thread Georg Fleischmann
Hi Nicola, Thanks - I read your patch and it made lot of sense - so I applied it. I did not test it nor did I check on books the formula used to build the bezier path for the last bit of the arc, so I hope you did. :-) Yes, I have tested it. Anyway, I had to realized another little problem

Fix: XGGState, DPSarc and DPSarcn

2001-02-27 Thread Georg Fleischmann
Hi, attached is a patch to make the radius of arcs scale. The fix is not perfect in that it still does not create ellipsis for unequal scale factors in x and y direction (if this case is needed at all). Anyway, I hope it helps. Georg 2001-02-27 Georg Fleischmann * xgps/Source/XGGState.m

Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

2001-02-26 Thread Georg Fleischmann
Hi, attached is a patch with a bunch of fixes for NSBezierPath to make arcs being displayed. With the patch arcs should now work in any direction and angle. I also added a few lines of discription which I found in the ghostscript code. Georg 2001-02-26 Georg Fleischmann * gui/Source

Fix: NSFormCell, copyWithZone:

2000-12-15 Thread Georg Fleischmann
Hi, here is a fix for NSFormCell (CVS 2000-12-15). It applies the recent changes of NSCell to NSFormCell too. Georg 2000-12-16 Georg Fleischmann * gui/Source/NSFormCell.m ([NSFormCell -copyWithZone:]): created to retain _titleCell *** gui/Source/NSFormCell.m.old Sat Dec

NSTabView, drawRect:

2000-11-22 Thread Georg Fleischmann
', instead of drawing to the origin of the bounds, and just using 'rect' to decide whether things have to be drawn at all. 'rect' just specifies the area which needs to be redrawn. I hope this helps to finally fix this little bug. Georg Fleischmann [EMAIL PROTECTED

Fix: NSTextView, setTextContainer:

2000-09-10 Thread Georg Fleischmann
Hi, here is a fix for NSTextView (cvs version from 2000-09-07): The patch just sets the textView for the textContainer. With the patch NSTextContainer will set itself as observer using the textView as notification object (not nil). 2000-09-10 Georg Fleischmann * gui/Source

Fix: NSMatrix (GMArchiverMethods)

2000-05-24 Thread Georg Fleischmann
Hello, here is a bug fix for unarchiving gmodels. It selects selected cells in the matrix too. 2000-05-24 Georg Fleischmann * gui/Model/GMAppKit.m ([NSScrollView(GMArchiverMethods) -initWithModelUnarchiver:]): select selected cells in matrix too *** gui/Model

Fix: NSTabView

2000-05-08 Thread Georg Fleischmann
Hello, here is a bug fix for NSTabView (latest snapshot 000508): 'tab_font' isn't retained, and -dealloc is missing completely. 2000-05-09 Georg Fleischmann * gui/Source/NSTabView.m ([-initWithFram:]): retain tab_font ([-dealloc]): new method diff -c gui/Source

NSConnection defaultConnection

2000-04-28 Thread Georg Fleischmann
Hello, In NSConnection.m, +(NSConnection*)defaultConnection 'newPort' is used uninitialized here. The following line (or something like that) should be added in line 305: newPort = [default_receive_port_class newForReceiving]; I just started to port my first big app to GNUstep: Cenon - it's a