[RFA/base] NSUndoManager cleanup

2003-07-14 Thread David Ayers
Hello, This patch cleans up the NSUndoManager and is the first step to get this bug fixed: http://savannah.gnu.org/bugs/?func=detailbug&bug_id=3797&group_id=99 The main changes are - implicitly beginUndoGrouping when groupsByEvent - implicitly register the _loop: invocation when groupsByEvent -

Re: [RFA/base] NSUndoManager cleanup

2003-07-14 Thread Adam Fedor
On Monday, July 14, 2003, at 03:02 AM, David Ayers wrote: +/** Defines run loop ordering for closing undo groupings. */ +enum { + NSUndoCloseGroupingRunLoopOrdering = 35 +}; + Wow documentation! I'd approve it just for that :-) /* Public notification */ GS_EXPORT NSString *NSUndoManagerChec

Re: [RFA/base] NSUndoManager cleanup

2003-07-15 Thread David Ayers
Adam Fedor wrote: Wow documentation! I'd approve it just for that :-) Caught the bait ;-) I sort-of hate to remove ivars unnecessarily, due to the (small) incompatibility it creates between different library versions. Perhaps just replace it by _unused1? I don't think an extra ivar adds that