Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter (2)

2001-03-06 Thread Georg Fleischmann
Hi Nicola, So - I'd rather propose the following change (I also added lots of comments to help future bug fixings) - if you can test it and it's Ok, we could use this one - I tested it: it doesn't do the job. startAngle = 0 endAngle = -450 clockwise it wouldn't work... it would draw a

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter (2)

2001-03-06 Thread Nicola Pero
Hi Georg, startAngle = 0 endAngle = -450 clockwise it wouldn't work... it would draw a full circumference rather than simply from -90 to 0 Thats exactly what it does, and I think its the correct behavior. Ok - so we don't agree on what the API is supposed to do. :-) To add to

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter (2)

2001-03-06 Thread Georg Fleischmann
Hi Nicola, Does this patch look right to you ? Absolutely, and it works for all I've tested. ...but I think the macos-x doc for NSBezierPath says that we should not draw the line in NSBezierPath. I need to look at it - but if the backend is using NSBezierPath to draw the arc, then what

Fix: NSBezierPath, appendBezierPathWithArcWithCenter (2)

2001-03-05 Thread Georg Fleischmann
I sligthly simplified the formula used for F - not that I changed it (unless I made a typo) - just did some trivial algebraic/trigonometric simplifications. But as I didn't test it, please tell me if I did something wrong. It works fine. Now, here is the fix for the remaining problem, I

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

2001-03-01 Thread Georg Fleischmann
Hi Nicola, Thanks - I read your patch and it made lot of sense - so I applied it. I did not test it nor did I check on books the formula used to build the bezier path for the last bit of the arc, so I hope you did. :-) Yes, I have tested it. Anyway, I had to realized another little problem

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

2001-03-01 Thread Nicola Pero
Hi Nicola, Thanks - I read your patch and it made lot of sense - so I applied it. I did not test it nor did I check on books the formula used to build the bezier path for the last bit of the arc, so I hope you did. :-) Yes, I have tested it. Anyway, I had to realized another little

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

2001-02-28 Thread Nicola Pero
Hi, attached is a patch with a bunch of fixes for NSBezierPath to make arcs being displayed. With the patch arcs should now work in any direction and angle. I also added a few lines of discription which I found in the ghostscript code. Thanks - I read your patch and it made lot of

Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

2001-02-26 Thread Georg Fleischmann
Hi, attached is a patch with a bunch of fixes for NSBezierPath to make arcs being displayed. With the patch arcs should now work in any direction and angle. I also added a few lines of discription which I found in the ghostscript code. Georg 2001-02-26 Georg Fleischmann *