bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8

2014-10-25 Thread Shlomi Fish
Hi all, On Sat, 25 Oct 2014 08:58:02 +0900 Norihiro Tanaka nori...@kcn.ne.jp wrote: Paul Eggert egg...@cs.ucla.edu wrote: The optimization was a hack anyway, and these bugs suggest that it's not a hack worth keeping. Thanks. I improved this hack instead of removal, but it had little

bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8

2014-10-25 Thread Jim Meyering
On Fri, Oct 24, 2014 at 1:38 PM, Paul Eggert egg...@cs.ucla.edu wrote: Thanks for looking into this. I added that test case, but took a more-conservative approach to fixing the bug, by disabling the optimization that's causing this problem; please see attached patches. The optimization was a

bug#18817: \w is not synonym for [[:alnum:]] in UTF-8 locales

2014-10-25 Thread Jim Meyering
This looks like a fine change. Thank you. Please also add a NEWS entry. On Fri, Oct 24, 2014 at 4:11 PM, Norihiro Tanaka nori...@kcn.ne.jp wrote: Eric Blake ebl...@redhat.com wrote: s/album/alnum/ Wow, typo! Thanks, I fixed it and added reporter in commit log.