[bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Follow-up Comment #7, bug #55449 (project groff): commit 9c5f9a862a7522665d9f84e38d86aef5e588e879 Author: Ingo Schwarze Date: Wed Oct 21 18:31:24 2020 +0200 On systems without NAME_MAX, use FILENAME_MAX as a last resort. Problem reported by Eli Zaretskii on MS Windows in

Re: [bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Ingo Schwarze wrote in <20201021231159.ge12...@athene.usta.de>: ... |Now, arguably, if pathconf(3) fails, which can easily happen if the |input argument is garbage, the function should not return (size_t)-1, |which is a large value. ... |Anyone willing to fix this particular bug? I have

Re: [bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Hi Carsten, Carsten Kunze hat am 21. Oktober 2020 um 21:23 geschrieben: > How about at first using pathconf(3) with the constant _PC_NAME_MAX > to determine the file name length (for a specfific path) and using > the constants only when pathconf returns -1? The file already does that, if

[bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Update of bug #55449 (project groff): Status: Need Info => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #6: Pushed in

Re: [bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

I forgot it need to compile on Windows--sorry for the noise. > Carsten Kunze hat am 21. Oktober 2020 um 21:23 > geschrieben: > > > How about at first using pathconf(3) with the constant _PC_NAME_MAX to > determine the file name length (for a specfific path) and using the constants > only

Re: [bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

How about at first using pathconf(3) with the constant _PC_NAME_MAX to determine the file name length (for a specfific path) and using the constants only when pathconf returns -1? > Ingo Schwarze hat am 21. Oktober 2020 um 18:43 > geschrieben: > > > Update of bug #55449 (project groff): >

[bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Follow-up Comment #5, bug #55449 (project groff): Yes, the patch works, thanks. ___ Reply to this item at: ___ Message sent via Savannah

[bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Update of bug #55449 (project groff): Assigned to:None => schwarze Planned Release:None => 1.23 ___ Follow-up Comment #4: The patch #45943 is

[bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Follow-up Comment #3, bug #55449 (project groff): Granted, the patch was tested, and works in the port of Groff I use every day since that report. But maybe you wanted a "second opinion"? ___ Reply to this item at:

[bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Update of bug #55449 (project groff): Status:None => Need Info ___ Follow-up Comment #2: Do we have someone with access to a Windows machine to test this on? Eli filed it almost

[bug #55449] [PATCH] Use FILENAME_MAX in maxfilename.cpp

Update of bug #55449 (project groff): Summary: Use FILENAME_MAX in maxfilename.cpp => [PATCH] Use FILENAME_MAX in maxfilename.cpp ___ Reply to this item at: