[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #18, bug #64360 (project groff): If it's a bug for a 'w' command to be missing when it _should_ be there, then it appears my change in comment #8 is fixing one. I'm not sure what the root-cause is, but I saw the following when updating my test case expectations to accommodate

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #17, bug #64360 (project groff): [comment #16 comment #16:] > [comment #15 comment #15:] > > I strongly object to your characterization of this as a > > proposed API change. It is not. It honors the letter and > > spirit of CSTR #54, > > If the layout of groff's output

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #16, bug #64360 (project groff): [comment #15 comment #15:] > I strongly object to your characterization of this as a > proposed API change. It is not. It honors the letter and > spirit of CSTR #54, If the layout of groff's output language hasn't changed in 30+ years, there's

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #15, bug #64360 (project groff): [comment #14 comment #14:] > Exactly, it is not a word gap its a horizontal move. It seems we are in agreement. But that is not an argument against this ticket. > Please can you explain the practical benefit for this change. Please review

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #14, bug #64360 (project groff): Exactly, it is not a word gap its a horizontal move. Please can you explain the practical benefit for this change. Perhaps on the list given that it is a change the current api between groff and the output drivers.

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #13, bug #64360 (project groff): Thanks. Mmmm, crunchy. But the presence of an 'h' command after 't' (or 'N' or 'C' or a legacy move-and-print command) does not necessarily imply kerning. It indicate motion to the next tab stop. $ printf 'A\tB\n' | ./build/test-groff -Z x T

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #11, bug #64360 (project groff): [comment #10 comment #10:] > Yes, I have seen multiple "w", but never one followed by a space. I've never seen multiple 'w' commands in sequence without some other command in between. I can't remember if I've seen 'w' followed by a space. >

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #10, bug #64360 (project groff): Yes, I have seen multiple "w", but never one followed by a space. I thought commands and arguments with a known fixed length (such as the w command) aren't separated by syntactical space. Well, that was true until now. Previously, before you

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #9, bug #64360 (project groff): Yes, I have seen multiple "w", but never one followed by a space, can you work out why? I thought commands and arguments with a known fixed length (such as the w command) aren't separated by syntactical space. Well, that was true until now.

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #8, bug #64360 (project groff): [comment #3 comment #3:] > How did you get groff to plant the space? Whoops, I was momentarily smoking crack, and didn't answer the question you asked. I didn't hack GNU troff to produce a space here, but I did change it to produce a newline,

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #7, bug #64360 (project groff): [comment #5 comment #5:] > > [comment #3 comment #3:] > > Just move this line:- > > > > $lin=~s/^\s+//; > > > > to before the while loop. > > Oh. This is what I came up with. Is it wrong? I guess it is. I didn't understand you

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #5, bug #64360 (project groff): [comment #3 comment #3:] > Just move this line:- > > $lin=~s/^\s+//; > > to before the while loop. Oh. This is what I came up with. Is it wrong? diff --git a/src/devices/gropdf/gropdf.pl b/src/devices/gropdf/gropdf.pl index

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Update of bug #64360 (project groff): Status: In Progress => Need Info ___ Follow-up Comment #6: Sending back to you for comment. ___

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #4, bug #64360 (project groff): I'd like to propose a small code cleanup. diff --git a/ChangeLog b/ChangeLog index bc268e1f3..373fab6df 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2023-06-27 G. Branden Robinson + + * src/devices/gropdf/gropdf.pl: Fix code

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Follow-up Comment #3, bug #64360 (project groff): Just move this line:- $lin=~s/^\s+//; to before the while loop. How did you get groff to plant the space? ___ Reply to this item at:

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Update of bug #64360 (project groff): Status: Need Info => In Progress Assigned to:deri => gbranden ___ Follow-up Comment #2: Whoops, no, that

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

Update of bug #64360 (project groff): Status:None => Need Info Assigned to:None => deri ___ Follow-up Comment #1: I propose the

[bug #64360] [gropdf] does not correctly handle white space after 'w' command

URL: Summary: [gropdf] does not correctly handle white space after 'w' command Group: GNU roff Submitter: gbranden Submitted: Tue 27 Jun 2023 03:17:09 PM UTC Category: Driver