bug#31366: Missing icons in virt-manager user-interface

2018-08-27 Thread Vagrant Cascadian
On 2018-05-04, Vagrant Cascadian wrote: > Many of the icons appear to be missing from the user interface, such as > the button for "Power on", "Pause the virtual machine", "Shut down the > virtual machine" and "Show virtual hardware details". > > Also, selecting the "Show virtual hardware details"

bug#32548: Cuirass: Performance monitoring

2018-08-27 Thread Ludovic Courtès
As discussed earlier today on IRC with Clément, we could add performance monitoring capabilities to Cuirass. Interesting metrics would be: • time of push to time of evaluation completion; • time of evaluation completion to time of build completion. We could visualize that per job over

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-27 Thread Clément Lassieur
Carlo Zancanaro writes: >>Anyway, it all LGTM, thanks! > > Pushed! Thanks for the review. > > Carlo Awesome! Thanks a lot Carlo for working on this :-)

bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread.

2018-08-27 Thread Clément Lassieur
Thank you for the explanation Danny. Indeed I didn't fix what you described. That could be done easily by wrapping the handler with WITH-DB-CRITICAL-SECTION. I'm not sure about the consequences in terms of performance, given that this will send a huge function to a channel, and that all the

bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread.

2018-08-27 Thread Clément Lassieur
Ludovic Courtès writes: > Hi Clément, > > Clément Lassieur skribis: > >> Ludovic Courtès writes: >> >>> Excellent, thanks for working on this! This looks great to me, and I >>> think the pros outweigh the cons. Did you check on a big database how >>> well it performs? >> >> Yes, I didn't

bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread.

2018-08-27 Thread Clément Lassieur
Hi Danny, Danny Milosavljevic writes: > Hi Clément, > > in the future I plan on making the actual bin/evaluate use another database > connection > in order for the web interface to be isolated while it's querying. I don't understand... bin/evaluate doesn't query the database at all. I don't

bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread.

2018-08-27 Thread Danny Milosavljevic
Hi Clément, in the future I plan on making the actual bin/evaluate use another database connection in order for the web interface to be isolated while it's querying. Otherwise - as it is now in master - it can happen that while you are querying one page, half of the things have different

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-27 Thread Carlo Zancanaro
On Mon, Aug 27 2018, Ludovic Courtès wrote: I see that you also reverted the patch that removed the ‘EINTR-safe’ workaround. Could you explain why that was necessary? (It should not be necessary with current Guile versions.) I'm not really sure of the details, but as I mentioned on IRC,

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-27 Thread Ludovic Courtès
Hi, Carlo Zancanaro skribis: > Pushed! Thanks for the review. Great! I see that you also reverted the patch that removed the ‘EINTR-safe’ workaround. Could you explain why that was necessary? (It should not be necessary with current Guile versions.) Thank you, Ludo’.

bug#32540: Cuirass: we need a way to manually trigger evaluations

2018-08-27 Thread Gábor Boskovits
Clément Lassieur ezt írta (időpont: 2018. aug. 27., H, 11:54): > The 'core-updates' and 'staging' branches shouldn't trigger evaluations > at each commit, because they produce too many derivations. Instead, the > admins should have a 'trigger evaluation' button that they use once in a > while.

bug#32540: Cuirass: we need a way to manually trigger evaluations

2018-08-27 Thread Clément Lassieur
The 'core-updates' and 'staging' branches shouldn't trigger evaluations at each commit, because they produce too many derivations. Instead, the admins should have a 'trigger evaluation' button that they use once in a while. That button should be part of an 'admin interface', which should be

bug#32539: Cuirass: a commit that updates doc will produce 86 tests

2018-08-27 Thread Clément Lassieur
Evaluation 338[1] is triggered by commit 1d8d69c[2], which only updates the documentation. This evaluation produces 86 useless tests: test.mcron.i686-linux, test.opensmtpd.i686-linux, etc. I believe those tests are triggered at each evaluation (almost), and it's a considerable waste of