Arun Isaac writes:
> Pushed! :-)
>
> Made a few minor modifications to the commit message...
Thank you, Arun!
Maxim
Pushed! :-)
Made a few minor modifications to the commit message...
Alex Kost writes:
> Sure, I didn't mean I was ignored, I just wanted to say that I got the
> same thought about those arguments as Maxim.
No hard feelings! :-) debbugs can be a pain to read. I thought you
missed that message from me.
> As I said, I think this duplication can be avoided simply b
Arun Isaac (2017-06-05 15:33 +0530) wrote:
> Please make any other changes you think are necessary, and push. Thanks!
Thanks, but I'm afraid I'm not competent to judge about the first
patch. I don't really know what is used on build side and on host side,
and whether these things can be mixed li
Arun Isaac (2017-06-05 00:55 +0530) wrote:
[...]
>> I also think these arguments are redundant! I suggested to remove this
>> duplication at:
>>
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559#41
>
> And, I did respond at
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559#53
Sure, I
Hello Arun,
Arun Isaac writes:
>> this might have to do with the fact that until recently most Elisp
>> projects were organized as a single file of thousands of lines of code
>> ;).
>
> Exactly! :-)
>
>> I've also factorized out the default args of the include and exclude
>> option of the emacs-
> this might have to do with the fact that until recently most Elisp
> projects were organized as a single file of thousands of lines of code
> ;).
Exactly! :-)
> I've also factorized out the default args of the include and exclude
> option of the emacs-build-system install phase. Please see the
Hello,
Arun Isaac writes:
>> As far as I understand it, it was done for purpose: some packages
>> include "uninteresting" (for tests, maintenance, etc.) *.el files in
>> subdirs, that's why they are excluded by default. So probably a better
>> solution would be to fix 'ert-runner' package (as i
Maxim Cournoyer (2017-06-04 09:44 -0700) wrote:
[...]
>>>(phases '(@ (guix build emacs-build-system)
>>>%standard-phases))
>>>(outputs '("out"))
>>> - (include ''("^[^/]*\\.el$" "^[^/]*\\.info$
> As far as I understand it, it was done for purpose: some packages
> include "uninteresting" (for tests, maintenance, etc.) *.el files in
> subdirs, that's why they are excluded by default. So probably a better
> solution would be to fix 'ert-runner' package (as it is done in commit
> b1d32ec0e2
Hello,
Alex Kost writes:
> I Cc-ed Arun, the author of the mentioned change (commit
> d879685176d23c111f4fc665698251b25cdf9124).
>
> [...]
>> From a035d07dfa6cbddccfa0476e2009d19bdf296941 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer
>> Date: Sat, 3 Jun 2017 23:43:02 -0700
>> Subject: [PATC
I Cc-ed Arun, the author of the mentioned change (commit
d879685176d23c111f4fc665698251b25cdf9124).
[...]
> From a035d07dfa6cbddccfa0476e2009d19bdf296941 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer
> Date: Sat, 3 Jun 2017 23:43:02 -0700
> Subject: [PATCH] build-system: emacs: Install elisp f
Hello,
The previous regexp would have worked, but what got me was that the
default keyword arguments values were duplicated (and I was fixing the
useless version in build/emac-build-system.scm instead of the one used
in build-system/emacs.scm).
The attached patch fixes this particular problem (te
13 matches
Mail list logo
