bug#47375: guix test failure: tests/print

2021-03-24 Thread Léo Le Bouter via Bug reports for GNU Guix
FAIL: tests/print = test-name: simple package location: /tmp/guix-build-guix-1.2.0-18.86dd54f.drv- 0/source/tests/print.scm:70 source: + (test-equal + "simple package" + `(define-public test ,pkg-source) + (package->code pkg)) expected-value: (define-public test (package (nam

bug#47375: guix test failure: tests/print

2021-03-24 Thread Julien Lepiller
I don't think this is the right fix. Now you define packages with the incorrect url-fetch, so the test passes, but package->code would still not work as intended on actual packages that are properly defined. It seems that the issue is package->code uses the internal name url-fetch* whereas it s

bug#47375: guix test failure: tests/print

2021-03-24 Thread Chris Marusich
Hi, Julien Lepiller writes: > I don't think this is the right fix. Now you define packages with the > incorrect url-fetch, so the test passes, but package->code would still > not work as intended on actual packages that are properly defined. > > It seems that the issue is package->code uses the

bug#47375: guix test failure: tests/print

2021-03-25 Thread Maxime Devos
On Wed, 2021-03-24 at 20:59 -0700, Chris Marusich wrote: > [..] > > In guix/import/print.scm, package->code generates the code by invoking > (origin-method source) to get the origin's "method", and then invoking > (procedure-name method) on the method thus obtained. It seems that > procedure-name

bug#47375: guix test failure: tests/print

2021-03-25 Thread Maxime Devos
Oops I messed up the commit message in the patch. Revised patch is attached. From 2c6c28334173fff9112c36726d31d6adcebfbf2d Mon Sep 17 00:00:00 2001 From: Maxime Devos Date: Thu, 25 Mar 2021 08:48:24 +0100 Subject: [PATCH] guix: Let the procedure name of "url-fetch*" be what "guix import" expects.

bug#47375: guix test failure: tests/print

2021-03-25 Thread Ludovic Courtès
Hi! Instead of renaming ‘url-fetch*’, I changed the thing that guesses the procedure name so that it preferable uses the procedure’s public name, rather than the name it has within its module. Done in 96aa98b6ca78ffb798e309acac3c3e5068422f30. Thanks, and apologies for the breakage! Ludo’.

bug#47375: guix test failure: tests/print

2021-03-25 Thread Ludovic Courtès
Léo Le Bouter skribis: > Full log: https://ci.guix.gnu.org/build/117996/log/raw Speaking of which: please always build packages before pushing. :-) Thanks, Ludo’.

bug#47375: guix test failure: tests/print

2021-03-25 Thread Léo Le Bouter via Bug reports for GNU Guix
On Fri, 2021-03-26 at 00:24 +0100, Ludovic Courtès wrote: > Léo Le Bouter skribis: > > > Full log: https://ci.guix.gnu.org/build/117996/log/raw > > Speaking of which: please always build packages before pushing. :-) > > Thanks, > Ludo’. I ran 'guix pull' but turns out that wasnt sufficient.

bug#47375: guix test failure: tests/print

2021-03-28 Thread Ludovic Courtès
Hi, Léo Le Bouter skribis: > On Fri, 2021-03-26 at 00:24 +0100, Ludovic Courtès wrote: >> Léo Le Bouter skribis: >> >> > Full log: https://ci.guix.gnu.org/build/117996/log/raw >> >> Speaking of which: please always build packages before pushing. :-) >> >> Thanks, >> Ludo’. > > I ran 'guix p

bug#47375: guix test failure: tests/print

2021-03-28 Thread Léo Le Bouter via Bug reports for GNU Guix
On Sun, 2021-03-28 at 18:25 +0200, Ludovic Courtès wrote: > When updating the ‘guix’ package, what you need to run is: > > ./pre-inst-env guix build guix > > It’s similar to other packages. > > In general, we update it when there are changes to the daemon and its > helper programs (‘guix subst