bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-07-04 Thread Ludovic Courtès
Hi, "(" skribis: > On Tue Jun 28, 2022 at 11:38 AM BST, Maxime Devos wrote: >> Then it could be fixed in that distro? And if the distro intentionally >> keeps it broken for years, then that seems more a problem in the distro >> than Guix to me. > > I believe Ludo' is referring to LTS distros

bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-28 Thread Maxime Devos
( schreef op di 28-06-2022 om 17:57 [+0100]: > On Tue Jun 28, 2022 at 11:38 AM BST, Maxime Devos wrote: > > Then it could be fixed in that distro? And if the distro intentionally > > keeps it broken for years, then that seems more a problem in the distro > > than Guix to me. > > I believe Ludo'

bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-28 Thread paren--- via Bug reports for GNU Guix
On Tue Jun 28, 2022 at 11:38 AM BST, Maxime Devos wrote: > Then it could be fixed in that distro? And if the distro intentionally > keeps it broken for years, then that seems more a problem in the distro > than Guix to me. I believe Ludo' is referring to LTS distros and other situations where

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-28 Thread Maxime Devos
Ludovic Courtès schreef op di 28-06-2022 om 09:45 [+0200]: > Maxime Devos skribis: > > > Ludovic Courtès schreef op ma 27-06-2022 om 12:17 [+0200]: > > > I agree that Dash should be fixed, but in the meantime, we still want > > > our stuff to work with the broken Dash (it’s the default on > > >

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-28 Thread Ludovic Courtès
Maxime Devos skribis: > Ludovic Courtès schreef op ma 27-06-2022 om 12:17 [+0200]: >> I agree that Dash should be fixed, but in the meantime, we still want >> our stuff to work with the broken Dash (it’s the default on >> Debian/Ubuntu, isn’t it?). > > If Dash is fixed, then it's non-broken

bug#51466: bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-27 Thread Bengt Richter
On +2022-06-27 13:23:15 +0200, b...@bokr.com wrote: > > > If this is all about capturing an environment as text, > how about > > --8<---cut here---start->8--- > xargs -0 < /proc/$$/environ > --8<---cut here---end--->8--- > >

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-27 Thread bokr
On +2022-06-27 12:17:08 +0200, Ludovic Courtès wrote: > Hi Chris, > > Chris Marusich skribis: > > > It turns out that it is probably not OK to rely on shell redirection in > > this case, after all. For example, "dash does not support multi-digit > > file descriptors": > > > >

bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-27 Thread Maxime Devos
Ludovic Courtès schreef op ma 27-06-2022 om 12:17 [+0200]: > I agree that Dash should be fixed, but in the meantime, we still want > our stuff to work with the broken Dash (it’s the default on > Debian/Ubuntu, isn’t it?). If Dash is fixed, then it's non-broken, and we don't have to work with the

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-27 Thread Ludovic Courtès
Hi Chris, Chris Marusich skribis: > It turns out that it is probably not OK to rely on shell redirection in > this case, after all. For example, "dash does not support multi-digit > file descriptors": > > https://bugs.launchpad.net/ubuntu/+source/dash/+bug/249620 Bah. :-/ [...] > To

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-26 Thread Maxime Devos
Josselin Poiret schreef op zo 26-06-2022 om 12:33 [+0200]: > Just my 2¢, from my experience, Guile uses a lot of fds (`guile -q` uses > 15).  I'm not sure it would be safe or advisable to move fds, since we > cannot be sure that they're backing ports or not, and if they're not it > would break

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-26 Thread Josselin Poiret via Bug reports for GNU Guix
Hello everyone, Maxime Devos writes: > Chris Marusich schreef op za 25-06-2022 om 09:52 [-0700]: >> [...] >> the problem was that I could not control Guile's choice >> of >> file descriptors.  Guile chose file descriptor 19 for one end of the >> pipe, and I don't know how to make it use

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-25 Thread Maxime Devos
b...@bokr.com schreef op za 25-06-2022 om 22:06 [+0200]: > BTW, IIRC, this can be used to create an invisible file that Invisible files don't have file names, so they cannot be put in the tiny shell script: > +(format > + #f "env >~a || /usr/bin/env >~a || set >~a; \ > +echo

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-25 Thread bokr
On +2022-06-25 19:40:48 +0200, Maxime Devos wrote: > Chris Marusich schreef op za 25-06-2022 om 09:52 [-0700]: > > Yes, I agree those are good reasons to avoid a temporary file if we > > can. > > To that end, do you know if we can somehow force Guile to use a > > specific > > file descriptor for

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-25 Thread Chris Marusich
Hi Maxime, Maxime Devos writes: > Chris Marusich schreef op za 25-06-2022 om 02:07 [-0700]: >> It turns out that it is probably not OK to rely on shell redirection >> in >> this case, after all.  For example, "dash does not support multi- >> digit >> file descriptors": >> >>

bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-25 Thread Maxime Devos
Chris Marusich schreef op za 25-06-2022 om 02:07 [-0700]: > It turns out that it is probably not OK to rely on shell redirection > in > this case, after all.  For example, "dash does not support multi- > digit > file descriptors": > > https://bugs.launchpad.net/ubuntu/+source/dash/+bug/249620 I

bug#51466: bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-20 Thread Thiago Jung Bauermann via Bug reports for GNU Guix
Hello, Bengt Richter writes: > Lots could be prettier if bash could be extended with scheme. Today is your lucky day. :-) $ guix show guile-bash | recsel -p name,synopsis name: guile-bash synopsis: Extend Bash using Guile -- Thanks Thiago

bug#51466: bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-20 Thread Bengt Richter
Sorry again, but I found the source: tl;dr: These functions are defined in /usr/share/bash-completion/bash_completion which looks awful kludgey to me, (however clever :) There is a reference to http://lists.gnu.org/archive/html/bug-bash/2009-03/msg00155.html in the header comments for

bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-20 Thread Bengt Richter
Sorry to reply to myself, but forgot to illustrate. On +2022-06-20 12:12:10 +0200, b...@bokr.com wrote: > Hi Chris, [...] > > I have had some mystery bash parsing errors, and I noticed > set|less > shows a heck of a lot of functions defined that I don't > remember seeing in the past. >

bug#53355: bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-20 Thread bokr
Hi Chris, Did you observe this behaviour inside a git repo directory? I wonder if this git security thing could be relevant: https://lwn.net/Articles/892755/ It makes also me wonder about readline completion stuff possibly interacting. Isn't that implemented with readline? I have had some

bug#51466: bug#53355: guix shell --check: confusing error message

2022-06-19 Thread Chris Marusich
Hi Ludo, Thank you for the review! Ludovic Courtès writes: > LGTM, please push! Before pushing, I did some more tests to make sure it was still working. When I did this, I noticed that read-line was no longer returning strings that end in "\r". This prevents child-shell-environment from

bug#51466: bug#53355: guix shell --check: confusing error message

2022-05-20 Thread Ludovic Courtès
Hi Chris, A friendly ping. :-) Ludo’. Ludovic Courtès skribis: > Hi Chris, > > Did you have a chance to look into it? > > https://issues.guix.gnu.org/53355 > > TIA. :-) > > Ludo’. > > Ludovic Courtès skribis: > >> Hi Chris, >> >> Thanks for debugging this! >> >> Chris Marusich skribis:

bug#51466: bug#53355: guix shell --check: confusing error message

2022-03-08 Thread Ludovic Courtès
Hi Chris, Did you have a chance to look into it? https://issues.guix.gnu.org/53355 TIA. :-) Ludo’. Ludovic Courtès skribis: > Hi Chris, > > Thanks for debugging this! > > Chris Marusich skribis: > >> From c3eea81846ae71a246e6b592be74062f4bf26474 Mon Sep 17 00:00:00 2001 >> From: Chris

bug#51466: bug#53355: guix shell --check: confusing error message

2022-02-14 Thread Ludovic Courtès
Hi Chris, Thanks for debugging this! Chris Marusich skribis: > From c3eea81846ae71a246e6b592be74062f4bf26474 Mon Sep 17 00:00:00 2001 > From: Chris Marusich > Date: Sun, 13 Feb 2022 14:15:14 -0800 > Subject: [PATCH] environment: Prevent PS1 from clobbering output in 'check'. > > Fixes:

bug#51466: bug#53355: guix shell --check: confusing error message

2022-02-13 Thread Chris Marusich
Hi Ludo, Ludovic Courtès writes: > How about this: > > diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm > index ec071402f4..ac2c79ab65 100644 > --- a/guix/scripts/environment.scm > +++ b/guix/scripts/environment.scm > @@ -420,7 +420,7 @@ (define script > ;; Script

bug#51466: bug#53355: guix shell --check: confusing error message

2022-02-08 Thread Ludovic Courtès
Hi Chris, Thanks for testing! Chris Marusich skribis: > The presence of the "$" in front of LIBRARY_PATH seems suspicious: > > ;;; (variable "$ > LIBRARY_PATH=/gnu/store/hvcq6yjfjjc7060pq09zm1rj02mivg4h-profile/lib" "$ > LIBRARY_PATH") > > I'm not sure why the "$" is being added. I tried

bug#51466: bug#53355: guix shell --check: confusing error message

2022-02-01 Thread Chris Marusich
Hi, I also observed this bug and reported it as 53355. I tried to search for bugs, but I didn't find this bug report until Ludo mentioned it. I think it's probably the same bug, so I've merged them. Ludovic Courtès writes: > It looks like the shell-check machinery is misdiagnosing things, as