bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-08-04 Thread Pierre Neidhardt
Excellent, thanks a lot! :) signature.asc Description: PGP signature

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-08-03 Thread Guillaume Le Vaillant
Pierre Neidhardt skribis: > I'll be the road for a while, unable to work on this patch, so if anyone > wants to work on it and merge, please go ahead :) > > Left to do: > > - Suggestion: add a keyword to choose between asdf:compile-system and > asdf:load-system (default should be asdf:load-syst

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-17 Thread Pierre Neidhardt
I've pushed the SBCL closure size reduction. I'll be the road for a while, unable to work on this patch, so if anyone wants to work on it and merge, please go ahead :) Left to do: - Suggestion: add a keyword to choose between asdf:compile-system and asdf:load-system (default should be asdf:loa

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-05 Thread Pierre Neidhardt
While we are rebuilding the Lisp world, I suggest we remove Coreutils from the SBCL closure since it's only needed on LispWorks and on non-Linux: --8<---cut here---start->8--- (add-after 'install 'remove-coreutils-references ;; They are only useful on

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-04 Thread Pierre Neidhardt
Find the first draft attached. Do not merge, we need to figure out what to do with sbcl-stumpwm-kbd-layouts. signature.asc Description: PGP signature This fixes 2 flaws in the asdf-build-system: 1. Use asdf:load-system instead of asdf:compile-system. The latter is not recommended by the manual

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-04 Thread Pierre Neidhardt
I found a blocker: Some StumpWM contribs like sbcl-stumpwm kbd-layout make calls at the top level which expect a running session of StumpWM, and thus asd:load-system will fail on them, while asdf:compile-system used to work. Suggestion: add an option to our build system to choose between asdf:load

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-03 Thread Guillaume Le Vaillant
Pierre Neidhardt skribis: > Robert Goldman from ASDF found out why the "COMPONENT not found" issue > happens: > > https://gitlab.common-lisp.net/asdf/asdf/-/issues/119#note_9808 > > So either we fix most of the Prove-depending libraries, or we just do > what's expected from every one, that is, a

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-02 Thread Pierre Neidhardt
Robert Goldman from ASDF found out why the "COMPONENT not found" issue happens: https://gitlab.common-lisp.net/asdf/asdf/-/issues/119#note_9808 So either we fix most of the Prove-depending libraries, or we just do what's expected from every one, that is, add the directory to the ASDF registries.

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Pierre Neidhardt
Exactly, I already wrote the patch that did! :) Will send soon, need to do some more testing. signature.asc Description: PGP signature

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Guillaume Le Vaillant
Pierre Neidhardt skribis: > Hi Guillaume, > > I gave it a go and your suggestion indeed cuts it for cleavir and > cl-gamepad. > > It did not fix it for the tests though. > > I did some more testing, and this is what I found out on one of the > failing systems (cl-reexport): from a --pure sbcl rep

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Pierre Neidhardt
Hi Guillaume, I gave it a go and your suggestion indeed cuts it for cleavir and cl-gamepad. It did not fix it for the tests though. I did some more testing, and this is what I found out on one of the failing systems (cl-reexport): from a --pure sbcl repl, if I load the .asd files manually then r

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Liliana Marie Prikler
Am Freitag, dem 01.07.2022 um 12:16 +0200 schrieb Pierre Neidhardt: > [...] > > From the ASDF doc: > > --8<---cut here---start->8--- > This will make sure all the files in the system are compiled, but not > necessarily load any of them in the current image; on

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Pierre Neidhardt
Hi Liliana, It's tempting to think that Guix packages are good candidates for "build scripts", but in the face of it, it may very well be that ASDF authors had something completely different in mind. In any case, asdf:compile-system seems to be underused to the point that barely anyone beside Gui

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Guillaume Le Vaillant
Pierre Neidhardt skribis: > Do you have time to try it out? Not right now, as I'm about to take a vacation. The main change is a one-liner in the 'compile-systems' function in "guix/build/lisp-utils.scm"; that would be quick. However recompiling all the Lisp packages and finding which of them c

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Pierre Neidhardt
Do you have time to try it out? signature.asc Description: PGP signature

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Guillaume Le Vaillant
Pierre Neidhardt skribis: > While trying to package > > https://github.com/s-expressionists/Cleavir > > I hit a strange issue in which it would fail to compile, while calling > `asdf:load-system' locally worked. > > Then I realized that our asdf-build-system/sbcl uses > `asdf:compile-system'

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-01 Thread Pierre Neidhardt
While trying to package https://github.com/s-expressionists/Cleavir I hit a strange issue in which it would fail to compile, while calling `asdf:load-system' locally worked. Then I realized that our asdf-build-system/sbcl uses `asdf:compile-system' instead of `asdf:load-system'. From the AS