Re: [PATCH,HURD] Add SysV SHM support

2012-05-14 Thread Kalle Olavi Niemitalo
Samuel Thibault samuel.thiba...@gnu.org writes: +/* Removes a segment attachment. Returns its size if found, or EINVAL + otherwise. */ +error_t +__sysvshm_remove (void *addr, size_t *size) Doesn't literally return the size. There is a more accurate comment in sysvshm.h; perhaps this one

Re: [PATCH,HURD] Add SysV SHM support

2012-05-14 Thread Roland McGrath
I can't see how this patch could apply to the trunk code. Please submit a patch that is verified to do so. 2005-07-11 Marcus Brinkmann mar...@gnu.org Note for the actual commit: we now use the date of merge rather than the original date in the ChangeLog entry. * hurd/Makefile

Re: [PATCH,HURD] hurd: compliance fixes for getgroups

2012-05-14 Thread Roland McGrath
Since I see you already have copyright paperwork and you're doing more than just the one change, would you like to get set up to commit yourself? Given also my contributions so far, I guess that I should better need review for now, no? Everybody needs review. Getting set up to do your